Page MenuHomePhabricator

Fix "1 notice" on more wikis
Open, MediumPublic8 Estimated Story Points


Like T95822 and T103693, but for these: (some of which may actually be fine, but most won't)

Please update this description if you find any more, and remove any that are false positives.

Steps for migrating at (simple case) and (advanced case).

Event Timeline

Restricted Application added subscribers: Zppix, revi, Aklapper. · View Herald Transcript

No false positives that I could find.

Jdforrester-WMF moved this task from To Triage to TR1: Releases on the VisualEditor board.
Jdforrester-WMF set the point value for this task to 8.

I just did both that and MediaWiki:Editnotice-3

As there are over 25 different notices there, paging @Krinkle in case he can figure out which one should be fixed.

@Krinkle, da.wp is again displaying it empty, it seems. maybe T153118? PS: must be that. I could reproduce on but not elsewhere, so...

@Elitre Thanks, I can reproduce this.

Screen Shot 2017-05-25 at 16.59.30.png (1×1 px, 307 KB)

Looks like one of the editnotice messages created by users on that wiki always outputs "something" even when there isn't anything really. It defaults to <div id="editnotice-area"></div> with nothing in it. It should be fixed to only wrap the notice in this DIV when there actually is a notice, and if not, then it should output nothing.

(Now if that means I can do anything to help, it should probably get reworded :D )