Page MenuHomePhabricator
Create Task
Maniphest T135485

[Bug] File deletion problem on commons.wikimedia.org
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

As a commons admin I try to delete https://commons.wikimedia.org/wiki/File:Fran%C3%A7ois-Joseph_Gossac.jpeg. A file with a wrong written filename and duplicate to File:François-Joseph Gossec.jpeg. The deletion call results reproducible in a very sparse error message: (html source code)

<html><head></head><body>Exception encountered, of type "Wikibase\Client\Usage\UsageTrackerException" </body></html>

See also:

Details

SubjectRepoBranchLines +/-
Use DeferredUpdates in DataUpdateHookHandlers for deletionsmediawiki/extensions/Wikibasewmf/1.27.0-wmf.23+5 -2
Use DeferredUpdates in DataUpdateHookHandlers for deletionsmediawiki/extensions/Wikibasemaster+5 -2
Customize query in gerrit

Related Objects

Event Timeline

Wdwd created this task.May 17 2016, 9:24 AM
Restricted Application added subscribers: Zppix, Steinsplitter, Aklapper. · View Herald TranscriptMay 17 2016, 9:24 AM
Sjoerddebruin added projects: SRE, MediaWiki-Page-deletion, Commons, SRE-swift-storage, MediaWiki-extensions-WikibaseClient.May 17 2016, 9:34 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptMay 17 2016, 9:34 AM
Restricted Application added a subscriber: Poyekhali. · View Herald Transcript
Lydia_Pintscher added subscribers: daniel, hoo, aude.May 17 2016, 10:44 AM
Storkk subscribed.May 17 2016, 2:04 PM

Identical error is happening for https://commons.wikimedia.org/wiki/File:August_Kierspel.jpg

Krenair added a project: Wikimedia-production-error.May 17 2016, 3:30 PM
Krenair subscribed.
2016-05-17 14:04:04 [Vzsk1ApAIDkAABQShV0AAAAQ] mw1187 commonswiki 1.28.0-wmf.1 exception ERROR: [Vzsk1ApAIDkAABQShV0AAAAQ] /w/index.php?title=File:August_Kierspel.jpg&action=delete   Wikibase\Client\Usage\UsageTrackerException from line 227 of /srv/mediawiki/php-1.28.0-wmf.1/extensions/Wikidata/extensions/Wikibase/client/includes/Usage/Sql/SqlUsageTracker.php: Got explicit BEGIN from Wikibase\Client\Usage\Sql\EntityUsageTable::removeUsages while atomic section(s) FileDeleteForm::doDelete are open. {"exception_id":"Vzsk1ApAIDkAABQShV0AAAAQ"} 
[Exception Wikibase\Client\Usage\UsageTrackerException] (/srv/mediawiki/php-1.28.0-wmf.1/extensions/Wikidata/extensions/Wikibase/client/includes/Usage/Sql/SqlUsageTracker.php:227) Got explicit BEGIN from Wikibase\Client\Usage\Sql\EntityUsageTable::removeUsages while atomic section(s) FileDeleteForm::doDelete are open.
  #0 /srv/mediawiki/php-1.28.0-wmf.1/extensions/Wikidata/extensions/Wikibase/client/includes/Store/UsageUpdater.php(134): Wikibase\Client\Usage\Sql\SqlUsageTracker->pruneUsages(integer)
  #1 /srv/mediawiki/php-1.28.0-wmf.1/extensions/Wikidata/extensions/Wikibase/client/includes/Hooks/DataUpdateHookHandlers.php(177): Wikibase\Client\Store\UsageUpdater->pruneUsagesForPage(integer)
  #2 /srv/mediawiki/php-1.28.0-wmf.1/extensions/Wikidata/extensions/Wikibase/client/includes/Hooks/DataUpdateHookHandlers.php(88): Wikibase\Client\Hooks\DataUpdateHookHandlers->doArticleDeleteComplete(integer, integer)
  #3 /srv/mediawiki/php-1.28.0-wmf.1/includes/Hooks.php(195): Wikibase\Client\Hooks\DataUpdateHookHandlers::onArticleDeleteComplete(WikiFilePage, User, string, integer, WikitextContent, ManualLogEntry)
  #4 /srv/mediawiki/php-1.28.0-wmf.1/includes/page/WikiPage.php(2925): Hooks::run(string, array)
  #5 /srv/mediawiki/php-1.28.0-wmf.1/includes/FileDeleteForm.php(196): WikiPage->doDeleteArticleReal(string, boolean, integer, boolean, string, User)
  #6 /srv/mediawiki/php-1.28.0-wmf.1/includes/FileDeleteForm.php(120): FileDeleteForm::doDelete(Title, LocalFile, string, string, boolean, User)
  #7 /srv/mediawiki/php-1.28.0-wmf.1/includes/page/ImagePage.php(999): FileDeleteForm->execute()
  #8 /srv/mediawiki/php-1.28.0-wmf.1/includes/actions/DeleteAction.php(54): ImagePage->delete()
  #9 /srv/mediawiki/php-1.28.0-wmf.1/includes/MediaWiki.php(503): DeleteAction->show()
  #10 /srv/mediawiki/php-1.28.0-wmf.1/includes/MediaWiki.php(288): MediaWiki->performAction(ImagePage, Title)
  #11 /srv/mediawiki/php-1.28.0-wmf.1/includes/MediaWiki.php(745): MediaWiki->performRequest()
  #12 /srv/mediawiki/php-1.28.0-wmf.1/includes/MediaWiki.php(519): MediaWiki->main()
  #13 /srv/mediawiki/php-1.28.0-wmf.1/index.php(43): MediaWiki->run()
  #14 /srv/mediawiki/w/index.php(3): include(string)
  #15 {main}
Caused by: [Exception DBUnexpectedError] (/srv/mediawiki/php-1.28.0-wmf.1/includes/db/Database.php:2588) Got explicit BEGIN from Wikibase\Client\Usage\Sql\EntityUsageTable::removeUsages while atomic section(s) FileDeleteForm::doDelete are open.
  #0 /srv/mediawiki/php-1.28.0-wmf.1/extensions/Wikidata/extensions/Wikibase/client/includes/Usage/Sql/EntityUsageTable.php(251): DatabaseBase->begin(string)
  #1 /srv/mediawiki/php-1.28.0-wmf.1/extensions/Wikidata/extensions/Wikibase/client/includes/Usage/Sql/EntityUsageTable.php(228): Wikibase\Client\Usage\Sql\EntityUsageTable->removeUsages(integer, array)
  #2 /srv/mediawiki/php-1.28.0-wmf.1/extensions/Wikidata/extensions/Wikibase/client/includes/Usage/Sql/SqlUsageTracker.php(219): Wikibase\Client\Usage\Sql\EntityUsageTable->pruneUsages(integer)
  #3 /srv/mediawiki/php-1.28.0-wmf.1/extensions/Wikidata/extensions/Wikibase/client/includes/Store/UsageUpdater.php(134): Wikibase\Client\Usage\Sql\SqlUsageTracker->pruneUsages(integer)
  #4 /srv/mediawiki/php-1.28.0-wmf.1/extensions/Wikidata/extensions/Wikibase/client/includes/Hooks/DataUpdateHookHandlers.php(177): Wikibase\Client\Store\UsageUpdater->pruneUsagesForPage(integer)
  #5 /srv/mediawiki/php-1.28.0-wmf.1/extensions/Wikidata/extensions/Wikibase/client/includes/Hooks/DataUpdateHookHandlers.php(88): Wikibase\Client\Hooks\DataUpdateHookHandlers->doArticleDeleteComplete(integer, integer)
  #6 /srv/mediawiki/php-1.28.0-wmf.1/includes/Hooks.php(195): Wikibase\Client\Hooks\DataUpdateHookHandlers::onArticleDeleteComplete(WikiFilePage, User, string, integer, WikitextContent, ManualLogEntry)
  #7 /srv/mediawiki/php-1.28.0-wmf.1/includes/page/WikiPage.php(2925): Hooks::run(string, array)
  #8 /srv/mediawiki/php-1.28.0-wmf.1/includes/FileDeleteForm.php(196): WikiPage->doDeleteArticleReal(string, boolean, integer, boolean, string, User)
  #9 /srv/mediawiki/php-1.28.0-wmf.1/includes/FileDeleteForm.php(120): FileDeleteForm::doDelete(Title, LocalFile, string, string, boolean, User)
  #10 /srv/mediawiki/php-1.28.0-wmf.1/includes/page/ImagePage.php(999): FileDeleteForm->execute()
  #11 /srv/mediawiki/php-1.28.0-wmf.1/includes/actions/DeleteAction.php(54): ImagePage->delete()
  #12 /srv/mediawiki/php-1.28.0-wmf.1/includes/MediaWiki.php(503): DeleteAction->show()
  #13 /srv/mediawiki/php-1.28.0-wmf.1/includes/MediaWiki.php(288): MediaWiki->performAction(ImagePage, Title)
  #14 /srv/mediawiki/php-1.28.0-wmf.1/includes/MediaWiki.php(745): MediaWiki->performRequest()
  #15 /srv/mediawiki/php-1.28.0-wmf.1/includes/MediaWiki.php(519): MediaWiki->main()
  #16 /srv/mediawiki/php-1.28.0-wmf.1/index.php(43): MediaWiki->run()
  #17 /srv/mediawiki/w/index.php(3): include(string)
  #18 {main}
Joe removed a project: SRE.May 18 2016, 7:28 AM
Lydia_Pintscher renamed this task from File deletion problem on commons.wikimedia.org to [Bug] File deletion problem on commons.wikimedia.org.May 19 2016, 12:08 PM
Lydia_Pintscher triaged this task as High priority.
Lydia_Pintscher moved this task from incoming to ready to go on the Wikidata board.
Lydia_Pintscher merged a task: T135577: Page with 'File:' prefix created in main namespace.May 19 2016, 2:06 PM
Lydia_Pintscher added subscribers: McZusatz, Cromium.
hoo added a comment.May 19 2016, 9:04 PM

I probably caused this with b27c48569bf9e8fbd8754b451821d2a4e2e70910, investigating on how to continue here.

hoo added a subscriber: aaron.EditedMay 19 2016, 9:08 PM
In T135485#2310621, @hoo wrote:

I probably caused this with b27c48569bf9e8fbd8754b451821d2a4e2e70910, investigating on how to continue here.

We have a few possible ways to solve this here: We could use DatabaseBase::onTransactionIdle for deleting the entity usage rows in question or just revert b27c48569bf9e8fbd8754b451821d2a4e2e70910, not sure what's more desirable.

Using onTransactionIdle would shorten the transaction started from FileDeleteForm::doDelete.

Alternatively we could create a dedicated job type for this, or do the deletions via a DataUpdate injected via the WikiPageDeletionUpdates hook.

Maybe @daniel or @aaron have an opinion?

aaron added a comment.May 20 2016, 3:09 AM

If the # of rows it might delete has no sane upper bound, then it should be a job. If it's just 100s at most, then it could use a DeferredUpdate class IMO.

Raymond subscribed.May 20 2016, 7:05 PM

Same issue with https://commons.wikimedia.org/wiki/File:Bundesarchiv_Bild_183-1985-0717-023,_LPG_Simmersdorf,_Ernte,_Verlustpr%C3%BCfung.jpg :-(

Wdwd added a comment.May 20 2016, 10:04 PM

some more files with the same issue: (file duplicates)

McZusatz added a comment.May 21 2016, 5:20 AM

Even more files: https://commons.wikimedia.org/w/index.php?title=Special:Contributions&offset=20150128&contribs=user&target=YaCBot&newOnly=1

Nemo_bis updated the task description. (Show Details)May 22 2016, 5:36 PM
matmarex mentioned this in T132921: Unable to delete file pages on commons: MWException/LocalFileLockError: "Could not acquire lock".May 22 2016, 9:32 PM
matmarex subscribed.

This sounds like it makes it impossible to delete any file that is referenced from a Wikidata entity? If so, I would consider it UBN priority.

Riley_Huntley subscribed.May 22 2016, 9:40 PM
aaron raised the priority of this task from High to Unbreak Now!.May 22 2016, 9:53 PM
Restricted Application added subscribers: Luke081515, TerraCodes, Urbanecm. · View Herald TranscriptMay 22 2016, 9:53 PM
hoo claimed this task.May 22 2016, 9:55 PM

I'll look into this in a bit, didn't realize this was such a widespread problem.

gerritbot subscribed.May 22 2016, 11:08 PM

Change 290148 had a related patch set uploaded (by Hoo man):
Use DeferredUpdates in DataUpdateHookHandlers for deletions

https://gerrit.wikimedia.org/r/290148

gerritbot added a project: Patch-For-Review.May 22 2016, 11:08 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2016-05-10.May 23 2016, 10:03 AM
Tobi_WMDE_SW moved this task from Proposed to Review on the Wikidata-Sprint-2016-05-10 board.May 23 2016, 1:15 PM
gerritbot added a comment.May 23 2016, 1:41 PM

Change 290216 had a related patch set uploaded (by Aude):
Use DeferredUpdates in DataUpdateHookHandlers for deletions

https://gerrit.wikimedia.org/r/290216

gerritbot added a comment.May 23 2016, 2:38 PM

Change 290148 merged by jenkins-bot:
Use DeferredUpdates in DataUpdateHookHandlers for deletions

https://gerrit.wikimedia.org/r/290148

gerritbot added a comment.May 23 2016, 2:59 PM

Change 290216 merged by jenkins-bot:
Use DeferredUpdates in DataUpdateHookHandlers for deletions

https://gerrit.wikimedia.org/r/290216

aude closed this task as Resolved.May 23 2016, 4:23 PM
aude removed a project: Patch-For-Review.
• demon moved this task from Untriaged to Resolved on the Wikimedia-production-error board.Jul 20 2016, 1:47 AM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL