Midterm evaluations for GSoC are on. All students and mentors must submit their evaluation on http://summerofcode.withgoogle.com before 27th June 2016 19:00 UTC. Please note that only one mentor needs to evaluate each student, not both.
If you have any concerns regarding your project/student which you do not wish to discuss on Phabricator, feel free to reach out to me or @01tonythomas directly.
Please complete the following in order to evaluate your student:
- Mid-term goals as outlined in the project timeline are complete
- MVP is completed and hosted on Labs/elsewhere
- Weekly reports are up-to-date and complete ( T133667 )
- The student is in regular touch with mentors
- Meeting 3 - 27th May | T136542
- Meeting 4 - 3rd June | T136892
- Meeting 5 - 10th June | T137462
- Meeting 6 - 15th June | T137836
- Meeting 7 - 17th June | T138056
- Meeting 8 - 20th June | T138164
- Meeting 9 - 24th June | T138531
Due to difficulties early on regarding design, we agreed to focus on getting solid prototypes for the MVP, removing the expected nice integration of the Thanks functionality into the Revision and Page classes.
I am generally quite pleased with the improvements over the last three weeks, as the code in gerrit patches is working, quality is going up, and your last blog post ( especially the part about reading code), indicates that you're on the right path to understanding Pywikibot, open source and most importantly yourself.
However the deadline is fast approaching, and the reduced MVP hasnt arrived. The patches are in good shape, but have quite a bit more work required to be polished enough to be merged. Some simple things like setting write = True havent been done, despite being explained in tests/README.rst. That alone is an automatic "must not be merged" problem. It shouldnt need to be a review comment, and shouldnt need to be repeated. There are plenty of examples, including in flow_tests which was your guide.
Given more time, I am confident that you could complete the MVP, and probably even complete the project. But the deadline has arrived.
I strongly recommend that you stay involved in open source to augment your formal education, practise getting code merged, and participate in Google Summer of Code again next year, as I am sure you will be better prepared for it.