Page MenuHomePhabricator
Create Task
Maniphest T139520

Change 'messages' to 'notices' everywhere (where 'messages' referred to a section name)
Closed, ResolvedPublic
Actions

Assigned To
Mooeypoo
Authored By
Etonkovidova
Jul 6 2016, 7:59 PM
Tags
Referenced Files
F4294997: Screen Shot 2016-07-21 at 11.16.23 AM.png
Jul 21 2016, 6:35 PM
F4294995: mwiki_notices.mov
Jul 21 2016, 6:35 PM
F4294996: Screen Shot 2016-07-21 at 11.29.21 AM.png
Jul 21 2016, 6:35 PM
F4294037: Screenshot - 21072016 - 11:35:29.png
Jul 21 2016, 9:39 AM
F4286392: Screen Shot 2016-07-18 at 1.24.20 PM.png
Jul 18 2016, 8:27 PM
F4279010: Screen Shot 2016-07-15 at 5.29.14 PM.png
Jul 16 2016, 12:47 AM
F4279019: Screen Shot 2016-07-15 at 5.37.53 PM.png
Jul 16 2016, 12:47 AM
F4245683: Screen Shot 2016-07-06 at 12.54.41 PM.png
Jul 6 2016, 7:59 PM
Subscribers
Aklapper
Etonkovidova
gerritbot
• Mattflaschen-WMF
Pginer-WMF
Trizek-WMF
Zppix

Description

As mentioned in T115845: Notification panel: Clearer use of notification badges the notification badge (mw-echo-notifications-badge) should display "Your notices" in the tooltip not "Your messages".

Screen Shot 2016-07-06 at 12.54.41 PM.png (141×408 px, 16 KB)

Details

SubjectRepoBranchLines +/-
[wip] Load notification badges with the new 'notice' instead of 'message'mediawiki/extensions/Echomaster+21 -23
Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' textmediawiki/extensions/Echowmf/1.28.0-wmf.9+5 -1
Change 'messages' to 'notices' throughout the interfacemediawiki/extensions/Echowmf/1.28.0-wmf.9+41 -23
Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' textmediawiki/extensions/Echomaster+5 -1
Change 'messages' to 'notices' throughout the interfacemediawiki/extensions/Echomaster+41 -23
Customize query in gerrit

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Jul 6 2016, 7:59 PM
Restricted Application added subscribers: Zppix, Aklapper. · View Herald TranscriptJul 6 2016, 7:59 PM
Etonkovidova mentioned this in T123018: Revise Sorting of Notifications on the Fly-Out Menus.Jul 6 2016, 10:56 PM
Liuxinyu970226 subscribed.Jul 6 2016, 11:19 PM
• Mattflaschen-WMF added subscribers: Pginer-WMF, • Mattflaschen-WMF.Jul 7 2016, 9:42 PM

We also need icons for this.

• Mattflaschen-WMF assigned this task to Mooeypoo.Jul 7 2016, 9:44 PM
• Mattflaschen-WMF added a parent task: T123018: Revise Sorting of Notifications on the Fly-Out Menus.Jul 7 2016, 9:49 PM
gerritbot subscribed.Jul 7 2016, 10:36 PM

Change 297913 had a related patch set uploaded (by Mooeypoo):
Change 'messages' to 'notices' throughout the interface

https://gerrit.wikimedia.org/r/297913

gerritbot added a project: Patch-For-Review.Jul 7 2016, 10:36 PM
Mooeypoo added a comment.Jul 7 2016, 10:37 PM

This involves more than just the tooltip - the change is for the entire interface, changing 'message' to 'notice' in context of the popup.

At some point, we should do the same with the back-end and supporting code, but in order to do that, we will need to also change the API section names as well. See T139682: Change 'messages' to 'notices' internally (method names and such)

• Mattflaschen-WMF renamed this task from Change tooltip 'Your messages' to 'Your notices' to Change 'messages' to 'notices' everywhere (where 'messages' referred to a section name).Jul 7 2016, 11:02 PM
gerritbot added a comment.Jul 7 2016, 11:06 PM

Change 297913 merged by jenkins-bot:
Change 'messages' to 'notices' throughout the interface

https://gerrit.wikimedia.org/r/297913

gerritbot added a comment.Jul 7 2016, 11:08 PM

Change 297919 had a related patch set uploaded (by Dereckson):
Change 'messages' to 'notices' throughout the interface

https://gerrit.wikimedia.org/r/297919

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-12_(1.28.0-wmf.10)).Jul 8 2016, 12:00 AM
gerritbot added a comment.Jul 8 2016, 12:08 AM

Change 297932 had a related patch set uploaded (by Mooeypoo):
Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text

https://gerrit.wikimedia.org/r/297932

gerritbot added a comment.Jul 8 2016, 12:24 AM

Change 297932 merged by jenkins-bot:
Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text

https://gerrit.wikimedia.org/r/297932

gerritbot added a comment.Jul 8 2016, 12:25 AM

Change 297933 had a related patch set uploaded (by Mooeypoo):
Load notification badges with the new 'notice' instead of 'message'

https://gerrit.wikimedia.org/r/297933

gerritbot added a comment.Jul 8 2016, 12:29 AM

Change 297934 had a related patch set uploaded (by Mattflaschen):
Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text

https://gerrit.wikimedia.org/r/297934

gerritbot added a comment.Jul 8 2016, 12:41 AM

Change 297919 merged by jenkins-bot:
Change 'messages' to 'notices' throughout the interface

https://gerrit.wikimedia.org/r/297919

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-07-05_(1.28.0-wmf.9)).Jul 8 2016, 1:00 AM
gerritbot added a comment.Jul 8 2016, 1:13 AM

Change 297934 merged by jenkins-bot:
Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text

https://gerrit.wikimedia.org/r/297934

• Mattflaschen-WMF added a comment.Jul 8 2016, 5:16 PM
In T139520#2439685, @Mattflaschen-WMF wrote:

We also need icons for this.

At T135114: Review "tray" icon

Jdforrester-WMF added a subtask: T135114: Review "tray" icon.Jul 12 2016, 8:16 PM
Etonkovidova moved this task from Untriaged to QA Review on the Collab-Team-Q1-July-Sep-2016 board.Jul 16 2016, 12:22 AM
Etonkovidova added a comment.Jul 16 2016, 12:47 AM

Checked the labeling for 'Notice' in 1.28.0-wmf.10.

  • the tooltip refers to 'your notices' correctly

Screen Shot 2016-07-15 at 5.29.14 PM.png (93×463 px, 41 KB)

  • the flyout panel displays Notices:

Screen Shot 2016-07-15 at 5.37.53 PM.png (276×657 px, 51 KB)

In the above screenshot "You have new messages" warning, in fact, refers to notifications that currently classified as Alerts. Seems a bit odd to have the three terms close in meaning - notifications, notices, messages - displayed in close proximity.

Trizek-WMF added a subtask: T140645: Review if "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki.Jul 18 2016, 3:08 PM
Etonkovidova added a comment.Jul 18 2016, 8:27 PM

The following instances of 'message' have been changed to 'notice'

  • the tooltip (see the screenshot in the above comment)
  • 'notice' is used instead of 'message' in the flyout

Screen Shot 2016-07-18 at 1.24.20 PM.png (344×565 px, 46 KB)

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-Q1-July-Sep-2016 board.Jul 18 2016, 8:28 PM
Trizek-WMF changed the status of subtask T135114: Review "tray" icon from Open to Stalled.Jul 20 2016, 2:49 PM
Trizek-WMF created subtask T140900: Change bubble speech icon to tray icon.Jul 20 2016, 2:52 PM
• jmatazzoni closed this task as Resolved.Jul 20 2016, 8:56 PM
Liuxinyu970226 unsubscribed.Jul 21 2016, 12:44 AM
Trizek-WMF reopened this task as Open.Jul 21 2016, 9:39 AM
Trizek-WMF subscribed.

Apparently, the tooltip has not been updated (ping @Etonkovidova to check):

Screenshot - 21072016 - 11:35:29.png (205×866 px, 36 KB)
mw.org screenshot

title="(tooltip-pt-notifications-message)(word-separator)(brackets: (accesskey-pt-notifications-message))(word-separator)(brackets)"

the right message is tooltip-pt-notifications-notice, translations are available and are currently checked on T140645: Review if "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki.

• jmatazzoni moved this task from Product Review to QA Review on the Collab-Team-Q1-July-Sep-2016 board.Jul 21 2016, 5:44 PM
Etonkovidova added a comment.EditedJul 21 2016, 6:22 PM

Checked enwiki and mediawiki (and was checking testwiki and enwiki after deployment) - the tooltip "Your notices" is in place with 1.28.0-wmf.11 (a449907).

mwiki_notices.mov2 MBDownload

Screen Shot 2016-07-21 at 11.29.21 AM.png (153×828 px, 80 KB)

Screen Shot 2016-07-21 at 11.16.23 AM.png (153×1 px, 164 KB)

Etonkovidova moved this task from QA Review to Product Review on the Collab-Team-Q1-July-Sep-2016 board.Jul 21 2016, 6:36 PM
• Mattflaschen-WMF added a comment.Jul 21 2016, 6:38 PM

Related patch (in process of merging): https://gerrit.wikimedia.org/r/#/c/300322/

The UI was correct before, but the message key was a bit confusing.

• jmatazzoni closed this task as Resolved.Jul 22 2016, 5:30 PM
• jmatazzoni closed subtask T140900: Change bubble speech icon to tray icon as Resolved.Aug 9 2016, 6:17 PM
Trizek-WMF closed subtask T140645: Review if "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki as Resolved.Aug 10 2016, 12:17 PM
Jdforrester-WMF closed subtask T135114: Review "tray" icon as Resolved.Jul 18 2017, 11:54 PM
gerritbot added a comment.Mar 26 2018, 3:32 PM

Change 297933 abandoned by Mooeypoo:
[wip] Load notification badges with the new 'notice' instead of 'message'

https://gerrit.wikimedia.org/r/297933

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL