Page MenuHomePhabricator

Change 'messages' to 'notices' everywhere (where 'messages' referred to a section name)
Closed, ResolvedPublic

Description

As mentioned in T115845: Notification panel: Clearer use of notification badges the notification badge (mw-echo-notifications-badge) should display "Your notices" in the tooltip not "Your messages".

Screen Shot 2016-07-06 at 12.54.41 PM.png (141×408 px, 16 KB)

Event Timeline

Change 297913 had a related patch set uploaded (by Mooeypoo):
Change 'messages' to 'notices' throughout the interface

https://gerrit.wikimedia.org/r/297913

This involves more than just the tooltip - the change is for the entire interface, changing 'message' to 'notice' in context of the popup.

At some point, we should do the same with the back-end and supporting code, but in order to do that, we will need to also change the API section names as well. See T139682: Change 'messages' to 'notices' internally (method names and such)

Mattflaschen-WMF renamed this task from Change tooltip 'Your messages' to 'Your notices' to Change 'messages' to 'notices' everywhere (where 'messages' referred to a section name).Jul 7 2016, 11:02 PM

Change 297913 merged by jenkins-bot:
Change 'messages' to 'notices' throughout the interface

https://gerrit.wikimedia.org/r/297913

Change 297919 had a related patch set uploaded (by Dereckson):
Change 'messages' to 'notices' throughout the interface

https://gerrit.wikimedia.org/r/297919

Change 297932 had a related patch set uploaded (by Mooeypoo):
Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text

https://gerrit.wikimedia.org/r/297932

Change 297932 merged by jenkins-bot:
Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text

https://gerrit.wikimedia.org/r/297932

Change 297933 had a related patch set uploaded (by Mooeypoo):
Load notification badges with the new 'notice' instead of 'message'

https://gerrit.wikimedia.org/r/297933

Change 297934 had a related patch set uploaded (by Mattflaschen):
Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text

https://gerrit.wikimedia.org/r/297934

Change 297919 merged by jenkins-bot:
Change 'messages' to 'notices' throughout the interface

https://gerrit.wikimedia.org/r/297919

Change 297934 merged by jenkins-bot:
Followup Ib7f4dc4ea: Bring back message tooltip with 'notice' text

https://gerrit.wikimedia.org/r/297934

Checked the labeling for 'Notice' in 1.28.0-wmf.10.

  • the tooltip refers to 'your notices' correctly

Screen Shot 2016-07-15 at 5.29.14 PM.png (93×463 px, 41 KB)

  • the flyout panel displays Notices:

Screen Shot 2016-07-15 at 5.37.53 PM.png (276×657 px, 51 KB)

In the above screenshot "You have new messages" warning, in fact, refers to notifications that currently classified as Alerts. Seems a bit odd to have the three terms close in meaning - notifications, notices, messages - displayed in close proximity.

The following instances of 'message' have been changed to 'notice'

  • the tooltip (see the screenshot in the above comment)
  • 'notice' is used instead of 'message' in the flyout

Screen Shot 2016-07-18 at 1.24.20 PM.png (344×565 px, 46 KB)

Trizek-WMF added a subscriber: Trizek-WMF.

Apparently, the tooltip has not been updated (ping @Etonkovidova to check):

Screenshot - 21072016 - 11:35:29.png (205×866 px, 36 KB)
mw.org screenshot

title="(tooltip-pt-notifications-message)(word-separator)(brackets: (accesskey-pt-notifications-message))(word-separator)(brackets)"

the right message is tooltip-pt-notifications-notice, translations are available and are currently checked on T140645: Review if "notices" are not translated by "messages" for Notifications fly-outs on TranslateWiki.

Checked enwiki and mediawiki (and was checking testwiki and enwiki after deployment) - the tooltip "Your notices" is in place with 1.28.0-wmf.11 (a449907).

Screen Shot 2016-07-21 at 11.29.21 AM.png (153×828 px, 80 KB)

Screen Shot 2016-07-21 at 11.16.23 AM.png (153×1 px, 164 KB)

Related patch (in process of merging): https://gerrit.wikimedia.org/r/#/c/300322/

The UI was correct before, but the message key was a bit confusing.

Change 297933 abandoned by Mooeypoo:
[wip] Load notification badges with the new 'notice' instead of 'message'

https://gerrit.wikimedia.org/r/297933