Page MenuHomePhabricator
Create Task
Maniphest T141571

JS error on page load
Closed, ResolvedPublic
Actions

Description

Visit http://en.m.wikipedia.beta.wmflabs.org/wiki/Barack_Obama?mobileaction=stable

Uncaught TypeError: Cannot read property 'length' of null

initButton @ init.js?054e7:170(anonymous function) @ init.js?054e7:271fire @ load.php?

I'd say this is UBN since it causes a JavaScript error for all users in stable which can break other functionality (for example watch star doesn't work for me).

Should fix before gets on the train!

Details

SubjectRepoBranchLines +/-
legacyBtn can sometimes be nullmediawiki/extensions/MobileFrontendmaster+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Jul 28 2016, 9:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 28 2016, 9:18 PM
gerritbot subscribed.Jul 28 2016, 9:19 PM

Change 301705 had a related patch set uploaded (by Jdlrobson):
legacyBtn can sometimes be null

https://gerrit.wikimedia.org/r/301705

Jdlrobson claimed this task.Jul 28 2016, 9:19 PM
Jdlrobson moved this task from Needs Analysis to Code Review on the Reading-Web-Sprint-77-Segmentation-fault board.
Jdlrobson added a project: Unplanned-Sprint-Work.
Jdlrobson mentioned this in T140260: Prepare mobile language button for deployment.Jul 28 2016, 9:36 PM
Jdlrobson updated the task description. (Show Details)Jul 28 2016, 9:50 PM
phuedx added a parent task: T139794: Show users that language button has moved.Jul 29 2016, 7:00 AM
phuedx triaged this task as Unbreak Now! priority.Jul 29 2016, 8:16 AM
Restricted Application added subscribers: Luke081515, TerraCodes. · View Herald TranscriptJul 29 2016, 8:16 AM
gerritbot added a comment.Jul 29 2016, 8:18 AM

Change 301705 merged by jenkins-bot:
legacyBtn can sometimes be null

https://gerrit.wikimedia.org/r/301705

phuedx reassigned this task from Jdlrobson to dr0ptp4kt.Jul 29 2016, 8:35 AM
phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-77-Segmentation-fault board.
• Jhernandez closed this task as Resolved.Jul 29 2016, 8:48 AM
• Jhernandez subscribed.

Verified in beta cluster.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-08-02_(1.28.0-wmf.13)).Jul 29 2016, 9:00 AM
Jdlrobson mentioned this in T140490: Search magnifying glass and placeholder text mashed together in Opera Mini extreme mode (all resolutions).Jul 29 2016, 5:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits