Page MenuHomePhabricator

When a page move is triggered by RenameUserJob, page should be moved anyways even if it is a Flow board
Open, HighPublic

Description

Scenario

A global renamer or steward renames an user. That user has one or more talk pages set as flow boards.

Problem

User talk pages of those users aren't moved when the rename is performed and has to be done manually by a steward.

Latest case

The global rename of User:Maestro 121 to User:TheWhitlocker24 at zhwiki. I had to assign myself flow-bot rights to manually move the flow board talk page of the user since it is not done when the user is being renamed.

Proposed solutions

  1. Make that the extension identifies when a page move is being part of a global rename job and let the page be moved anyways, or
  2. Granularize Flow permissions, creating a new flow-board-move permission to let users move Flow boards.

Notwithstanding any other proposed or better solution that you can find of course.

Thank you.

Questions:

  1. Is this still happening if the global rename is done by a steward?
  2. Does it happen anywhere besides zhwiki?

Event Timeline

MarcoAurelio triaged this task as Normal priority.Nov 12 2016, 10:33 AM
Kegns added a subscriber: Kegns.Nov 12 2016, 11:21 AM
Trijnstel raised the priority of this task from Normal to High.Nov 12 2016, 7:57 PM

Definitely. It would be nice if this could be fixed soon. Thanks.

Stryn added a subscriber: Stryn.Nov 12 2016, 8:34 PM

According to T126229: flow-create-board for bureaucrats?, global renamers? stewards (done) (and "Global rename script" ?), no rights should be necessary. It is possible there is a local issue on zhwiki (e.g. we had T127693: Flow board move requiring allowCreation fails on zh.wp in the past, not sure if related).

But a simple solution is to just do T126229: flow-create-board for bureaucrats?, global renamers? stewards (done) (and "Global rename script" ?) after all, and see if that solves it.

Note, the right is flow-create-board, flow-bot is one group that has it.

(cross-posting from T126229)

New issue with this today at zh.wiki again. Now that we have 'flow-create-board' rights on our global group I could move the page (but I had to delete the destination page first in order to move the board as the system complained that the content model was not allowed in the target page).

My idea is that globalrename does this, either with our accounts or Global rename script when our accounts do not exist on the wiki. The other option might be to have Flow talk page manager do this for each user rename. Does that sound good as well? Regards.

Mattflaschen-WMF added a comment.EditedMar 7 2017, 11:07 PM

Never mind, that global rename was initially done by a global renamer, not a steward. So options include:

  1. Fix the underlying issue. It's already supposed to bypass permissions checks.
  2. Granularize Flow permissions, creating a new flow-board-move permission to let users move Flow boards, and grant that to stewards and global renamers.
  3. Grant flow-create-board to global renamers and "Global rename script", and see if that solves the issue.

Still need to figure out if this is a local zhwiki issue (e.g. AbuseFilter).

Just FYI Global rename script is not a real account, it's a maintenance script or system account that operates under that name. I don't think anything we do to it (adding rights, etc.) is going to affect it. I guess it's simpler to do #1 and see why permissions checks ain't bypassed. Thanks!

This also happens on frwiki. I just renamed an orphan flow board left after a user rename (https://fr.wikipedia.org/w/index.php?title=Sp%C3%A9cial:Journal&offset=20180416173900&type=move&user=Orlodrim&limit=1). The user was renamed by Céréales Killer, who is a sysop on frwiki.

Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 2 2018, 11:26 PM
SBisson changed the subtype of this task from "Task" to "Bug Report".Oct 16 2018, 1:10 PM
SBisson changed the subtype of this task from "Bug Report" to "Task".Oct 16 2018, 6:41 PM
SBisson added a subscriber: SBisson.

Because this need is rare and it is easy to work around, we will not prioritize at this time, but will keep an eye on it.

1997kB added a subscriber: 1997kB.Jan 13 2019, 6:03 PM
1997kB added a comment.EditedMar 24 2019, 1:29 PM

Don't know how frequent this needs to happen for fix, but having flow on wikidata, mediawiki and zhwiki (those I faced many times) it would be helpful if this can be looked into. :)