Page MenuHomePhabricator

DispatchingServiceFactory must provide a (Dispatching)TermSearchInteractor
Closed, ResolvedPublic

Description

Both WikibaseClient::newTermSearchInteractor and WikibaseRepo::newTermSearchInteractor should return a DispatchingTermSearchInteractor. They should get that instance from DispatchingServiceFactory.

Note that newTermSearchInteractor is currently guaranteed to always return a fresh instance, which does not fit with how ServiceContainer handles service instances. One solution would be to make createService() protected in ServiceContainer, and call that in DispatchingTermSearchInteractor::newTermSearchInteractor. But perhaps it's not actually required to always have a fresh interactor instance. Maybe we can change the method to lazy getter semantics, and rename it to getTermSearchInteractor. A third option is to introduce a factory.

Related Objects

StatusSubtypeAssignedTask
OpenNone
OpenNone
DuplicateNone
OpenFeatureNone
OpenFeatureNone
DuplicateNone
ResolvedNone
ResolvedNone
ResolvedNone
OpenNone
OpenNone
StalledNone
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedLydia_Pintscher
ResolvedWMDE-leszek
Resolved Aleksey_WMDE
ResolvedWMDE-leszek

Event Timeline

Change 328513 had a related patch set uploaded (by WMDE-leszek):
Make DispatchingServiceFactory provided TermSearchInteractor

https://gerrit.wikimedia.org/r/328513

Change 328513 merged by jenkins-bot:
Make EntityDataRetrievalServiceFactory provide TermSearchInteractor

https://gerrit.wikimedia.org/r/328513