DispatchingServiceFactory must provide a (Dispatching)TermSearchInteractor
Closed, ResolvedPublic

Description

Both WikibaseClient::newTermSearchInteractor and WikibaseRepo::newTermSearchInteractor should return a DispatchingTermSearchInteractor. They should get that instance from DispatchingServiceFactory.

Note that newTermSearchInteractor is currently guaranteed to always return a fresh instance, which does not fit with how ServiceContainer handles service instances. One solution would be to make createService() protected in ServiceContainer, and call that in DispatchingTermSearchInteractor::newTermSearchInteractor. But perhaps it's not actually required to always have a fresh interactor instance. Maybe we can change the method to lazy getter semantics, and rename it to getTermSearchInteractor. A third option is to introduce a factory.

daniel created this task.Dec 20 2016, 9:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2016, 9:09 PM

Change 328513 had a related patch set uploaded (by WMDE-leszek):
Make DispatchingServiceFactory provided TermSearchInteractor

https://gerrit.wikimedia.org/r/328513

WMDE-leszek moved this task from Proposed to Doing on the Wikidata-Former-Sprint-Board board.
WMDE-leszek moved this task from Done to Review on the Wikidata-Former-Sprint-Board board.

Change 328513 merged by jenkins-bot:
Make EntityDataRetrievalServiceFactory provide TermSearchInteractor

https://gerrit.wikimedia.org/r/328513

WMDE-leszek closed this task as Resolved.Mar 15 2017, 8:23 AM
WMDE-leszek moved this task from Monitoring to Done on the Wikidata-Former-Sprint-Board board.