Page MenuHomePhabricator
Create Task
Maniphest T156310

Fatal error: Call to undefined method Revision::getText() in extensions/FlaggedRevs/backend/FlaggedRevision.php on line 480
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

getting a lot of these in the logs since wmf.9

From T156356:

In T156356#2971992, @TTO wrote:

Pages with pending changes (all these: https://de.wiktionary.org/wiki/Spezial:Seiten_mit_ungesichteten_Versionen) can't be edited or read - a totally blank page is returned.

Workaround is probably to review or reject the revisions before editing.

Repro case:

production https://de.wiktionary.org/w/index.php?title=Sonne&stable=1

beta https://en.wikipedia.beta.wmflabs.org/w/index.php?title=PC1&action=edit (as anonymous user)

Details

SubjectRepoBranchLines +/-
group1 wikis back to 1.29.0-wmf.9operations/mediawiki-configmaster+597 -597
Fix fatal in prod caused by deprecated function removalmediawiki/extensions/FlaggedRevswmf/1.29.0-wmf.9+2 -1
Fix fatal in prod caused by deprecated function removalmediawiki/extensions/FlaggedRevsmaster+2 -1
Revert "group1 wikis to 1.29.0-wmf.9"operations/mediawiki-configmaster+597 -597
Enable deprecation logging in prodoperations/mediawiki-configmaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• mmodell created this task.Jan 25 2017, 9:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2017, 9:37 PM
• mmodell added a parent task: T154683: MW-1.29.0-wmf.9 deployment blockers.Jan 25 2017, 9:37 PM
• mmodell triaged this task as High priority.Jan 25 2017, 9:40 PM
• mmodell added a comment.Jan 25 2017, 9:44 PM
{
    "fatal_exception": {
        "class": "ErrorException",
        "message": "PHP Fatal Error: Call to undefined method Revision::getText()",
        "code": 16777217,
        "file": "/srv/mediawiki/php-1.29.0-wmf.9/extensions/FlaggedRevs/backend/FlaggedRevision.php",
        "line": 480,
        "trace": [{
            "file": "/srv/mediawiki/php-1.29.0-wmf.9/extensions/FlaggedRevs/backend/FlaggedRevision.php",
            "line": 480
        }, {
            "file": "/srv/mediawiki/php-1.29.0-wmf.9/extensions/FlaggedRevs/frontend/FlaggablePageView.php",
            "line": 1028,
            "function": "getRevText",
            "class": "FlaggedRevision",
            "type": "->",
            "args": []
        }, {
            "file": "/srv/mediawiki/php-1.29.0-wmf.9/extensions/FlaggedRevs/frontend/FlaggedRevsUI.hooks.php",
            "line": 237,
            "function": "addToEditView",
            "class": "FlaggablePageView",
            "type": "->",
            "args": ["EditPage"]
        }, {
            "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/Hooks.php",
            "line": 186,
            "function": "addToEditView",
            "class": "FlaggedRevsUIHooks",
            "type": "::",
            "args": ["EditPage", "OutputPage"]
        }, {
            "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/EditPage.php",
            "line": 2602,
            "function": "run",
            "class": "Hooks",
            "type": "::",
            "args": ["string", "array"]
        }, {
            "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/EditPage.php",
            "line": 642,
            "function": "showEditForm",
            "class": "EditPage",
            "type": "->",
            "args": []
        }, {
            "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/actions/EditAction.php",
            "line": 59,
            "function": "edit",
            "class": "EditPage",
            "type": "->",
            "args": []
        }, {
            "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/MediaWiki.php",
            "line": 495,
            "function": "show",
            "class": "EditAction",
            "type": "->",
            "args": []
        }, {
            "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/MediaWiki.php",
            "line": 289,
            "function": "performAction",
            "class": "MediaWiki",
            "type": "->",
            "args": ["Article", "Title"]
        }, {
            "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/MediaWiki.php",
            "line": 858,
            "function": "performRequest",
            "class": "MediaWiki",
            "type": "->",
            "args": []
        }, {
            "file": "/srv/mediawiki/php-1.29.0-wmf.9/includes/MediaWiki.php",
            "line": 519,
            "function": "main",
            "class": "MediaWiki",
            "type": "->",
            "args": []
        }, {
            "file": "/srv/mediawiki/php-1.29.0-wmf.9/index.php",
            "line": 43,
            "function": "run",
            "class": "MediaWiki",
            "type": "->",
            "args": []
        }, {
            "file": "/srv/mediawiki/w/index.php",
            "line": 3,
            "function": "include",
            "args": ["string"]
        }]
    },
    "exception_id": "5581f8a7",
    "caught_by": "mwe_handler"
}
• mmodell added a comment.Jan 25 2017, 9:54 PM

None of the recent changes to the FlaggedRevs extension seem relevant to this error. May be a symptom of something else?

gerritbot subscribed.Jan 25 2017, 10:12 PM

Change 334206 had a related patch set uploaded (by EBernhardson):
Enable deprecation logging in prod

https://gerrit.wikimedia.org/r/334206

gerritbot added a project: Patch-For-Review.Jan 25 2017, 10:12 PM
Paladox subscribed.Jan 25 2017, 10:15 PM

Need to replace it with getContent

See https://github.com/wikimedia/mediawiki/commit/0958f53373671e212f01bf3987e405c6121a2d70

EBernhardson removed a project: Patch-For-Review.Jan 25 2017, 10:19 PM
gerritbot added a comment.Jan 26 2017, 12:08 AM

Change 334206 merged by jenkins-bot:
Enable deprecation logging in prod

https://gerrit.wikimedia.org/r/334206

gerritbot added a comment.Jan 26 2017, 12:40 AM

Change 334223 had a related patch set uploaded (by MaxSem):
Fix fatal in prod caused by deprecated function removal

https://gerrit.wikimedia.org/r/334223

gerritbot added a project: Patch-For-Review.Jan 26 2017, 12:40 AM
Schnark mentioned this in T156356: Pages with an &stable=1 in their URL could not be viewed or edited.Jan 26 2017, 10:35 AM
faidon subscribed.Jan 26 2017, 10:47 AM

getting a lot of these in the logs since wmf.9

If we were getting these a lot after the wmf.9 deploy, why didn't we roll it back?

gerritbot added a comment.Jan 26 2017, 10:57 AM

Change 334277 had a related patch set uploaded (by Hashar):
Revert "group1 wikis to 1.29.0-wmf.9"

https://gerrit.wikimedia.org/r/334277

gerritbot added a comment.Jan 26 2017, 11:02 AM

Change 334277 merged by jenkins-bot:
Revert "group1 wikis to 1.29.0-wmf.9"

https://gerrit.wikimedia.org/r/334277

Stashbot subscribed.Jan 26 2017, 11:12 AM

Mentioned in SAL (#wikimedia-operations) [2017-01-26T11:12:16Z] <hashar@tin> rebuilt wikiversions.php and synchronized wikiversions files: FlaggedRevs is broken in wmf.9 causing blank pages. T156356 T156310

hashar merged a task: T156356: Pages with an &stable=1 in their URL could not be viewed or edited.Jan 26 2017, 11:14 AM
hashar updated the task description. (Show Details)
hashar added subscribers: Formatierer, hashar, Schnark and 4 others.
hashar updated the task description. (Show Details)Jan 26 2017, 11:24 AM
hashar updated the task description. (Show Details)Jan 26 2017, 11:28 AM
gerritbot added a comment.Jan 26 2017, 11:30 AM

Change 334296 had a related patch set uploaded (by Hashar):
Fix fatal in prod caused by deprecated function removal

https://gerrit.wikimedia.org/r/334296

gerritbot added a comment.Jan 26 2017, 11:32 AM

Change 334223 merged by jenkins-bot:
Fix fatal in prod caused by deprecated function removal

https://gerrit.wikimedia.org/r/334223

hashar added a subscriber: MaxSem.Jan 26 2017, 11:38 AM

@MaxSem patch ( https://gerrit.wikimedia.org/r/334223 ) fix it on beta. Will push it to wmf.9 so we can confirm on group0 then I guess we can move group1 back to wmf.9.

gerritbot added a comment.Jan 26 2017, 11:43 AM

Change 334296 merged by jenkins-bot:
Fix fatal in prod caused by deprecated function removal

https://gerrit.wikimedia.org/r/334296

ReleaseTaggerBot added projects: MW-1.29-release (WMF-deploy-2017-01-24_(1.29.0-wmf.9)), MW-1.29-release (WMF-deploy-2017-01-31_(1.29.0-wmf.10)).Jan 26 2017, 12:00 PM
Stashbot added a comment.Jan 26 2017, 12:17 PM

Mentioned in SAL (#wikimedia-operations) [2017-01-26T12:17:04Z] <hashar@tin> Synchronized php-1.29.0-wmf.9/extensions/FlaggedRevs/backend/FlaggedRevision.php: Fix fatal in prod caused by deprecated function removal T156310 (duration: 00m 41s)

hashar added a comment.Jan 26 2017, 12:20 PM

Works on group0 per https://test.wikipedia.org/w/index.php?title=Testing_something&stable=1

gerritbot added a comment.Jan 26 2017, 12:23 PM

Change 334328 had a related patch set uploaded (by Hashar):
group1 wikis back to 1.29.0-wmf.9

https://gerrit.wikimedia.org/r/334328

gerritbot added a comment.Jan 26 2017, 12:50 PM

Change 334328 merged by jenkins-bot:
group1 wikis back to 1.29.0-wmf.9

https://gerrit.wikimedia.org/r/334328

Stashbot added a comment.Jan 26 2017, 1:05 PM

Mentioned in SAL (#wikimedia-operations) [2017-01-26T13:05:50Z] <hashar@tin> rebuilt wikiversions.php and synchronized wikiversions files: group1 back to 1.29.0-wmf.9 T156310

hashar closed this task as Resolved.Jan 26 2017, 1:06 PM
hashar claimed this task.

Should be good now and group1 wikis are back to 1.29.0-wmf.9

Aklapper added a comment.Jan 26 2017, 2:53 PM

For context: Triggered by https://gerrit.wikimedia.org/r/#/c/332933/. FR patch still waiting for review: https://gerrit.wikimedia.org/r/#/c/325459/.

hashar mentioned this in T156364: Warning: Empty regular expression in /srv/mediawiki/php-1.29.0-wmf.9/includes/parser/DateFormatter.php on line 200.Jan 27 2017, 4:58 PM
hashar mentioned this in T161198: Enhance deprecated logging to be context aware.Mar 23 2017, 9:51 AM
hashar created subtask T161198: Enhance deprecated logging to be context aware.
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:11 PM
Krinkle closed subtask T161198: Enhance deprecated logging to be context aware as Declined.Mar 24 2020, 9:19 PM
TerraCodes unsubscribed.Mar 24 2020, 9:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits