Page MenuHomePhabricator
Create Task
Maniphest T161151

Parsoid should resolve template paths before providing them to Linter
Closed, ResolvedPublic
Actions

Description

If a lint error comes from something like {{/Status}] we're recording the template as a literal /Status not <Pagename>/Status

Related Objects

Mentioned In
T136653: Parsoid doesn't recognize interwiki shortcuts in the href attribute
T163549: Only lint pages that have wikitext contentmodel
T162920: In multi-content/template-block scenarios, Linter displays "--" in the "Through a template"? column
T164006: Suggestion: API for fetching lint errors for a specific revision
T163091: Parsoid: Add API endpoint to get lint errors for arbitrary wikitext
T153107: Parsoid is generating [[Foo|Foo]] instead of [[Foo]] for some VE edits
T37247: content-holding <div> should only contain the page text
T164792: Add class mw-parser-output to Parsoid's output
T141226: Missing data-mw content in wikitext leads to html2wt exceptions
Mentioned Here
rGPARd07dfe1a79ca: Moving setting env properties closer to where they're used
T136653: Parsoid doesn't recognize interwiki shortcuts in the href attribute
T166068: German Wikipedia's main page shows significantly stale content
rGPARa182c227f09d: T141226: Fix logic when unpacking dom fragments
T37247: content-holding <div> should only contain the page text
T141226: Missing data-mw content in wikitext leads to html2wt exceptions
T153107: Parsoid is generating [[Foo|Foo]] instead of [[Foo]] for some VE edits
T162920: In multi-content/template-block scenarios, Linter displays "--" in the "Through a template"? column
T163091: Parsoid: Add API endpoint to get lint errors for arbitrary wikitext
T163549: Only lint pages that have wikitext contentmodel
T164006: Suggestion: API for fetching lint errors for a specific revision
T164792: Add class mw-parser-output to Parsoid's output

Event Timeline

Legoktm created this task.Mar 22 2017, 7:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 22 2017, 7:44 PM
ssastry added a project: Parsoid.Apr 18 2017, 2:04 PM
ssastry renamed this task from Linter doesn't handle non-absolutely named templates properly to Parsoid should resolve template paths before providing them to Linter.Apr 27 2017, 2:52 PM
ssastry triaged this task as Medium priority.
ssastry moved this task from Needs Triage to Next Up on the Parsoid board.
ssastry removed a project: MediaWiki-extensions-Linter.
ssastry updated the task description. (Show Details)
ssastry moved this task from Next Up to In Progress on the Parsoid board.May 10 2017, 7:59 PM
gerritbot subscribed.May 10 2017, 8:08 PM

Change 353168 had a related patch set uploaded (by Subramanya Sastry; owner: Subramanya Sastry):
[mediawiki/services/parsoid@master] T161151: Linter: Emit fully resolved template names

https://gerrit.wikimedia.org/r/353168

gerritbot added a project: Patch-For-Review.May 10 2017, 8:08 PM
gerritbot added a comment.May 11 2017, 2:31 PM

Change 353168 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T161151: Linter: Emit fully resolved template names

https://gerrit.wikimedia.org/r/353168

Arlolra closed this task as Resolved.May 12 2017, 1:45 PM
Arlolra claimed this task.
Arlolra reassigned this task from Arlolra to ssastry.
Arlolra subscribed.
Stashbot mentioned this in T141226: Missing data-mw content in wikitext leads to html2wt exceptions.May 15 2017, 8:20 PM
Stashbot mentioned this in T164792: Add class mw-parser-output to Parsoid's output.
Stashbot mentioned this in T37247: content-holding <div> should only contain the page text.
Stashbot mentioned this in T153107: Parsoid is generating [[Foo|Foo]] instead of [[Foo]] for some VE edits.
Stashbot mentioned this in T163091: Parsoid: Add API endpoint to get lint errors for arbitrary wikitext.
Stashbot mentioned this in T164006: Suggestion: API for fetching lint errors for a specific revision.
Stashbot subscribed.

Mentioned in SAL (#wikimedia-operations) [2017-05-15T20:20:02Z] <subbu> Updated Parsoid to a182c227 (T141226, T164792, T37247, T153107, T163091, T164006, T161151, T162920, T163549)

Stashbot mentioned this in T162920: In multi-content/template-block scenarios, Linter displays "--" in the "Through a template"? column.May 15 2017, 8:20 PM
Stashbot mentioned this in T163549: Only lint pages that have wikitext contentmodel.
Arlolra reopened this task as Open.May 25 2017, 9:07 PM

This is being reverted in prod because the patch is causing T166068

gerritbot added a comment.May 25 2017, 10:56 PM

Change 355726 had a related patch set uploaded (by Arlolra; owner: Arlolra):
[mediawiki/services/parsoid@master] T161151: Use already resolved href when available

https://gerrit.wikimedia.org/r/355726

gerritbot added a comment.May 26 2017, 12:39 AM

Change 355726 merged by jenkins-bot:
[mediawiki/services/parsoid@master] T161151: Use already resolved href when available

https://gerrit.wikimedia.org/r/355726

Arlolra closed this task as Resolved.May 26 2017, 12:43 AM
Stashbot added a comment.May 30 2017, 5:28 PM

Mentioned in SAL (#wikimedia-operations) [2017-05-30T17:28:55Z] <arlolra> Updated Parsoid to d07dfe1a (T161151, T136653)

Stashbot mentioned this in T136653: Parsoid doesn't recognize interwiki shortcuts in the href attribute.May 30 2017, 5:28 PM
Arlolra merged a task: T167255: Make Linter transcluded templates links relatives.Jun 7 2017, 2:50 PM
Arlolra added subscribers: IKhitron, Shirayuki, Mainframe98 and 2 others.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL