The ticket T149391 defines so-called 'No-Effect' states for: 1) situations where the user has selected Quality or Intent filters that return subsets of other selected filters, and 2) situations where the user has selected all filters in a "Full Coverage" group. When the user's filter combinations create a No-Effect state, the filter tags turn gray and a special tooltip is shown. Even though he suffers no harm from the "No-Effect" state, the tooltip educates him about how the tools work.
The problem
In the situation where the user has selected a filter AND highlighted it, however, the tooltip itself may be doing harm—by confusing the user.
Consider the example in the screenshot. The user has selected a filter, Likely Bad Faith, that is redundant with May Be Bad Faith. But he's also highlighted it. The filter is inactive but the highlighting works just fine. However, the tooltip tells him: 1) "The filter has no effect..." and 2) "Try highlighting to distinguish." Our user may well wonder aloud: "What do you mean? I AM highlighting. And it's working just fine. Is this thing broken?"
The fix
To remedy this, let's make a change for this SPECIFIC SITUATION: When a selected filter is 1) in a No-Effect state, whether because it is full coverage or a redundant subset, and 2) it is also highlighted:
- KEEP all the various signals we've defined for No-Effect (graying the tag, etc.).
- BUT do not display the special tooltip.
- INSTEAD, display the standard tooltip that provides the filter description.
