Page MenuHomePhabricator

VE in Timeless makes cactions non-responsive
Closed, ResolvedPublic0 Estimated Story Points

Description

Cactions are below the firstheading, so they get disabled. Content actions are needed firstly to escape edit mode (other options exist, but take them to totally other pages), but also just in general so the user can get at various other page things in general. History, view, whatever, etc.

Event Timeline

See also T164705: Provide visible tool for aborting edit in VE (which still wouldn't allow you to open the current page for reading in a new tab while editing, etc., but would improve the situation to some degree).

So this is still happening, it seems. Can we just remove the ve-init-mw-desktopArticleTarget-uneditableContent class on div#mw-page-header-links on Timeless *after* VE has been initialized for an article? That, IMO, seems like the easiest fix here.

Change 805230 had a related patch set uploaded (by Bartosz Dziewoński; author: Jdlrobson):

[mediawiki/extensions/VisualEditor@master] Ensure the edit/view tabs are never marked as "uneditable"

https://gerrit.wikimedia.org/r/805230

This is fixed courtesy of the Reading team, by indeed just removing the ve-init-mw-desktopArticleTarget-uneditableContent class, because a similar issue has been introduced in Vector (T310197) and the patch works for both skins.

Change 805230 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Ensure the edit/view tabs are never marked as "uneditable"

https://gerrit.wikimedia.org/r/805230

Esanders renamed this task from VE in Timeless makes cactions non-responsive, trapping users forever to VE in Timeless makes cactions non-responsive.Jun 20 2022, 12:22 PM
Esanders claimed this task.