Page MenuHomePhabricator

Create a new activity for managing compilations
Closed, ResolvedPublic1 Estimated Story Points

Description

There should be a screen for users to manage their Offline compilations (aka Offline Library)

Empty state:
A03.png (1×720 px, 113 KB)
With some offline compilations (aka article packs) downloaded:
A06iii - multiple compilations.png (1×720 px, 114 KB)
QA testing

User should land on this screen via the following navigation points:
(i) Tapping the Explore feed overflow menu option
(ii) Whilst offline, tapping on the "Manage compilations" action on the Offline compilations card that appears as the first card on the Explore feed.

Event Timeline

Change 365262 had a related patch set uploaded (by Dbrant; owner: Dbrant):
[apps/android/wikipedia@master] Introduce activity for managing offline compilations.

https://gerrit.wikimedia.org/r/365262

Change 365262 merged by jenkins-bot:
[apps/android/wikipedia@master] Introduce activity for managing offline compilations.

https://gerrit.wikimedia.org/r/365262

hi @Mholloway - can the base background color just be updated to use the Base80 (#EAECF0) color in Light mode instead of the current lighter gray being used?

RHo updated the task description. (Show Details)

Change 371500 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Design tweak: Update offline library screen background color

https://gerrit.wikimedia.org/r/371500

Change 371500 merged by jenkins-bot:
[apps/android/wikipedia@master] Design tweak: Update offline library screen background color

https://gerrit.wikimedia.org/r/371500

@RHo Done! Lmk if it's looking as expected now.

@Mholloway - hmm the light mode base background is now correct, but Dark mode is now using the wrong color (should be Base10-#222222 color instead of Base30-#54595d), per T172984.

Expected Light mode color
image.png (1×1 px, 199 KB)
Unexpected dark mode background color
image.png (1×1 px, 193 KB)

Change 371621 had a related patch set uploaded (by Mholloway; owner: Mholloway):
[apps/android/wikipedia@master] Design tweak: Fix offline library screen dark mode bg color

https://gerrit.wikimedia.org/r/371621

Change 371621 merged by jenkins-bot:
[apps/android/wikipedia@master] Design tweak: Fix offline library screen dark mode bg color

https://gerrit.wikimedia.org/r/371621

Both Light and dark modes of this screen are now using the right background color. A separate ticket was filed T173117 for the inability to remove compilations.

ABorbaWMF added a subscriber: ABorbaWMF.

Tested on a Nexus 4 with Android 5.1 and a Pixel with Android 7.1.1 on 2.6.201-alpha-2017-08-12

Looks good to me