Page MenuHomePhabricator
Create Task
Maniphest T166318

Footer talk link does not handle non-mainspace pages correctly
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce

  1. Go to a non-mainspace page, e.g., en:User:Example
  2. Click the Talk link in the footer and choose a browser to handle the link

Actual results

App navigates to a "bad title" page because, assuming the title is a mainspace article, it simply prepends "Talk:" to the title

Expected results

Best case: App navigates to User_talk:Example

Also acceptable and better than the status quo: "talk" link does not appear for non-mainspace pages

From OTRS report: https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=9994845

Details

SubjectRepoBranchLines +/-
Fix: talk page url does not have correct format if the page contains namespace.apps/android/wikipediamaster+22 -1
Customize query in gerrit

Related Objects

Event Timeline

• Mholloway created this task.May 25 2017, 3:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 25 2017, 3:43 PM
• Mholloway updated the task description. (Show Details)May 25 2017, 3:44 PM
Dbrant moved this task from Needs Triage to Bug Backlog on the Wikipedia-Android-App-Backlog board.May 31 2017, 2:11 PM
Dbrant merged a task: T177280: Wrong URI-format button "Talk" (Usertalk, German version).Oct 6 2017, 8:19 PM
Dbrant added subscribers: Der_Keks, Jayprakash12345.
CKoerner_WMF subscribed.EditedJan 18 2018, 9:07 PM

A contributor on English Wikipedia reported something similar to this task today. Before I go and create yet another task could someone confirm/deny if this is related?

https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#No_talk_pages_appear_on_Mobile (See YuriGagrin12's comments in particular)

Kaartic subscribed.Jun 15 2018, 8:06 PM

A contributor on English Wikipedia reported something similar to this task today. Before I go and create yet another task could someone confirm/deny if this is related?

This does seem quite related. To be more clear,

  1. The talk page links for all pages in the non-main namespace are broken (this is for all languages)
  2. As the talk page links for the other languages doesn't seem to have been localised they might be broken for mainspace pages also for non-English languages.
Der_Keks added a comment.Oct 4 2018, 5:40 PM

Is there any development about that? That embarrasses us in the world!

cooltey subscribed.Dec 19 2018, 11:35 PM

Note: related to T204100

• Mholloway unsubscribed.Dec 19 2018, 11:41 PM
gerritbot subscribed.Dec 20 2018, 12:38 AM

Change 480887 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] Fix: talk page url does not have correct format if the page contains namespace.

https://gerrit.wikimedia.org/r/480887

gerritbot added a project: Patch-For-Review.Dec 20 2018, 12:38 AM
Qzekrom subscribed.Feb 23 2019, 1:17 AM

I think the talk link should open the talk page in the mobile app instead of sending it to the browser. Good work so far!

Dbrant merged a task: T225890: link to talk pages in Android app doesn't work for non-article pages.Jun 17 2019, 12:48 PM
Dbrant added subscribers: Awkward42, Thryduulf.
Dbrant merged a task: T234722: Wikipedia mobile app talk page link links to incorrect page when outside mainspace.Oct 7 2019, 1:53 PM
Dbrant added a subscriber: Monniasza.
CKoerner_WMF unsubscribed.Oct 7 2019, 2:32 PM
gerritbot added a comment.Oct 24 2019, 10:25 PM

Change 480887 abandoned by Cooltey:
Fix: talk page url does not have correct format if the page contains namespace.

https://gerrit.wikimedia.org/r/480887

Maintenance_bot removed a project: Patch-For-Review.Oct 24 2019, 11:10 PM
• Charlotte triaged this task as Medium priority.Dec 3 2019, 5:52 PM
Dbrant merged a task: T257742: Wrong redirect for User Talk.Jul 12 2020, 1:46 PM
Dbrant added a subscriber: Italaid.
Dbrant merged a task: T258461: All pages talk link are broken except from namespace 0 on the Android app.Jul 21 2020, 12:11 PM
Dbrant added subscribers: Omar_Ghrida, alaa.
Dbrant merged tasks: T259975: [BUG] Clicking the 'View talk page' button at the bottom of a non-mainspace page on the Android App gives a 'Bad title' error, T204100: Can't open talk page in app.Aug 8 2020, 3:19 PM
Dbrant added subscribers: Nintendofan885, Shizhao, Tacsipacsi, Liuxinyu970226.
Dbrant merged a task: T265826: Talk page link error in Wikipedia App for Android.Oct 19 2020, 12:52 PM
Dbrant added subscribers: Tigerzeng, Rowe_Wilson_Frederisk_Holme.
cooltey closed this task as Resolved.Jan 13 2021, 11:17 PM
cooltey claimed this task.

This is no longer an issue anymore since we have implemented the native Talk page in the app.

Tacsipacsi added a comment.Jan 13 2021, 11:33 PM
In T166318#6746260, @cooltey wrote:

This is no longer an issue anymore since we have implemented the native Talk page in the app.

Since when? It’s still broken for me in v2.7.50337-r-2020-12-04. (I don’t see any updates in Google Play.)

cooltey added a comment.Jan 13 2021, 11:41 PM

Hi @Tacsipacsi, the native Talk page will be available in the upcoming release.

tomert mentioned this in T280437: Wikipedia Android app: talk page "title-invalid-talk-namespace" scenarios.Apr 17 2021, 9:37 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits