Page MenuHomePhabricator

Use filled bookmark icon for saving
Closed, ResolvedPublic

Description

When the user picks some filters, an option to save them appear in the form of a bookmark icon.

Currently the bookmark icon used is an outlined version, but a filled version should be used as captured in the original designs (T164128) both (a) as the icon in the "active filters" area and (b) in the dialog shown when the user clicks on the former one.

Event Timeline

Change 361602 had a related patch set uploaded (by Catrope; owner: Catrope):
[mediawiki/core@master] RCFilters: Always use the filled bookmark icon (unClip)

https://gerrit.wikimedia.org/r/361602

An earlier prototype or design must have made the distinction between the filled and unfilled versions of this icon, otherwise we wouldn't have gone through the trouble of creating both icons and having the button change state (in master currently, the unfilled icon becomes filled when you click to open the popup).

In any case, I'm attaching a patch that uses the filled icon in all situations.

An earlier prototype or design must have made the distinction between the filled and unfilled versions of this icon, otherwise we wouldn't have gone through the trouble of creating both icons and having the button change state (in master currently, the unfilled icon becomes filled when you click to open the popup).

You are right. The initial exploration used both icons. Since the technical proof of concept for saving filters started early, some aspects were based on initial ideas and were expected to change (T151994#3237839). Fortunately, those changes turned out not too be massive.

Change 361602 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Always use the filled bookmark icon (unClip)

https://gerrit.wikimedia.org/r/361602

Change 361823 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Followup I436f00bc87db: Remove onPopupToggle listener

https://gerrit.wikimedia.org/r/361823

Change 361823 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Followup I436f00bc87db: Remove onPopupToggle listener

https://gerrit.wikimedia.org/r/361823

Etonkovidova added a subscriber: Etonkovidova.EditedJul 7 2017, 10:45 PM

The bookmark icon is consistent now - it's always displayed as filled.

However, un-filled bookmark icon indicated in a clearer way that the filter has not been saved yet? And changing icons from filled (when a saved filter displayed) to unfilled (when a filter is not saved yet) may solve the problem of communicating to a user that saved filter is displayed T169063: Make saved filters title more prominent when applied.

QA Recommendation: Product should weigh in

jmatazzoni closed this task as Resolved.Jul 12 2017, 11:43 PM