Page MenuHomePhabricator
Create Task
Maniphest T170184

Refactor anti-spam/vandalism checks out of EditPage.php
Open, LowPublic
Actions

Description

The documentation for EditPage::internalAttemptSave() has the following comment:

	 * @todo FIXME: This interface is TERRIBLE, but hard to get rid of due to
	 *   various error display idiosyncrasies. There are also lots of cases
	 *   where error metadata is set in the object and retrieved later instead
	 *   of being returned, e.g. AS_CONTENT_TOO_BIG and
	 *   AS_BLOCKED_PAGE_FOR_USER. All that stuff needs to be cleaned up some
	 * time.

We should fix this by extracting all the anti-spam/vandalism checks (plus hooks) out of EditPage, and into a pluggable interface (that ideally promotes best practices like T59026).

EditPage would call into this to determine whether the edit is OK or not, and then update the UI accordingly.

Details

SubjectRepoBranchLines +/-
[POC] Refactor spam filter edit checksmediawiki/coremaster+279 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Jul 10 2017, 6:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 10 2017, 6:44 PM
Legoktm mentioned this in T120414: RFC: MediaWiki should provide a pluggable registry for editor interfaces.Jul 10 2017, 6:46 PM
Jdforrester-WMF subscribed.Jul 10 2017, 7:33 PM
Aklapper added a project: Technical-Debt.Jul 11 2017, 12:49 PM
Anomie subscribed.Jul 16 2017, 3:25 AM

Duplicate of T20654: EditPage.php needs rewrite: Separate DB and UI logic? There's a lot more technical debt there than just anti-spam checks.

Legoktm added a comment.Jul 16 2017, 11:03 PM
In T170184#3441811, @Anomie wrote:

Duplicate of T20654: EditPage.php needs rewrite: Separate DB and UI logic? There's a lot more technical debt there than just anti-spam checks.

A subtask. There's definitely more work to be done, but this is the scope of what I'm planning to do this quarter.

Legoktm added a parent task: T20654: EditPage.php needs rewrite: Separate DB and UI logic.Jul 16 2017, 11:08 PM
gerritbot subscribed.Jul 17 2017, 9:48 PM

Change 365866 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] [POC] Refactor spam filter edit checks

https://gerrit.wikimedia.org/r/365866

gerritbot added a project: Patch-For-Review.Jul 17 2017, 9:48 PM
tstarling moved this task from Inbox to Watching on the MediaWiki-Platform-Team-Archived board.Jul 20 2017, 10:13 AM
• MZMcBride subscribed.Aug 24 2017, 2:13 PM
tstarling moved this task from Watching to Backlog on the MediaWiki-Platform-Team-Archived board.Oct 9 2017, 1:50 AM
MaxSem moved this task from Unsorted to Needs refactor on the Technical-Debt board.Oct 12 2017, 2:05 AM
CCicalese_WMF edited projects, added Core-Platform-Team-Old; removed MediaWiki-Platform-Team-Archived.Jul 12 2018, 12:50 AM
CCicalese_WMF moved this task from Inbox to Backlog on the Core-Platform-Team-Old board.Jul 12 2018, 12:57 AM
CCicalese_WMF added a project: Platform Team Legacy (Later).Oct 1 2018, 11:33 PM
CCicalese_WMF edited projects, added Core Platform Team Goals (MCR: Uncategorized); removed Core-Platform-Team-Old.Oct 2 2018, 12:29 AM
CCicalese_WMF edited projects, added Platform Engineering; removed Core Platform Team Goals (MCR: Uncategorized).Oct 2 2018, 2:31 AM
CCicalese_WMF moved this task from Inbox to Triage Meeting Inbox on the Platform Engineering board.Oct 2 2018, 2:41 AM
CCicalese_WMF moved this task from Triage Meeting Inbox to Needs Cleaning - Code Health (TEC13) on the Platform Engineering board.Oct 3 2018, 3:56 PM
CCicalese_WMF edited projects, added Platform Engineering (Needs Cleaning - Code Health (TEC13)); removed Platform Engineering.
WDoranWMF moved this task from Later to Mop Column on the Platform Team Legacy board.Jul 5 2019, 3:43 PM
WDoranWMF removed a project: Platform Team Legacy (Later).
WDoranWMF removed Legoktm as the assignee of this task.Jul 9 2019, 7:22 PM
WDoranWMF triaged this task as Low priority.
WDoranWMF edited projects, added Platform Team Workboards (Clinic Duty Team), Platform Engineering (Decoupling (CDP2)); removed Platform Engineering (Needs Cleaning - Code Health (TEC13)).
WDoranWMF moved this task from Decoupling (CDP2) to mop on the Platform Engineering board.Jul 26 2019, 6:56 PM
WDoranWMF edited projects, added Platform Team Initiatives (Decoupling (CDP2)); removed Platform Engineering (Decoupling (CDP2)).
daniel moved this task from Inbox to Backlog on the Platform Team Workboards (Clinic Duty Team) board.Oct 8 2019, 9:57 AM
• AMooney changed the task status from Open to Stalled.Mar 12 2020, 1:22 PM
• AMooney edited projects, added Platform Engineering; removed Platform Team Workboards (Clinic Duty Team).
CCicalese_WMF moved this task from mop to Icebox on the Platform Engineering board.Mar 12 2020, 1:47 PM
WDoranWMF edited projects, added Platform Engineering (Icebox); removed Platform Engineering.Mar 23 2020, 2:05 PM
CCicalese_WMF removed a project: Platform Engineering (Icebox).Mar 24 2020, 10:31 PM
DannyS712 added subscribers: • AMooney, DannyS712.Apr 20 2020, 4:41 PM

@AMooney what is stalling this task?

Aklapper changed the task status from Stalled to Open.May 18 2020, 1:41 PM

@AMooney: I cannot see either in previous comments what/who exactly this task is stalled on ("If a report is waiting for further input (e.g. from its reporter or a third party) and can currently not be acted on"). Hence boldly resetting task status (please feel free to correct me and elaborate - thanks!)

• AMooney added a comment.May 18 2020, 1:50 PM

@Aklapper, I think I accidentally set it to stalled when I was trying to do some housekeeping. I do think from the the time the task was last looked at to when I set it to stalled it had not been looked at in awhile, maybe 5 months?

gerritbot added a comment.Jun 2 2020, 9:19 PM

Change 365866 abandoned by Legoktm:
[POC] Refactor spam filter edit checks

Reason:
Rescue after EditPage refactor

https://gerrit.wikimedia.org/r/365866

Legoktm added a comment.Jun 2 2020, 9:20 PM

There's useful code in my patch, specifically the EditRequest value object, but I think this makes more sense to do after an EditPage refactor or as part of it (which I don't want to do)

Maintenance_bot removed a project: Patch-For-Review.Jun 2 2020, 10:12 PM
DannyS712 claimed this task.Jun 2 2020, 10:37 PM
In T170184#6186732, @Legoktm wrote:

There's useful code in my patch, specifically the EditRequest value object, but I think this makes more sense to do after an EditPage refactor or as part of it (which I don't want to do)

Will take a look - I have a larger plan for each of the different checks that edit page uses to possibly prevent an edit, including the spam checkr

Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 2 2020, 10:37 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:02 PM
Zabe subscribed.Oct 5 2021, 4:29 PM
Aklapper removed DannyS712 as the assignee of this task.Sep 26 2022, 10:34 AM
Aklapper removed a subscriber: • AMooney.

Removing task assignee due to inactivity as this open task has been assigned for more than two years. See the email sent to the task assignee on August 22nd, 2022.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome!
If this task has been resolved in the meantime, or should not be worked on ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL