Uses P629 (edition of) to add Wikipedia link in the other projects sidebar of Wikisource
Open, NormalPublic

Description

Wikisources pages are connected using sitelinks to the edition items of Wikidata and Wikipedia articles to the work items. The edition item is connected with P629 to the work item. It would be nice to use this relation to fill automatically the other projects sidebar of Wikisource.

It could be implemented using the OtherProjectsSidebarHook inside of the "Wikisource" extension that is not yet deployed or inside of the WikimediaBadges extension (just like what is done for Commons categories).

Tpt created this task.Nov 12 2017, 4:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 12 2017, 4:59 PM
Tpt updated the task description. (Show Details)Nov 12 2017, 5:00 PM
Peachey88 updated the task description. (Show Details)Nov 12 2017, 8:04 PM

I'm fine with doing this and I believe it should be done in the same way as Commons so we have consistency.

Tpt added a comment.Nov 14 2017, 11:14 AM

I'm fine with doing this and I believe it should be done in the same way as Commons so we have consistency.

Yes, it should be implemented the same way. About the location, are you more in favor of doing it in the WikimediaBadges extension and not in a "Wikisource" extension even if it is Wikisource specific? We should also take into account T180304 which aims at doing the same thing but for language-links. The implementation for these two tasks should probably be in the same place.

I don't have an opinion on that personally.

hoo added a subscriber: hoo.

MediaWiki-extensions-WikimediaBadges sounds like the right place for this to me as well.

Change 408365 had a related patch set uploaded (by Tpt; owner: Tpt):
[mediawiki/extensions/Wikisource@master] Uses the sitelinks from the work item in the other projects sidebar

https://gerrit.wikimedia.org/r/408365

Tpt added a comment.Mar 16 2018, 8:36 AM

I have made a change for the Wikisource extension (the CI is currently broken because the dependency on Wikibase is not setup yet). Having this feature there has two advantages:

  1. Do not require a configuration parameter to enable/disable this feature. We probably want it only on Wikisource.
  2. I am not sure that we want T180304 in WikimediaBadges and implementation of both feature are sharing some concerns (retrieving edition/work items...).

If the Wikidata team prefers to have both T180303 and T180304 in WikimediaBadges it's fine for me and I would be happy to implement the changes there.

hoo added a comment.Mar 20 2018, 7:31 PM

@Tpt After looking at both tickets, I think it's fine to do it in the Wikisource extension… in the end I guess one could argue for any of the solutions, but having this in a truly Wikisource only extension definitely makes sense.

Change 408365 had a related patch set uploaded (by Tpt; owner: Tpt):
[mediawiki/extensions/Wikisource@master] Uses the sitelinks from the work item in the other projects sidebar

https://gerrit.wikimedia.org/r/408365

Change 472769 had a related patch set uploaded (by Tpt; owner: Tpt):
[mediawiki/extensions/Wikibase@master] WikibaseClientOtherProjectsSidebar hook: pass the site to output array to the handler

https://gerrit.wikimedia.org/r/472769

Change 408365 had a related patch set uploaded (by Tpt; owner: Tpt):
[mediawiki/extensions/Wikisource@master] Uses the sitelinks from the work item in the other projects sidebar

https://gerrit.wikimedia.org/r/408365

Change 472769 had a related patch set uploaded (by Tpt; owner: Tpt):
[mediawiki/extensions/Wikibase@master] WikibaseClientOtherProjectsSidebar hook: pass the site to output array to the handler

https://gerrit.wikimedia.org/r/472769

Addshore triaged this task as Normal priority.Tue, Nov 20, 8:00 AM
Addshore moved this task from incoming to in progress on the Wikidata board.Wed, Nov 21, 8:19 AM

Change 472769 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] WikibaseClientOtherProjectsSidebar hook: pass the site to output array to the handler

https://gerrit.wikimedia.org/r/472769

Tpt added a comment.Thu, Nov 22, 6:45 PM

For this task to be done, the extension should be deployed on Wikisource: T210174

Change 475941 had a related patch set uploaded (by Tpt; owner: Tpt):
[mediawiki/extensions/Wikibase@master] Pass an UpdateAccumulator to WikibaseClientOtherProjectsSidebar hook

https://gerrit.wikimedia.org/r/475941

Is there anything left to do for the Wikidata team atm here?

Tpt added a comment.Tue, Dec 11, 10:49 AM

@Lydia_Pintscher Maybe review https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikisource/+/408365 and try to push the security review of the Wikisource extension to get it deployed on beta then production cluster.