[wmf.8 - regression] Related changes: Saved filters set as default won't include the page as part of a query
Closed, ResolvedPublic
Actions

Description

As @MaxSem found out:

On Special:RealtedChanges page set some filters as default.
Go to a Random page, then click on the Related changes on the left-hand navigation links.
Special: Related changes should display results filtered by the page - but default saved filters will not include the referral page, i.e. url won't have Special:RecentChangesLinked/name_of_the page

Note 1: if there is no user set default filters - the above scenario works as expected - the page is displayed in 'Page name' box and results are filtered accordingly.

Note 2: It seems like a ramification of not saving a page as part of the saved filters on Special:Related Pages (also reported as T178293: "Related changes" can't work at zhwiki ), saved filters set as default won't filter for

Details

	Subject	Repo	Branch	Lines +/-
	RCFilters: Respect subpage in RCLinked	mediawiki/core	master	+27 -2
	RCFilters: Respect subpage in RCLinked	mediawiki/core	wmf/1.31.0-wmf.8	+27 -2

Customize query in gerrit

Related Objects

Mentioned In: T183437: [wmf.12] Related changes without new filters - article title becomes sticky in Page name text box
T178293: "Related changes" can't work at zhwiki
T181631: Special:RelatedChanges/foo no longer redirects to Special:Recentchangeslinked/foo
Mentioned Here: T172161: Integrate 'Related Changes' tools into the new UX
T178293: "Related changes" can't work at zhwiki

Event Timeline

Etonkovidova created this task.Nov 21 2017, 10:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 21 2017, 10:07 PM

Catrope added a project: Edit-Review-Improvements-RC-Page.Nov 21 2017, 10:09 PM

Etonkovidova updated the task description. (Show Details)Nov 21 2017, 10:12 PM

Etonkovidova added a subscriber: MaxSem.

Change 392756 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[mediawiki/core@master] RCFilters: Respect subpage in RCLinked

https://gerrit.wikimedia.org/r/392756

gerritbot added a project: Patch-For-Review.Nov 22 2017, 12:25 AM

Trizek-WMF subscribed.Nov 22 2017, 7:56 AM

Change 392756 merged by jenkins-bot:
[mediawiki/core@master] RCFilters: Respect subpage in RCLinked

https://gerrit.wikimedia.org/r/392756

Change 392882 had a related patch set uploaded (by Jforrester; owner: Mooeypoo):
[mediawiki/core@wmf/1.31.0-wmf.8] RCFilters: Respect subpage in RCLinked

https://gerrit.wikimedia.org/r/392882

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 22 2017, 7:00 PM

Change 392882 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.8] RCFilters: Respect subpage in RCLinked

https://gerrit.wikimedia.org/r/392882

Etonkovidova moved this task from Untriaged to QA Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Nov 27 2017, 7:31 PM

Mentioned in SAL (#wikimedia-operations) [2017-11-27T19:39:01Z] <catrope@tin> Synchronized php-1.31.0-wmf.8/includes/specials/SpecialRecentchangeslinked.php: T181100 (duration: 00m 45s)

Mentioned in SAL (#wikimedia-operations) [2017-11-27T19:42:42Z] <catrope@tin> Synchronized php-1.31.0-wmf.8/resources/src/mediawiki.rcfilters/mw.rcfilters.UriProcessor.js: T181100 (duration: 00m 45s)

This is now deployed, and the patch mostly works, but it's still broken in one aspect: if you don't have a default saved query, the title is in the URL path instead of in the title param, and the JS doesn't normalize that into the target param, so changing the target in the UI results in two targets in the URL.

Catrope moved this task from QA Review to Ready for Pickup on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.Nov 27 2017, 7:57 PM

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-11-14 (1.31.0-wmf.8)); removed MW-1.31-release-notes (WMF-deploy-2017-11-28 (1.31.0-wmf.10)).Nov 27 2017, 8:00 PM

• Petar.petkovic removed a project: Patch-For-Review.Nov 27 2017, 8:04 PM

In T181100#3790037, @Catrope wrote:

This is now deployed, and the patch mostly works, but it's still broken in one aspect: if you don't have a default saved query, the title is in the URL path instead of in the title param, and the JS doesn't normalize that into the target param, so changing the target in the UI results in two targets in the URL.

See _normalizeTargetInUri (and associated unit tests) for a way to normalize subpage in url for T172161. Still WIP but mostly for its dependencies on hidden/sticky patches.

Aklapper mentioned this in T181631: Special:RelatedChanges/foo no longer redirects to Special:Recentchangeslinked/foo.Nov 30 2017, 1:23 PM

Catrope mentioned this in T178293: "Related changes" can't work at zhwiki.Dec 5 2017, 7:04 PM

Liuxinyu970226 subscribed.Dec 6 2017, 2:10 PM