Page MenuHomePhabricator
Create Task
Maniphest T182834

Argument 1 passed to FlowHooks::onSpecialCheckUserGetLinksFromRow() must be an instance of CheckUser, SpecialCheckUser given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

2017-12-13 23:03:27 [WjGxvwpAEKkAABcduPwAAAAL] mw1214 commonswiki 1.31.0-wmf.12 error ERROR: [WjGxvwpAEKkAABcduPwAAAAL] /wiki/Special:CheckUser   ErrorException from line 177 of /srv/mediawiki/php-1.31.0-wmf.12/includes/Hooks.php: PHP Error: Argument 1 passed to FlowHooks::onSpecialCheckUserGetLinksFromRow() must be an instance of CheckUser, SpecialCheckUser given {"exception_id":"WjGxvwpAEKkAABcduPwAAAAL","exception_url":"/wiki/Special:CheckUser","caught_by":"mwe_handler"}
[Exception ErrorException] (/srv/mediawiki/php-1.31.0-wmf.12/includes/Hooks.php:177) PHP Error: Argument 1 passed to FlowHooks::onSpecialCheckUserGetLinksFromRow() must be an instance of CheckUser, SpecialCheckUser given
  #1 /srv/mediawiki/php-1.31.0-wmf.12/includes/Hooks.php(177): FlowHooks::onSpecialCheckUserGetLinksFromRow(SpecialCheckUser, stdClass, array)
  #3 /srv/mediawiki/php-1.31.0-wmf.12/extensions/CheckUser/specials/SpecialCheckUser.php(1618): Hooks::run(string, array)
  #4 /srv/mediawiki/php-1.31.0-wmf.12/extensions/CheckUser/specials/SpecialCheckUser.php(1445): SpecialCheckUser->getLinksFromRow(stdClass)
  #5 /srv/mediawiki/php-1.31.0-wmf.12/extensions/CheckUser/specials/SpecialCheckUser.php(769): SpecialCheckUser->CUChangesLine(stdClass, string)
  #6 /srv/mediawiki/php-1.31.0-wmf.12/extensions/CheckUser/specials/SpecialCheckUser.php(95): SpecialCheckUser->doIPEditsRequest(string, boolean, string, integer)
  #7 /srv/mediawiki/php-1.31.0-wmf.12/includes/specialpage/SpecialPage.php(522): SpecialCheckUser->execute(NULL)

Details

SubjectRepoBranchLines +/-
Fix CheckUser type check thingymediawiki/extensions/Flowmaster+1 -1
Remove unused access to (Special)CheckUser objectmediawiki/extensions/Flowmaster+6 -17
Fix CheckUser type check thingymediawiki/extensions/Flowwmf/1.31.0-wmf.15+1 -1
Revert "Rename classes to match file names"mediawiki/extensions/CheckUsermaster+19 -20
Fix CheckUser type check thingymediawiki/extensions/Flowwmf/1.31.0-wmf.12+1 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

Reedy created this task.Dec 13 2017, 11:04 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptDec 13 2017, 11:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Reedy triaged this task as High priority.Dec 13 2017, 11:05 PM
Reedy added a subscriber: jrbs.
• demon added a project: Wikimedia-production-error.Dec 13 2017, 11:06 PM
gerritbot subscribed.Dec 13 2017, 11:08 PM

Change 398177 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/CheckUser@master] Revert "Rename classes to match file names"

https://gerrit.wikimedia.org/r/398177

gerritbot added a project: Patch-For-Review.Dec 13 2017, 11:08 PM

Change 398178 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Flow@master] Fix CheckUser type check thingy

https://gerrit.wikimedia.org/r/398178

gerritbot added a comment.Dec 13 2017, 11:10 PM

Change 398179 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/Flow@wmf/1.31.0-wmf.12] Fix CheckUser type check thingy

https://gerrit.wikimedia.org/r/398179

matmarex added subscribers: Umherirrender, Huji, matmarex.Dec 13 2017, 11:11 PM

Apparently CheckUser has been renamed to SpecialCheckUser in 6ab26d6e47f7526708c4a9da52f6ff79373be328 (https://gerrit.wikimedia.org/r/#/c/396599/).

Krenair subscribed.Dec 13 2017, 11:17 PM
gerritbot added a comment.Dec 13 2017, 11:19 PM

Change 398179 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.31.0-wmf.12] Fix CheckUser type check thingy

https://gerrit.wikimedia.org/r/398179

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)).Dec 14 2017, 12:00 AM
gerritbot added a comment.Dec 14 2017, 10:01 AM

Change 398231 had a related patch set uploaded (by Thiemo Mättig (WMDE); owner: Thiemo Mättig (WMDE)):
[mediawiki/extensions/Flow@master] Remove unused access to (Special)CheckUser object

https://gerrit.wikimedia.org/r/398231

matmarex added a comment.EditedDec 14 2017, 8:42 PM

Note that a fix has been merged only in 1.31.0-wmf.12, but not in master.

Looks like we have three competing patches right now:

Someone must review those and merge one of them soon, otherwise this issue will reappear in wmf.13 wmf.15. I'm not very familiar with Flow or CheckUser myself.

matmarex added a parent task: T180748: 1.31.0-wmf.15 deployment blockers.Dec 14 2017, 8:44 PM
matmarex unsubscribed.
gerritbot added a comment.Dec 14 2017, 8:45 PM

Change 398177 abandoned by Reedy:
Revert "Rename classes to match file names"

https://gerrit.wikimedia.org/r/398177

Reedy added a comment.Dec 14 2017, 8:50 PM

There's no train next week... So it's not urgent

• demon moved this task from Untriaged to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.Dec 15 2017, 12:21 AM
Umherirrender added a comment.Dec 15 2017, 6:30 PM

It is enough to add a class_alias for the renamed class?

Reedy added a comment.Dec 15 2017, 7:52 PM
In T182834#3841281, @Umherirrender wrote:

It is enough to add a class_alias for the renamed class?

Maybe, but then we're just leaving around techdebt we don't really need to.

Thiemos patch clears up the usage, which seems better in the long run

Umherirrender unsubscribed.Jan 1 2018, 2:24 PM
• jmatazzoni edited projects, added Collaboration-Team-Triage (Collab-Team-This-Quarter); removed Collaboration-Team-Triage.Jan 2 2018, 8:12 PM
• jmatazzoni moved this task from Untriaged to Needs Review on the Collaboration-Team-Triage (Collab-Team-This-Quarter) board.
Legoktm raised the priority of this task from High to Unbreak Now!.Jan 4 2018, 2:39 AM
Restricted Application added subscribers: Liuxinyu970226, Jay8g, TerraCodes. · View Herald TranscriptJan 4 2018, 2:39 AM
gerritbot added a comment.Jan 4 2018, 2:39 AM

Change 401832 had a related patch set uploaded (by Legoktm; owner: Reedy):
[mediawiki/extensions/Flow@wmf/1.31.0-wmf.15] Fix CheckUser type check thingy

https://gerrit.wikimedia.org/r/401832

gerritbot added a comment.Jan 4 2018, 2:45 AM

Change 398178 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Fix CheckUser type check thingy

https://gerrit.wikimedia.org/r/398178

gerritbot added a comment.Jan 4 2018, 2:46 AM

Change 401832 merged by jenkins-bot:
[mediawiki/extensions/Flow@wmf/1.31.0-wmf.15] Fix CheckUser type check thingy

https://gerrit.wikimedia.org/r/401832

Stashbot subscribed.Jan 4 2018, 2:49 AM

Mentioned in SAL (#wikimedia-operations) [2018-01-04T02:49:26Z] <legoktm@tin> Synchronized php-1.31.0-wmf.15/extensions/Flow/Hooks.php: Fix CheckUser type check thingy - T182834 (duration: 01m 01s)

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-01-09 (1.31.0-wmf.16)); removed MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)).Jan 4 2018, 3:00 AM
gerritbot added a comment.Jan 4 2018, 3:01 AM

Change 398231 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Remove unused access to (Special)CheckUser object

https://gerrit.wikimedia.org/r/398231

• mmodell subscribed.EditedJan 4 2018, 7:13 PM

So is this fixed by rEFLW91e80d2ccd10: Fix CheckUser type check thingy ?

• mmodell closed this task as Resolved.Jan 4 2018, 9:54 PM
• mmodell claimed this task.

Looks like it is.

• mmodell reassigned this task from • mmodell to Reedy.Jan 4 2018, 9:54 PM
Liuxinyu970226 unsubscribed.Jan 5 2018, 11:30 AM
Reedy removed a project: Patch-For-Review.May 17 2019, 9:42 PM
Krinkle moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.May 29 2019, 4:01 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:09 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL