Remove 'Expand all section' toggle on tablet and desktop mode
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	• Nirzar
	Dec 21 2017, 7:34 PM

Description

Issue

Tablets/desktop layout is set to expanding all sections by default on MinervaNeue. this creates a little bit of problem when a setting to enable/disable this feature is introduced on tablets. as a result, if you turn off "expand all sections" on tablets, it won't actually collapse all section which is the expected behaviour.

Expected behaviour

on tablets+desktop this particular toggle should not appear in the settings page

Developer notes

Favor JavaScript use M.require( 'mobile.startup/Browser' ).isWideScreen() instead of CSS.

AC

On a small screen device, the expand all sections beta option is displayed on Special:MobileOptions.
On a large screen device, the expand all sections beta option is hidden on Special:MobileOptions and the Barack Obama page appears with all sections initially expanded.

Details

Subject	Repo	Branch	Lines +/-
Update: hide section expansion option on large displays	mediawiki/extensions/MobileFrontend	specialpages	+9 -2
Update: hide section expansion option on large displays	mediawiki/extensions/MobileFrontend	master	+9 -2
Update: hide section expansion option on large displays	mediawiki/extensions/MobileFrontend	specialpages	+9 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T158181 Aim for workflow equivalence for MediaWiki on desktop and mobile web
Declined	None	T67078 Allow feedback for mobile beta features like Desktop
Resolved	• Jhernandez	T104319 [GOAL]: Feature flag features on MobileFrontend
Resolved	None	T141087 [EPIC] Add feature management
Resolved	ovasileva	T67079 [Epic] Show what features are included in Beta
Resolved	ovasileva	T182217 Deploy `specialpages` feature branch (promote new Special:MobileOptions, fontchanger etc)
Resolved	• Nirzar	T169257 Promote expand all sections feature from beta (in feature branch)
Resolved	• Nirzar	T183493 Remove 'Expand all section' toggle on tablet and desktop mode

Event Timeline

• Nirzar triaged this task as Medium priority.Dec 21 2017, 7:34 PM

• Nirzar created this task.

• Nirzar mentioned this in T169257: Promote expand all sections feature from beta (in feature branch).Dec 21 2017, 7:36 PM

How about we hide "Expand all sections" on tablets? As far as I know tablets never had the section toggling feature.

• bmansurov unsubscribed.Dec 22 2017, 9:48 PM

@Nirzar what do you think of baha's suggestion? This was only ever designed for mobile (where many users complained that sections were collapsed making find all on page difficult) and I'd argue not very useful on tablet devices. What is the use case there?

I'd suggest that if we do hide this on tablet devices, we'd change the label to say "Expand all sections on mobile"

Pulling into sprint for visibility since it blocks T169257

Let's remove this option from tablets for now. no change in the label.

we can rename this task to remove the setting to 'expand all sections' on tablets

Jdlrobson renamed this task from 'Expand all section' toggle should work on tablets and desktops to Remove 'Expand all section' toggle on tablet and desktop mode.Jan 2 2018, 7:20 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson moved this task from Needs Prioritization to 2017-18 Q2 on the Web-Team-Backlog board.Jan 2 2018, 11:13 PM

phuedx added a parent task: T182217: Deploy `specialpages` feature branch (promote new Special:MobileOptions, fontchanger etc).Jan 3 2018, 5:36 PM

• Niedzielski updated the task description. (Show Details)Jan 3 2018, 5:53 PM

• Niedzielski set the point value for this task to 2.

Jdlrobson removed • Nirzar as the assignee of this task.Jan 3 2018, 6:03 PM

Jdlrobson updated the task description. (Show Details)

• Niedzielski claimed this task.Jan 4 2018, 1:13 PM

• Niedzielski moved this task from To Do to Doing on the Readers-Web-Kanbanana-Board-Old board.

• Niedzielski updated the task description. (Show Details)Jan 4 2018, 4:48 PM

• Niedzielski updated the task description. (Show Details)Jan 4 2018, 5:16 PM

• Niedzielski updated the task description. (Show Details)

Change 402082 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[mediawiki/extensions/MobileFrontend@master] Update: hide section expansion option on large displays

https://gerrit.wikimedia.org/r/402082

gerritbot added a project: Patch-For-Review.Jan 4 2018, 5:21 PM

@Jdlrobson, I didn't apply your recommendation to use isTabletDevice() since this is a PHP function and it seems that the toggle option display logic should match the initial collapse state logic in toggle.js. Please let me know if you disagree.

• Niedzielski moved this task from Doing to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jan 4 2018, 5:23 PM

Jdlrobson updated the task description. (Show Details)Jan 4 2018, 5:54 PM

Jdlrobson moved this task from Needs Code Review to Needs More Work on the Readers-Web-Kanbanana-Board-Old board.

• Niedzielski moved this task from Needs More Work to Needs Code Review on the Readers-Web-Kanbanana-Board-Old board.Jan 4 2018, 8:24 PM

Change 402113 had a related patch set uploaded (by Jdlrobson; owner: Sniedzielski):
[mediawiki/extensions/MobileFrontend@specialpages] Update: hide section expansion option on large displays

https://gerrit.wikimedia.org/r/402113

Change 402113 abandoned by Jdlrobson:
Update: hide section expansion option on large displays

https://gerrit.wikimedia.org/r/402113

Change 402116 had a related patch set uploaded (by Niedzielski; owner: Sniedzielski):
[mediawiki/extensions/MobileFrontend@specialpages] Update: hide section expansion option on large displays

https://gerrit.wikimedia.org/r/402116

Change 402082 abandoned by Niedzielski:
Update: hide section expansion option on large displays

Reason:
Moved to https://gerrit.wikimedia.org/r/#/c/402116/.

https://gerrit.wikimedia.org/r/402082

Jdlrobson moved this task from Needs Code Review to Needs QA on the Readers-Web-Kanbanana-Board-Old board.Jan 4 2018, 9:04 PM

Jdlrobson moved this task from Needs QA to Ready for Signoff on the Readers-Web-Kanbanana-Board-Old board.