Deduplicate template styles in mobileviews API
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	Tgr
	Feb 13 2018, 12:20 AM

Description

T168333: CSS is duplicated on each template usage is now fixed for most things but the mobileviews API splits the HTML into sections so it needs to do its own, per-section deduplication.

The mechanism, as implemented in core for rMW9b2b375fcef1: ParserOutput: Add 'deduplicateStyles' post-cache transformation, is to find <style> tags with a data-mw-deduplicate attribute, and replace all but the first of each deduplication value with <link rel="mw-deduplicated-inline-style" href="mw-data:..."/>; the ellipsis there is a percent-encoded representation version of the deduplication value.

Related Objects
Search...

Status	Subtype	Assigned	Task
Declined		None	T208761 [Epic] Improve PHPUnit coverage in MobileFrontend to 50%
Resolved		Jdlrobson	T186627 Remove the MobileView API
Declined		None	T173379 Remove mobileview API call for main page
Duplicate		None	T172525 [EPIC] Deprecate MobileView API in MobileFrontend
Resolved		Jdlrobson	T32405 [EPIC] MobileFrontend extension should stop special-casing main page
Duplicate		None	T138449 Throw warning when edits made to a main page which uses special casing
Duplicate		None	T138622 Help community migrate away from legacy Main page special casing
Declined		None	T125920 [EPIC] Future exciting reading web performance endeavours
Resolved		Jdlrobson	T131423 FOUC in section "Recently featured" on mobile Main Page
Duplicate		None	T126137 FOUC for styles applied via MediaWiki:Mobile.css due to bottom-loading
Duplicate		None	T130846 Hat-note FOUC on mobile skin
Open		bwang	T361737 [EPIC] With the current layout, some elements extend beyond the content area and overlap sticky page tools
Duplicate		ovasileva	T66577 Large tables created by editors are not responsive
Resolved		None	T51440 MobileFrontend images shown double-sized in Retina desktop, iOS 7 beta
Open		None	T40848 Security: CSS positioning can be used to break out of the content area
Open		None	T37704 Drop support in wikitext for inline styles
Resolved		TheDJ	T151170 Varying layouts for commons mobile main page
Declined		None	T125257 Infoboxes should take the max. available width of the screen
Invalid		None	T135857 Map points aligned to viewport on mobile
Open	Feature	None	T17075 Per book, category and/or template CSS and JavaScript
Invalid		None	T109152 [EPIC] All templates on wiki should work in mobile
Resolved		TheDJ	T94107 {{hat}} and similar templates on Wikipedia are invisible to mobile web view.
Resolved		TheDJ	T118062 In the mobile frontend, in the list produced by Template:Notelist-ua, efn-ua footnotes appear with numeric labels instead of uppercase-alpha. They appear normal in the text, and in the desktop frontend.
Invalid		None	T120238 Wrong display of certain English Wikipedia portal pages in mobile
Resolved		Izno	T127727 navigational sidebar on mobile, should float on wide screens.
Resolved		TheDJ	T128095 Signpost is not readable on mobile devices
Open		None	T117950 Remove the need for `.noprint`
Resolved		Jdlrobson	T117951 Remove templaters' need for .nomobile and support authoring media queries for templates
Declined		None	T66578 Migrate css rules in hacks.less into templates
Resolved		Tgr	T133410 Deploy TemplateStyles to WMF production
Resolved		Tgr	T188198 Enable TemplateStyles on ruwiki on 2018-04-10
Declined		None	T187141 Deduplicate template styles in mobileviews API

Event Timeline

Tgr created this task.Feb 13 2018, 12:20 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2018, 12:20 AM

Tgr edited projects, added Performance-Team (Radar); removed Performance-Team.Feb 13 2018, 12:22 AM

Tgr mentioned this in T168333: CSS is duplicated on each template usage.

Krinkle removed a project: Performance-Team (Radar).Feb 13 2018, 1:14 AM

Anomie updated the task description. (Show Details)Feb 13 2018, 2:40 AM

@Tgr Could you please clarify how this task relates to TemplateStyles deployment ruwiki? Thanks!

That's up to the ruwiki community to decide, there never was much concern about duplication on the WMF side. I'd imagine if they are concerned about desktop performance they would be about mobile web as well, which is where this API is used.

Tgr mentioned this in T187142: Deduplicate template styles in Parsoid.Feb 13 2018, 8:50 PM

Jdlrobson added a project: Web-Team-Backlog (Tracking).Feb 14 2018, 12:17 AM

Jdlrobson moved this task from Untriaged to Discuss further on the Web-Team-Backlog (Tracking) board.Feb 15 2018, 12:48 AM

• ggellerman triaged this task as Medium priority.Feb 27 2018, 6:43 PM

Tgr mentioned this in T188198: Enable TemplateStyles on ruwiki on 2018-04-10.Feb 28 2018, 2:36 AM

Tgr added a parent task: T188198: Enable TemplateStyles on ruwiki on 2018-04-10.Mar 2 2018, 7:05 PM

Tgr mentioned this in T133410: Deploy TemplateStyles to WMF production.Mar 16 2018, 8:02 AM