Page MenuHomePhabricator

Delete all Phabricator git repos that haven't been referenced / aren't used.
Open, NormalPublic

Description

Since replacing Diffusion with Gitiles as Gerrit's repo viewer, we've greatly reduced the utility of having Git repositories in Phabricator. We should do the following:

  • For all repos that have not yet been referenced in a comment or other config/etc, drop them
  • Creating a repository in Phabricator should be as-needed instead of assumed for all Gerrit repos
  • Archived repos can basically all be deleted, provided they satisfy the first condition
  • Uninstall the Gerrit-To-Phab plugin we wrote for 1:1 mapping. It's not necessary anymore
  • Swap Special:Version links to using Gitiles

Also means that T183792, T115624, T179206 probably a few others can be declined.

Event Timeline

demon created this task.Feb 13 2018, 4:08 AM
demon triaged this task as Normal priority.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 13 2018, 4:08 AM
demon updated the task description. (Show Details)Feb 13 2018, 4:09 AM
demon updated the task description. (Show Details)

Should the tasks in the Repository Migrations column of Gerrit-Migration be closed then?

demon added a comment.Feb 13 2018, 5:10 AM

Well, if a particular project wants to use Phabricator, they're more than welcome to. But some can probably be declined.

nb: I think you know my opinion on T119908 these days...

I disagree. I still think all repos should be sync'd to phabricator.

Phabricator doesn't only exist as an accessory for gerrit. Having repositories in Phabricator, for one thing, provides a mirror we control. Phabricator currently provides us with a multi-datacenter redundant repository hosting infrastructure. Soon we will be able to have deployments fetch from a git repo hosted in the same datacenter as the target server. If phabricator is a sunk cost then we can close a lot of open tasks and I might as well start looking for a new job.

demon added a comment.Feb 15 2018, 2:10 AM

Gerrit also provides multi-datacenter capability, so we've got local mirrors. I understand maybe wanting a non-Gerrit mirror we control...but the complete lack of organization of our repo setup there makes it a pain to work with...manual repo maintenance is the ultimate killer for me... I'd rather replicate to a random VM and expose them over git:// than the status quo.

(I'd also argue the majority of our users don't find them useful, considering how much Github gets used just for linking things if nothing else)

Now... I'd be fine with nuking them and recreating them in a sensible manner, dropping the non-branch/tag refs and having a bridge to handle creation/deletion automatically.

Now... I'd be fine with nuking them and recreating them in a sensible manner, dropping the non-branch/tag refs and having a bridge to handle creation/deletion automatically.

+1. It should be fairly simple to automatically keep them in sync. I agree that the status quo is a mess (due to various hysterical reasons which you know very well) but that's no reason to just nuke the whole thing.

greg added a subscriber: greg.Feb 15 2018, 5:41 PM

Personally, I like having the repos in Phab; I don't dislike Diffusion as much as some others do and the clean markup for linking/rending is nice. And them being here doesn't hurt anyone (modulo maintenance).

Now... I'd be fine with nuking them and recreating them in a sensible manner, dropping the non-branch/tag refs and having a bridge to handle creation/deletion automatically.

This seems like the way forward. Can you re-title & edit the description to clarify the new intent here?

I personally strongly oppose it:

  1. When a commit mentions a task ID, it will automatically displayed in the task's history
  2. Diffusion provides a way to mention a commit in a task and the mention is tracked
  3. Diffusion provides a way to search both repo and commit in main Phabricator search (together with other documents, and may be filtered by author)
  4. Diffusion provides a way to search code pattern; I don't see similar tools in Gitiles (though there's probably some external tools)
  5. Delete all Phabricator git repos that haven't been referenced make Diffusion an inconsistent state and may confuse users who want to search repos in Phabricator; either delete all Diffusion repos (this will break links in tasks) or keep all repos