Splitting from T37247: content-holding <div> should only contain the page text and T180817: Review TemplateStyles patches related to previewing site CSS changes. Patch is https://gerrit.wikimedia.org/r/c/352835/ but seems like it needs to be done in a slightly different way.
Description
Description
Details
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T245748 Phase out JS-based legacy page indicators | |||
| Resolved | TheDJ | T230471 TMH audio player missing for clips inside <indicator> | |||
| Resolved | cscott | T188443 Wrap indicators in mw-parser-output class |
Event Timeline
This comment was removed by Izno.
Comment Actions
As a note, this can be worked around wiki-side by including an element that has the class as part of the indicator e.g.
<indicator>
<span class="mw-parser-output">
<templatestyles src=foo/>
<span class="some-class">stuff</span>
</span>
</indicator>will output the styles into the indicator as expected. Clearly a workaround but it works ~.
Comment Actions
Change 749284 had a related patch set uploaded (by TheDJ; author: TheDJ):
[mediawiki/core@master] WIP: Wrap all indicators with mw-parser-output
Comment Actions
Change 770666 had a related patch set uploaded (by C. Scott Ananian; author: TheDJ):
[mediawiki/core@master] parse: Wrap indicators with a div.mw-parser-output element
Comment Actions
Change 770666 merged by jenkins-bot:
[mediawiki/core@master] parse: Wrap indicators with a div.mw-parser-output element
Comment Actions
Change 749284 abandoned by Bartosz Dziewoński:
[mediawiki/core@master] parse: Wrap indicators with a div.mw-parser-output element
Reason:
Superseded by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/770666
Comment Actions
I'm curious: why the entire .mw-indicators block or at least the individual #mw-indicator-<id> element wasn't wrapped inside .mw-parser-output? I've found it useful to target #mw-indicator-<id> in CSS as it allows me to adjust e.g. vertical alignment of an individual indicator without affecting alignment of other indicators inside the block, and it'd be nice to do so via TemplateStyles as well.