Page MenuHomePhabricator
Create Task
Maniphest T188479

Deletion logs on mediawiki.org are not showing the proper user making the deletions
Closed, ResolvedPublic
Actions

Description

Via https://www.mediawiki.org/wiki/Special:Log/delete

05:29, 28 February 2018 Dharmadeepa V (talk | contribs | block) deleted page User:Dharmadeepa V (spam (this is legoktm)) (view/restore)

That was me deleting the page.

Reported via @Stemoc

Details

SubjectRepoBranchLines +/-
tests: Assert that the user who deleted a page is logged as suchmediawiki/coremaster+166 -0
WikiPage: Avoid $user variable reuse in doDeleteArticleReal()mediawiki/corewmf/1.31.0-wmf.23+7 -7
WikiPage: Avoid $user variable reuse in doDeleteArticleReal()mediawiki/coremaster+7 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm triaged this task as Unbreak Now! priority.Feb 28 2018, 5:30 AM
Legoktm created this task.
Restricted Application added subscribers: Liuxinyu970226, TerraCodes, Aklapper. · View Herald TranscriptFeb 28 2018, 5:30 AM
Legoktm added a parent task: T183962: 1.31.0-wmf.23 deployment blockers.Feb 28 2018, 5:31 AM
Legoktm updated the task description. (Show Details)
Legoktm added a subscriber: Stemoc.
• MZMcBride subscribed.Feb 28 2018, 5:32 AM
Legoktm added a comment.Feb 28 2018, 5:37 AM

This isn't just a display issue, incorrect data is being written into the database.

greg subscribed.Feb 28 2018, 5:46 AM

Reverted back to wmf.22:

05:43:37 +logmsgbot | !log demon@tin rebuilt and synchronized wikiversions files: (no justification provided)

gerritbot subscribed.Feb 28 2018, 5:48 AM

Change 415223 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/core@master] WikiPage: Avoid $user variable reuse in doDeleteArticleReal()

https://gerrit.wikimedia.org/r/415223

gerritbot added a project: Patch-For-Review.Feb 28 2018, 5:48 AM
Legoktm added a comment.Feb 28 2018, 5:52 AM

Via #mediawiki: <Sveta> Does mediawiki have a unit test for this?

Someone does need to do that. Multiple tests could have caught this - validating that the log entry inserted had the right performer, checking that the ArticleDeleteComplete hook got the right deleter, etc.

Peachey88 added a project: Regression.Feb 28 2018, 9:11 AM
gerritbot added a comment.Feb 28 2018, 2:16 PM

Change 415223 merged by jenkins-bot:
[mediawiki/core@master] WikiPage: Avoid $user variable reuse in doDeleteArticleReal()

https://gerrit.wikimedia.org/r/415223

gerritbot added a comment.Feb 28 2018, 6:02 PM

Change 415351 had a related patch set uploaded (by Greg Grossmeier; owner: Legoktm):
[mediawiki/core@wmf/1.31.0-wmf.23] WikiPage: Avoid $user variable reuse in doDeleteArticleReal()

https://gerrit.wikimedia.org/r/415351

gerritbot added a comment.Feb 28 2018, 8:13 PM

Change 415351 merged by jenkins-bot:
[mediawiki/core@wmf/1.31.0-wmf.23] WikiPage: Avoid $user variable reuse in doDeleteArticleReal()

https://gerrit.wikimedia.org/r/415351

Stashbot subscribed.Feb 28 2018, 8:20 PM

Mentioned in SAL (#wikimedia-operations) [2018-02-28T20:20:49Z] <thcipriani@tin> Synchronized php-1.31.0-wmf.23/includes/page/WikiPage.php: [[gerrit:415351|WikiPage: Avoid $user variable reuse in doDeleteArticleReal()]] T188479 (duration: 00m 57s)

thcipriani closed this task as Resolved.Feb 28 2018, 9:39 PM
thcipriani assigned this task to Legoktm.
thcipriani subscribed.

After this deploy:

In T188479#4011694, @Stashbot wrote:

Mentioned in SAL (#wikimedia-operations) [2018-02-28T20:20:49Z] <thcipriani@tin> Synchronized php-1.31.0-wmf.23/includes/page/WikiPage.php: [[gerrit:415351|WikiPage: Avoid $user variable reuse in doDeleteArticleReal()]] T188479 (duration: 00m 57s)

20:41:49 <legoktm> thcipriani: ok, looks fixed to me

Looks like it's been merged to master as well, so closing this to keep the blockers ticket nice and tidy.

gerritbot added a comment.Feb 28 2018, 11:04 PM

Change 415477 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] tests: Assert that the user who deleted a page is logged as such

https://gerrit.wikimedia.org/r/415477

thcipriani mentioned this in T188773: Test to validate deletion log entries and ArticleDeleteComplete hook performers.Mar 2 2018, 7:34 PM
greg added a project: Wikimedia-Incident.Mar 2 2018, 7:49 PM
greg moved this task from Active investigation to Active Situation on the Wikimedia-Incident board.
Liuxinyu970226 unsubscribed.Mar 3 2018, 12:59 PM
ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 6 2018, 10:01 AM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)); removed MW-1.31-release-notes (WMF-deploy-2018-03-06 (1.31.0-wmf.24)).Mar 6 2018, 11:01 AM
gerritbot added a comment.Apr 26 2018, 1:07 AM

Change 415477 merged by jenkins-bot:
[mediawiki/core@master] tests: Assert that the user who deleted a page is logged as such

https://gerrit.wikimedia.org/r/415477

Ladsgroup removed a project: Patch-For-Review.May 21 2019, 9:33 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits