Expose api-stashedit JS to non-legacy textarea editors
Open, LowPublic
Actions

Description

Stashes are triggered by changes to #wpTextbox1 and #wpSummary. Extensions which replace the editor, such as CodeMirror (syntax highlighting), CodeEditor & VE wikitext don't use #wpTextbox1.

The jQuery.textSelection module provides a way for other editors to override getting and setting the value of #wpTextbox1, but not an event for when it is changed.

Details

	Subject	Repo	Branch	Lines +/-
	PageEditStash: Minor docs and code clean up	mediawiki/core	master	+31 -26
	Separate out generic edit stash API helper	mediawiki/core	master	+124 -94

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T255502 Goal: Save Timing median back under 1 second
Open	None	T189821 Use stashedit in 2017 wikitext editor (wikitext mode within the visual editor)
Open	None	T189824 Expose api-stashedit JS to non-legacy textarea editors

Event Timeline

• Esanders created this task.Mar 15 2018, 10:01 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptMar 15 2018, 10:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Esanders added a subtask: T189821: Use stashedit in 2017 wikitext editor (wikitext mode within the visual editor).Mar 15 2018, 10:02 PM

• Esanders updated the task description. (Show Details)Mar 15 2018, 10:48 PM

• Esanders added subscribers: Krinkle, matmarex, Catrope.

• Esanders claimed this task.Mar 16 2018, 7:00 PM

Change 420110 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Separate out generic edit stash API helper

https://gerrit.wikimedia.org/r/420110

gerritbot added a project: Patch-For-Review.Mar 16 2018, 7:04 PM

Jdforrester-WMF moved this task from To Triage to Current work on the VisualEditor board.Mar 22 2018, 5:32 PM

Jdforrester-WMF edited projects, added VisualEditor (Current work); removed VisualEditor.

Jdforrester-WMF moved this task from Incoming to In progress on the VisualEditor (Current work) board.Mar 22 2018, 5:37 PM

Krinkle added a project: Performance-Team.Mar 22 2018, 7:01 PM

• Imarlier moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Mar 26 2018, 8:19 PM

Krinkle renamed this task from stashedit doesn't work as well non-wpTextbox1 editors to Expose api-stashedit JS to non-legacy textarea editors.Mar 26 2018, 8:23 PM

• TBolliger moved this task from New & TBD Tickets to Product backlog on the Community-Tech board.Mar 27 2018, 12:36 AM

• TBolliger moved this task from Product backlog to Older: Tracking Work by Others on the Community-Tech board.Mar 27 2018, 12:41 AM

Krinkle added a project: MediaWiki-Page-editing.Apr 12 2018, 4:18 PM

Krinkle moved this task from Backlog to Stash on the MediaWiki-Page-editing board.

@Esanders Patch has comments, waiting on your reply

• Imarlier edited projects, added Performance-Team (Radar); removed Performance-Team.Jun 21 2018, 11:08 AM

Niharika removed a project: Community-Tech.Jun 21 2018, 6:46 PM

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Jul 18 2018, 12:31 AM

• Deskana triaged this task as Low priority.Aug 1 2018, 12:21 PM

• Deskana edited projects, added VisualEditor; removed VisualEditor (Current work).

• Deskana moved this task from To Triage to Freezer on the VisualEditor board.

Krenair subscribed.Apr 16 2019, 2:15 AM

Aklapper edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Oct 15 2020, 1:11 PM

Removing task assignee due to inactivity, as this open task has been assigned to the same person for more than two years (see the emails sent to the task assignee on Oct27 and Nov23). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome.
(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

Krinkle moved this task from Watching to Perf recommendation on the Performance-Team (Radar) board.Feb 18 2021, 5:52 PM

Krinkle added a parent task: T277788: Save Timing improvements (2021-2022).Apr 13 2022, 10:00 PM

Change 779956 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] PageEditStash: Minor docs and code clean up

https://gerrit.wikimedia.org/r/779956

gerritbot added a project: Patch-For-Review.Apr 13 2022, 10:00 PM

Restricted Application removed a project: Patch-Needs-Improvement. · View Herald TranscriptApr 13 2022, 10:00 PM

Krinkle removed a subtask: T189821: Use stashedit in 2017 wikitext editor (wikitext mode within the visual editor).Apr 13 2022, 10:01 PM

Krinkle added a parent task: T189821: Use stashedit in 2017 wikitext editor (wikitext mode within the visual editor).

Change 779956 merged by jenkins-bot:

[mediawiki/core@master] PageEditStash: Minor docs and code clean up

https://gerrit.wikimedia.org/r/779956