Page MenuHomePhabricator
Create Task
Maniphest T277788

Save Timing improvements (2021-2022)
Closed, ResolvedPublic
Actions

Description

Tracking task for various improvements in response to:

And any other improvements by others that the team helped with in some way (Thanks @ori).

Details

SubjectRepoBranchLines +/-
WikiPage: Move clearTitleUserNotifications() call to post-sendmediawiki/coremaster+32 -8
edit: Make PreparedEdit->timestamp lazy to avoid eager parsemediawiki/coremaster+7 -11
parser: Avoid calling ParserOptions::getOption() too many timesmediawiki/coreREL1_36+14 -4
parser: Avoid calling ParserOptions::getOption() too many timesmediawiki/coreREL1_35+14 -4
parser: Avoid calling ParserOptions::getOption() too many timesmediawiki/coremaster+14 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

Krinkle created this task.EditedMar 18 2021, 6:20 PM

Tracking here to make it easier to find later if we find a noticable change around the time of next week:

Patch by @ori was merged:

Avoid calling into PHP from Lua to check if 'current' or 'empty' frames exist

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Scribunto/+/673173

Patch by @ori was merged:

Optimize getSetting() calls in mw.wikibase.lua

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/673366

Krinkle edited projects, added Performance-Team (Radar); removed Performance-Team.Mar 18 2021, 6:21 PM
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.
gerritbot added a comment.May 14 2021, 6:46 PM

Change 661214 had a related patch set uploaded (by Krinkle; author: Aaron Schulz):

[mediawiki/core@master] Avoid triggering a parse in DerivedPageDataUpdater::getPreparedEdit()

https://gerrit.wikimedia.org/r/661214

gerritbot added a project: Patch-For-Review.May 14 2021, 6:46 PM
Krinkle added a subtask: T283029: FlaggableWikiPage::preloadPreparedEdit() does not actually carry over the parser output, leading to double parses on save.May 17 2021, 6:52 PM
• dpifke subscribed.Jun 2 2021, 5:09 PM
gerritbot added a comment.Aug 3 2021, 7:44 PM

Change 709812 had a related patch set uploaded (by Krinkle; author: Amir Sarabadani):

[mediawiki/core@master] parser: Avoid calling ParserOptions::getOption() too many times

https://gerrit.wikimedia.org/r/709812

gerritbot added a comment.Aug 4 2021, 11:08 PM

Change 709812 merged by jenkins-bot:

[mediawiki/core@master] parser: Avoid calling ParserOptions::getOption() too many times

https://gerrit.wikimedia.org/r/709812

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).Aug 5 2021, 12:00 AM
Ladsgroup subscribed.Aug 11 2021, 6:05 PM

I think I found a big reason behind save timing issues. SpamBlacklist uses this hook onEditFilterMergedContent and with some calls to functions that are now deprecated it ends calling the renderer twice. Here's an example from XHGui for Wikidata: https://performance.wikimedia.org/xhgui/run/symbol?id=6113e67fd4a278337527bd38&symbol=MediaWiki%5CRevision%5CRenderedRevision%3A%3AgetSlotParserOutputUncached (Found it as part of doing T285987: Do not generate full html parser output at the end of Wikibase edit requests)

Krinkle added a subtask: T264104: Verify AbuseFilter code that claims to share and re-use ParserOutput from core.Aug 16 2021, 8:30 PM
Krinkle added a subtask: T289923: Let AbuseFilter cache its parser AST result.Aug 30 2021, 3:39 AM
gerritbot added a comment.Sep 8 2021, 9:20 PM

Change 719503 had a related patch set uploaded (by Paladox; author: Amir Sarabadani):

[mediawiki/core@REL1_36] parser: Avoid calling ParserOptions::getOption() too many times

https://gerrit.wikimedia.org/r/719503

Paladox subscribed.Sep 8 2021, 9:23 PM
gerritbot added a comment.Sep 8 2021, 9:32 PM

Change 719504 had a related patch set uploaded (by Reedy; author: Amir Sarabadani):

[mediawiki/core@REL1_35] parser: Avoid calling ParserOptions::getOption() too many times

https://gerrit.wikimedia.org/r/719504

gerritbot added a comment.Sep 8 2021, 9:42 PM

Change 719504 merged by jenkins-bot:

[mediawiki/core@REL1_35] parser: Avoid calling ParserOptions::getOption() too many times

https://gerrit.wikimedia.org/r/719504

gerritbot added a comment.Sep 8 2021, 9:44 PM

Change 719503 merged by jenkins-bot:

[mediawiki/core@REL1_36] parser: Avoid calling ParserOptions::getOption() too many times

https://gerrit.wikimedia.org/r/719503

ReleaseTaggerBot added projects: MW-1.36-notes, MW-1.35-notes.Sep 8 2021, 10:00 PM
matmarex mentioned this in T290514: Reply tool has gotten slower?.Sep 13 2021, 11:20 PM
matmarex mentioned this in T292082: Edit response time doubled on mobile.Sep 29 2021, 6:03 PM
Krinkle added a subtask: T292300: Eliminate unnecessary duplicate parses (2021-2022).Oct 4 2021, 7:35 PM
ppelberg subscribed.Oct 13 2021, 3:10 PM
gerritbot added a comment.Dec 1 2021, 3:02 PM

Change 661214 merged by jenkins-bot:

[mediawiki/core@master] edit: Make PreparedEdit->timestamp lazy to avoid eager parse

https://gerrit.wikimedia.org/r/661214

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Dec 1 2021, 4:00 PM
Krinkle added a subtask: T297147: RevisionStore::newRevisionSlots() needs a cache.Dec 8 2021, 3:05 PM
Krinkle renamed this task from Save Timing improvements (2021) to Save Timing improvements (2021-2022).Dec 16 2021, 7:05 PM
Krinkle added a subtask: T285987: Do not generate full html parser output at the end of Wikibase edit requests.
Krinkle added a subtask: T269960: Schema properties in client code loads the whole item in every page view.
Krinkle removed a project: MW-1.37-notes (1.37.0-wmf.18; 2021-08-09).
Krinkle updated the task description. (Show Details)
Ladsgroup closed subtask T297147: RevisionStore::newRevisionSlots() needs a cache as Resolved.Dec 21 2021, 9:18 AM
Ladsgroup closed subtask T288639: SpamBlacklistHooks::onEditFilterMergedContent causes every edit to be rendered twice as Resolved.Jan 13 2022, 2:32 PM
gerritbot added a comment.Jan 27 2022, 11:48 PM

Change 757773 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] WikiPage: Move clearTitleUserNotifications() call to post-send

https://gerrit.wikimedia.org/r/757773

gerritbot added a comment.Feb 2 2022, 7:55 PM

Change 757773 merged by jenkins-bot:

[mediawiki/core@master] WikiPage: Move clearTitleUserNotifications() call to post-send

https://gerrit.wikimedia.org/r/757773

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.21; 2022-02-07); removed MW-1.38-notes (1.38.0-wmf.12; 2021-12-06).Feb 2 2022, 8:00 PM
Ladsgroup closed subtask T283029: FlaggableWikiPage::preloadPreparedEdit() does not actually carry over the parser output, leading to double parses on save as Resolved.Feb 23 2022, 4:43 AM
Krinkle added a subtask: T189824: Expose api-stashedit JS to non-legacy textarea editors.Apr 13 2022, 10:00 PM
Krinkle added a subtask: T189821: Use stashedit in 2017 wikitext editor (wikitext mode within the visual editor).
Krinkle added a subtask: T304283: Backend save timing regression 2021-03-21.May 19 2022, 2:17 PM
Krinkle added a subtask: T300075: P75 Edit response time has almost doubled since Jan 11, 2022.
matej_suchanek mentioned this in T314373: On examine of abuse filters the variable old_links contains duplicate protocol-relative URL.Aug 2 2022, 1:35 PM
Krinkle added a subtask: T322823: Restore ability for PageEditStash to store "large" ParserOutput/Content objects with value segmentation.Dec 13 2022, 10:40 PM
aaron closed subtask T322823: Restore ability for PageEditStash to store "large" ParserOutput/Content objects with value segmentation as Resolved.Dec 14 2022, 10:55 PM
Krinkle moved this task from Watching to Perf recommendation on the Performance-Team (Radar) board.Aug 18 2023, 8:05 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 18 2023, 8:10 PM
Krinkle edited projects, added Wikimedia-Performance-recommendation; removed Performance-Team (Radar).Aug 18 2023, 8:41 PM
Krinkle removed a subtask: T289923: Let AbuseFilter cache its parser AST result.Sep 16 2023, 7:06 AM
Krinkle closed subtask T292300: Eliminate unnecessary duplicate parses (2021-2022) as Resolved.
Krinkle mentioned this in T292300: Eliminate unnecessary duplicate parses (2021-2022).
Krinkle removed a subtask: T189821: Use stashedit in 2017 wikitext editor (wikitext mode within the visual editor).Sep 16 2023, 7:10 AM
Krinkle removed a subtask: T189824: Expose api-stashedit JS to non-legacy textarea editors.
Krinkle closed this task as Resolved.Sep 16 2023, 7:16 AM
Krinkle claimed this task.

Closing this as this was tracking Perf Team work in FY2021-2022. The task hasn't been active for a while, and the parent goal is still waiting to be scheduled for a quarterly focus.

I've moved remaining tasks from here to the parent goal at T255502: Goal: Save Timing median back under 1 second.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits