Page MenuHomePhabricator

Mobile web block reason fails to display a hyperlink properly, displaying the raw HTML code for a link instead
Closed, ResolvedPublic

Description

The first thing in T165535: Block notices on mobile web for logged-in users provide insufficient information about the block that should be done is fix the HTML escaping of the block reason.

Event Timeline

dbarratt triaged this task as Normal priority.Mar 28 2018, 5:01 AM
dbarratt created this task.

Change 422363 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/skins/MinervaNeue@master] Block reason messages escape HTML

https://gerrit.wikimedia.org/r/422363

@Nirzar the mobile toast should never have HTML inside it right? The above patch does this but the toast does allow for it.

Another solution would be to strip the HTML so it renders in plain text (sans the escaped HTML)

@Jdlrobson yes, no html inside toasts. also as per task, i thought we would be using drwer not a toast?

@Nirzar I'll change it to a drawer in T165535, just looking for an incremental improvement. ;)

TBolliger renamed this task from Mobile block reason fails to display a hyperlink properly, displaying the raw HTML code for a link instead to Mobile web block reason fails to display a hyperlink properly, displaying the raw HTML code for a link instead.Mar 28 2018, 4:24 PM

Change 422363 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Block reason messages escape HTML

https://gerrit.wikimedia.org/r/422363

dbarratt closed this task as Resolved.Mar 29 2018, 10:26 PM
dbarratt moved this task from Review to Done on the Anti-Harassment (AHT Sprint 18) board.

I believe this has caused a regression: T191470