Maniphest T191066

1.32.0-wmf.20 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	greg
	Mar 29 2018, 6:08 PM

Details

Release Version: 1.32.0-wmf.20
Release Date: Sep 3 2018, 12:00 AM

2018 week 36 1.32-wmf.20 Changes wmf/1.32.0-wmf.20

This MediaWiki Train Deployment is scheduled for the week of Monday, September 3rd:

Monday September 3rd	Tuesday, September 4th	Wednesday, September 5th	Thursday, September 6th	Friday
Backports only.	Branch `wmf.20` and deploy to Group 0 Wikis.	Deploy `wmf.20` to Group 1 Wikis.	Deploy `wmf.20` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.20 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.32.0-wmf.19

Next: 1.32.0-wmf.21

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	hashar	T191066 1.32.0-wmf.20 deployment blockers
Resolved		daniel	T203583 {{subst:REVISIONUSER}} no longer substitutes into the current user name, but the username of the last revision
Resolved		ArielGlenn	T203647 Clean up flow dump job problems for Sept 1 2018 dumps run
Resolved		Amire80	T203750 Button to open complete list of languages is no longer functional on en-Wiki
Resolved	PRODUCTION ERROR	tstarling	T203566 ParserOutput cache incompatibility errors in 1.32.0-wmf.20
Duplicate	PRODUCTION ERROR	None	T203567 Warning: Invalid operand type was used: implode() expects a container as one of the arguments in /srv/mediawiki/php-1.32.0-wmf.20/includes/parser/ParserOutput.php on line 428

Event Timeline

greg created this task.Mar 29 2018, 6:08 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 29 2018, 6:08 PM

greg triaged this task as Medium priority.Mar 29 2018, 6:15 PM

Liuxinyu970226 subscribed.Jul 24 2018, 7:16 AM

greg assigned this task to hashar.Aug 30 2018, 4:18 PM

Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptAug 30 2018, 4:18 PM

Mentioned in SAL (#wikimedia-operations) [2018-09-04T11:46:59Z] <hashar> Preparing train deploy 1.32.0-wmf.20 | T191066

Mentioned in SAL (#wikimedia-operations) [2018-09-04T11:50:02Z] <hashar> Cutting branch 1.32.0-wmf.20 | T191066

Mentioned in SAL (#wikimedia-operations) [2018-09-04T12:24:38Z] <hashar> scap prep 1.32.0-wmf.20 # T191066

Mentioned in SAL (#wikimedia-operations) [2018-09-04T12:32:38Z] <hashar> Applied security patches for 1.32.0-wmf.20 | T191066

Mentioned in SAL (#wikimedia-operations) [2018-09-04T12:35:29Z] <hashar> scap clean 1.32.0-wmf.18 | T191066

Mentioned in SAL (#wikimedia-operations) [2018-09-04T12:43:00Z] <hashar@deploy1001> Started scap: testwiki to php-1.32.0-wmf.20 and rebuild l10n cache - T191066

Mentioned in SAL (#wikimedia-operations) [2018-09-04T13:45:56Z] <hashar@deploy1001> Finished scap: testwiki to php-1.32.0-wmf.20 and rebuild l10n cache - T191066 (duration: 62m 55s)

Krinkle mentioned this in T201686: Changes to module dependencies are not propagating to load.php startup manifest .Sep 5 2018, 1:44 AM

Mentioned in SAL (#wikimedia-operations) [2018-09-06T13:03:42Z] <hashar> all wikis to 1.32.0-wmf.20 | T191066

There was again T203566: ParserOutput cache incompatibility errors in 1.32.0-wmf.20 which is "just" a cache issue as I understand it. It only happens when the new version is rolled and disappear after that once the cache has been repopulated.

T203567: Warning: Invalid operand type was used: implode() expects a container as one of the arguments in /srv/mediawiki/php-1.32.0-wmf.20/includes/parser/ParserOutput.php on line 428 could potentially have been a blocker, but it does not seem to have much impact. The log spam is fairly limited and it is being looked at.

There are some spikes of memcached errors, that is mc2** hosts being rebooted in codfw.

greg added a subtask: T203661: Old page title is displayed after renaming a page until the page is subsequently edited/null edited.Sep 6 2018, 2:25 PM

greg added a subtask: T203583: {{subst:REVISIONUSER}} no longer substitutes into the current user name, but the username of the last revision .Sep 6 2018, 2:46 PM

I'm not sure T203661 should block the train. Cosmetic error which is irritating but not broken, and is self-correcting the next time the page is edited. Not to say we won't back-port a fix for it, but "stop the train" is (and should be) a higher bar.

ack, thanks for the feedback, I was being overly cautious.

greg removed a subtask: T203661: Old page title is displayed after renaming a page until the page is subsequently edited/null edited.Sep 6 2018, 6:06 PM

Krinkle added a subtask: T203647: Clean up flow dump job problems for Sept 1 2018 dumps run.Sep 6 2018, 6:17 PM

Jdforrester-WMF closed subtask T203583: {{subst:REVISIONUSER}} no longer substitutes into the current user name, but the username of the last revision as Resolved.Sep 6 2018, 6:48 PM

T203750 being hotfixed by reverting a patch. Revert is https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/458743

Amire80 closed subtask T203750: Button to open complete list of languages is no longer functional on en-Wiki as Resolved.Sep 7 2018, 9:49 AM

ArielGlenn closed subtask T203647: Clean up flow dump job problems for Sept 1 2018 dumps run as Resolved.Sep 10 2018, 10:08 AM

Can we declare this Resolved? The wmf.20 is everywhere…

Krinkle added a subtask: T203566: ParserOutput cache incompatibility errors in 1.32.0-wmf.20.Sep 11 2018, 6:20 PM

Indeed.

T203566 is still being worked on but, yeah, we have rolled out, and T203566 explicitly prevents us from rolling back as well (we tried..), so fine to close.

I have left it open indicating that some issues where still being working on. But yeah the stack looks more or less fine now.

Liuxinyu970226 unsubscribed.Sep 11 2018, 10:47 PM

hashar closed subtask T203566: ParserOutput cache incompatibility errors in 1.32.0-wmf.20 as Resolved.Jul 31 2019, 5:21 AM

1.32.0-wmf.20 deployment blockersClosed, ResolvedPublicReleaseActions