Maniphest T203661

Old page title is displayed after renaming a page until the page is subsequently edited/null edited
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	IKhitron
	Sep 6 2018, 12:54 PM

Description

Hi. Starting from yesterday evening deployment, you can't move pages properly any more.

Open some page.
Move it to a new place.
Open it there.

Expected: The page has a new name.
Got: The page has the old name. [Edit to clarify: the old title is shown on the page]
For example: https://he.wikipedia.org/wiki/User:IKhitron/movetest5.
A nulledit helped to me, but did not to somebody else. Looks like some caching problem. Thank you.

Note that when opening the page with the editor it sometimes recognizes the page name correctly:

and sometimes does not.

Initial hypothesis: When the ParserCache is updated, the new ParserOutput is generated with the wrong Title object as context.

Details

	Subject	Repo	Branch	Lines +/-
	Provide a RevisionRecord with the correct title after a move	mediawiki/core	wmf/1.32.0-wmf.20	+9 -9
	Provide a RevisionRecord with the correct title after a move	mediawiki/core	master	+9 -9

Customize query in gerrit

Related Objects

Mentioned In: T191066: 1.32.0-wmf.20 deployment blockers

Event Timeline

IKhitron created this task.Sep 6 2018, 12:54 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 6 2018, 12:54 PM

IKhitron updated the task description. (Show Details)Sep 6 2018, 12:58 PM

IKhitron updated the task description. (Show Details)

Probably related to the MCR work on revision rendering.

IKhitron updated the task description. (Show Details)Sep 6 2018, 1:11 PM

IKhitron updated the task description. (Show Details)

IKhitron updated the task description. (Show Details)Sep 6 2018, 1:13 PM

IKhitron updated the task description. (Show Details)Sep 6 2018, 1:26 PM

Niharika updated the task description. (Show Details)Sep 6 2018, 2:16 PM

Niharika subscribed.

IKhitron updated the task description. (Show Details)Sep 6 2018, 2:19 PM

greg added a parent task: T191066: 1.32.0-wmf.20 deployment blockers.Sep 6 2018, 2:25 PM

Confirming that this is broken on master, and worked in wmf.19.

daniel renamed this task from Page moving does not work properly any more to Old page title is displayed after renaming a page.Sep 6 2018, 2:49 PM

daniel claimed this task.

daniel updated the task description. (Show Details)

jeremyb-phone added a subscriber: jeremyb.Sep 6 2018, 3:23 PM

Jdforrester-WMF renamed this task from Old page title is displayed after renaming a page to Old page title is displayed after renaming a page until the page is subsequently edited/null edited.Sep 6 2018, 3:32 PM

Change 458526 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] Require a Title as context for rendering.

https://gerrit.wikimedia.org/r/458526

gerritbot added a project: Patch-For-Review.Sep 6 2018, 4:00 PM

Fix is up. When I recently introduced the new RevisionRenderer class, I made it rely on RevisionRecord::getPageAsLinkTarget to get a Title object to give to the parser. This means that the parser would use as context whatever page the revision was loaded from. Which is nearly always the right thing. But not during page moves.

I have changed the signature of the new method to require a Title object to be provided explicitly.

Jdforrester-WMF mentioned this in T191066: 1.32.0-wmf.20 deployment blockers.Sep 6 2018, 6:05 PM

greg removed a parent task: T191066: 1.32.0-wmf.20 deployment blockers.Sep 6 2018, 6:06 PM

Change 458547 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Provide a RevisionRecord with the correct title after a move

https://gerrit.wikimedia.org/r/458547

Change 458547 merged by jenkins-bot:
[mediawiki/core@master] Provide a RevisionRecord with the correct title after a move

https://gerrit.wikimedia.org/r/458547

Change 458559 had a related patch set uploaded (by Jforrester; owner: Anomie):
[mediawiki/core@wmf/1.32.0-wmf.20] Provide a RevisionRecord with the correct title after a move

https://gerrit.wikimedia.org/r/458559

ReleaseTaggerBot added a project: MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)).Sep 6 2018, 7:00 PM

Change 458559 merged by jenkins-bot:
[mediawiki/core@wmf/1.32.0-wmf.20] Provide a RevisionRecord with the correct title after a move

https://gerrit.wikimedia.org/r/458559

Mentioned in SAL (#wikimedia-operations) [2018-09-06T21:32:26Z] <krinkle@deploy1001> Synchronized php-1.32.0-wmf.20/includes/MovePage.php: T203661 - I9ebdcbc566b (duration: 00m 57s)