Page MenuHomePhabricator
Create Task
Maniphest T191874

TypeError: Cannot read property 'attributes' of undefined at MWImage
Closed, ResolvedPublic
Actions

Description

MT processing error: TypeError: Cannot read property 'attributes' of undefined\n at MWImage.<anonymous> (/home/nike/stuff/mw/cxserver/lib/translationunits/MWImage.js:91:47

On Special:ContentTranslation&page=FC%20Lahti&from=fi&to=sv&targettitle=FC%20Lahti&version=2 when trying to translate the infobox

Details

SubjectRepoBranchLines +/-
Don't fail on images which are not also linksmediawiki/services/cxservermaster+6 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Nikerabbit created this task.Apr 10 2018, 7:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 10 2018, 7:45 AM
KartikMistry subscribed.Apr 10 2018, 7:53 AM
KartikMistry added a comment.Apr 10 2018, 8:06 AM

Specific to CX2 it seems.

Etonkovidova subscribed.Apr 10 2018, 4:50 PM

So, T191856: CX2-testing - 403 error for Yandex is a duplicate?

Etonkovidova added a subtask: T191856: CX2-testing - 403 error for Yandex .Apr 10 2018, 4:51 PM
KartikMistry added a comment.Apr 10 2018, 4:55 PM
In T191874#4120778, @Etonkovidova wrote:

So, T191856: CX2-testing - 403 error for Yandex is a duplicate?

No. Both seems different.

Pginer-WMF moved this task from Needs Triage to Check & Move on the ContentTranslation board.May 4 2018, 12:10 PM
Arrbee added a project: User-KartikMistry.Jun 6 2018, 3:27 PM
Pginer-WMF added a project: Language-2018-Apr-June.Jun 6 2018, 3:29 PM
Pginer-WMF moved this task from Check & Move to CX2 on the ContentTranslation board.
• Nikerabbit added a comment.Jun 6 2018, 3:33 PM

Error is same with production cxserver:

TypeError: Cannot read property 'attributes' of undefined
    at MWImage.<anonymous> (/srv/deployment/cxserver/deploy-cache/revs/8ce20bafd8a50dedfe379178c7969c5f58a14160/src/lib/translationunits/MWImage.js:91:46)
    at next (native)
    at resume (/srv/deployment/cxserver/deploy-cache/revs/8ce20bafd8a50dedfe379178c7969c5f58a14160/src/lib/util.js:277:21)
    at resumeNext (/srv/deployment/cxserver/deploy-cache/revs/8ce20bafd8a50dedfe379178c7969c5f58a14160/src/lib/util.js:287:26)

https://github.com/wikimedia/mediawiki-services-cxserver/blob/master/lib/translationunits/MWImage.js#L91

Probably easy to fix, but investigating why it happens for this particular case (e.g. if there is a bug elsewhere) can be more complicated.

KartikMistry moved this task from Backlog to Test Me on the User-KartikMistry board.Jun 6 2018, 4:14 PM
gerritbot subscribed.Jun 18 2018, 9:15 AM

Change 440832 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/services/cxserver@master] Don't fail on images which are not also links

https://gerrit.wikimedia.org/r/440832

gerritbot added a project: Patch-For-Review.Jun 18 2018, 9:15 AM
• Nikerabbit claimed this task.Jun 18 2018, 9:22 AM
• Nikerabbit triaged this task as Medium priority.
• Nikerabbit moved this task from Backlog to In Review on the Language-2018-Apr-June board.
gerritbot added a comment.Jun 19 2018, 6:40 AM

Change 440832 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Don't fail on images which are not also links

https://gerrit.wikimedia.org/r/440832

• Petar.petkovic removed a project: Patch-For-Review.Jun 20 2018, 5:51 AM
• Petar.petkovic moved this task from In Review to QA on the Language-2018-Apr-June board.
Arrbee edited projects, added CX-cxserver; removed ContentTranslation, ContentTranslation-CXserver.Jun 22 2018, 1:49 PM
Stashbot subscribed.Jun 25 2018, 12:26 PM

Mentioned in SAL (#wikimedia-operations) [2018-06-25T12:26:09Z] <kartik@deploy1001> Started deploy [cxserver/deploy@cc6dc61]: Update cxserver to ece5e7a (T191874, T196354, T195768, T195768)

Stashbot mentioned this in T196354: Enable MT for "Simple English" as if it was (regular) English.Jun 25 2018, 12:26 PM
Stashbot mentioned this in T195768: CX2: Red links appear in the source article.
Stashbot added a comment.Jun 25 2018, 12:29 PM

Mentioned in SAL (#wikimedia-operations) [2018-06-25T12:29:42Z] <kartik@deploy1001> Finished deploy [cxserver/deploy@cc6dc61]: Update cxserver to ece5e7a (T191874, T196354, T195768, T195768) (duration: 03m 33s)

Etonkovidova closed this task as Resolved.Jun 27 2018, 11:00 PM
• Nikerabbit moved this task from QA to Done on the Language-2018-Apr-June board.Jun 28 2018, 5:25 AM
• Nikerabbit moved this task from Backlog to Parsing and annotation on the CX-cxserver board.
KartikMistry closed subtask T191856: CX2-testing - 403 error for Yandex as Declined.Aug 14 2018, 11:21 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits