Page MenuHomePhabricator
Create Task
Maniphest T193132

CX2: Insert media autocomplete should use the translation page name instead of "Content Translation"
Closed, ResolvedPublic
Actions

Description

When users insert a new image in Content Translation, a media explorer panel is open, as it would do in VisualEditor. In order to show relevant results the search is prefilled with the name of the current page. In the case of Content Translation this results in the string "Content Translation" (or equivalent in the target language), showing images that are unrelated to the article being translated (as illustrated below). The title of the translation should be used instead.

Screen Shot 2018-04-26 at 12.39.09.png (733×1 px, 525 KB)

Details

SubjectRepoBranchLines +/-
Make page title the target titlemediawiki/extensions/VisualEditormaster+4 -4
ve.ui.MWMediaDialog.js: Change page title for Content Translationmediawiki/extensions/VisualEditormaster+4 -4
ve.ui.MWMediaDialog.js: Change page title for Content Translationmediawiki/extensions/VisualEditormaster+4 -4
ve.ui.MWMediaDialog.js: Change page title for Content Translationmediawiki/extensions/VisualEditormaster+36 -32
ve.ui.MWMediaDialog.js: Change page title for Content Translationmediawiki/extensions/VisualEditormaster+10 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Pginer-WMF triaged this task as Medium priority.Apr 26 2018, 10:42 AM
Pginer-WMF lowered the priority of this task from Medium to Low.
Pginer-WMF created this task.
Pginer-WMF added a project: Language-2018-Apr-June.
Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.Apr 26 2018, 3:50 PM
Pginer-WMF edited projects, added Language-2018-July-September; removed Language-2018-Apr-June.Jun 25 2018, 10:59 AM
• Vvjjkkii renamed this task from CX2: Insert media autocomplete should use the translation page name instead of "Content Translation" to j6daaaaaaa.Jul 1 2018, 1:13 AM
• Vvjjkkii raised the priority of this task from Low to High.
• Vvjjkkii added projects: CheckUser, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), Tamil-Sites, Gamepress, Hashtags, Jade, KartoEditor, Language-2018-Apr-June, New-Editor-Experiences, Mail, TCB-Team (now WMDE-TechWish).
• Vvjjkkii updated the task description. (Show Details)
• Vvjjkkii removed a subscriber: Aklapper.
Mainframe98 renamed this task from j6daaaaaaa to CX2: Insert media autocomplete should use the translation page name instead of "Content Translation".Jul 1 2018, 8:14 AM
Mainframe98 lowered the priority of this task from High to Low.
Mainframe98 removed projects: TCB-Team (now WMDE-TechWish), Mail, New-Editor-Experiences, Language-2018-Apr-June, KartoEditor, Jade, Hashtags, Gamepress, Tamil-Sites, Connected-Open-Heritage-Batch-uploads (RAÄ-KMB_1_2017-02), CheckUser.
Mainframe98 updated the task description. (Show Details)
Mainframe98 added a subscriber: Aklapper.
Pginer-WMF edited projects, added Language-2018-Oct-December; removed Language-2018-July-September.Sep 3 2018, 10:43 AM
Arrbee edited projects, added Language-Team (Language-2018-October-December); removed Language-2018-Oct-December.Oct 4 2018, 4:57 PM
Pginer-WMF edited projects, added Language-Team (Language-2019-January-March); removed Language-Team (Language-2018-October-December).Dec 27 2018, 11:13 AM
Pginer-WMF removed a project: Language-Team (Language-2019-January-March).Mar 29 2019, 9:58 PM
Pginer-WMF mentioned this in T206433: SVG Translate to integrate with Content Translation.Apr 3 2019, 9:41 AM
• Petar.petkovic mentioned this in T220440: GSoC 2019 Proposal: Integrate SVG Translate with Content Translation.Apr 20 2019, 12:59 AM
gerritbot added a comment.Jun 20 2019, 6:11 PM

Change 518101 had a related patch set uploaded (by Townie; owner: Townie):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMediaDialog.js: Change page title for Content Translation

https://gerrit.wikimedia.org/r/518101

gerritbot added a project: Patch-For-Review.Jun 20 2019, 6:11 PM
gerritbot added a comment.Jun 20 2019, 6:26 PM

Change 518105 had a related patch set uploaded (by Townie; owner: Townie):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMediaDialog.js: Change page title for Content Translation

https://gerrit.wikimedia.org/r/518105

gerritbot added a comment.Jun 21 2019, 9:18 AM

Change 518227 had a related patch set uploaded (by Townie; owner: Townie):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMediaDialog.js: Change page title for Content Translation

https://gerrit.wikimedia.org/r/518227

gerritbot added a comment.Jun 21 2019, 9:52 AM

Change 518105 abandoned by Townie:
ve.ui.MWMediaDialog.js: Change page title for Content Translation

Reason:
Moved to: rEVED2cb9346b59d8

https://gerrit.wikimedia.org/r/518105

gerritbot added a comment.Jun 21 2019, 9:55 AM

Change 518101 abandoned by Townie:
ve.ui.MWMediaDialog.js: Change page title for Content Translation

https://gerrit.wikimedia.org/r/518101

gerritbot added a comment.Jun 27 2019, 8:44 PM

Change 519516 had a related patch set uploaded (by Townie; owner: Townie):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMediaDialog.js: Change page title for Content Translation

https://gerrit.wikimedia.org/r/519516

gerritbot added a comment.Jun 27 2019, 9:00 PM

Change 519519 had a related patch set uploaded (by Townie; owner: Townie):
[mediawiki/extensions/VisualEditor@master] ve.ui.MWMediaDialog.js: Change page title for Content Translation

https://gerrit.wikimedia.org/r/519519

gerritbot added a comment.Jun 27 2019, 9:01 PM

Change 519519 abandoned by Townie:
ve.ui.MWMediaDialog.js: Change page title for Content Translation

Reason:
Duplicate

https://gerrit.wikimedia.org/r/519519

gerritbot added a comment.Jun 27 2019, 9:25 PM

Change 519516 abandoned by Townie:
ve.ui.MWMediaDialog.js: Change page title for Content Translation

Reason:
Duplicate, see Iafa84c05bea08ebb061ee6d1323eb50945b39815

https://gerrit.wikimedia.org/r/519516

gerritbot added a comment.Jul 15 2019, 7:08 PM

Change 518227 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Make page title the target title

https://gerrit.wikimedia.org/r/518227

matmarex closed this task as Resolved.Jul 15 2019, 7:10 PM
matmarex assigned this task to Townie.
Maintenance_bot removed a project: Patch-For-Review.Jul 15 2019, 7:11 PM
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 15 2019, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits