Example from Wikidata: this change competely broke (removed syntax, re-introduced typos...) the translated content. It looks like older revisions of translation units got loaded.
Description
Description
Details
Details
Customize query in gerrit
Event Timeline
Comment Actions
Another strange behavior: FuzzyBot refreshed content but also changed a translation where the content had already been updated.
Comment Actions
@Anomie I tracked this to this code in MessageCollection
if ( is_callable( Revision::class, 'getQueryInfo' ) ) {
$revQuery = Revision::getQueryInfo( [ 'page', 'text' ] );
} else {
$revQuery = [
'tables' => [ 'page', 'revision', 'text' ],
'fields' => [
'page_namespace',
'page_title',
'page_latest',
'rev_user',
'rev_user_text',
'old_flags',
'old_text'
],
'joins' => [
'revision' => [ 'JOIN', 'page_latest = rev_id' ],
'text' => [ 'JOIN', 'old_id = rev_text_id' ],
],
];
}
$conds = [];
$conds[] = $this->getTitleConds( $dbr );
$res = $dbr->select(
$revQuery['tables'], $revQuery['fields'], $conds, __METHOD__, [], $revQuery['joins']
);Revision::getQueryInfo does not include the condition 'page_latest = rev_id' and hence we might get random revision instead of the latest one. Is this a bug in Revision::getQueryInfo or did we forget to add that condition to that code path?
After fixing this we should run refresh-translatable-pages.php on all wikis.
Comment Actions
Change 434660 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Stop stale translations appearing on translation pages
Comment Actions
Change 434660 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Stop stale translations appearing on translation pages
Comment Actions
Change 434699 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@wmf/1.32.0-wmf.5] Stop stale translations appearing on translation pages
Comment Actions
Change 434700 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@wmf/1.32.0-wmf.4] Stop stale translations appearing on translation pages
Comment Actions
Change 434699 merged by jenkins-bot:
[mediawiki/extensions/Translate@wmf/1.32.0-wmf.5] Stop stale translations appearing on translation pages
Comment Actions
Change 434700 merged by jenkins-bot:
[mediawiki/extensions/Translate@wmf/1.32.0-wmf.4] Stop stale translations appearing on translation pages
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2018-05-23T17:45:10Z] <twentyafterfour@tin> Synchronized php-1.32.0-wmf.5/extensions/Translate/MessageCollection.php: syncing https://gerrit.wikimedia.org/r/#/c/434699/ refs T195347 (duration: 01m 20s)
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2018-05-23T17:47:09Z] <twentyafterfour@tin> Synchronized php-1.32.0-wmf.4/extensions/Translate/MessageCollection.php: syncing https://gerrit.wikimedia.org/r/#/c/434700/ refs T195347 (duration: 01m 19s)
Comment Actions
https://www.wikidata.org/w/index.php?title=Wikidata:News/cs&diff=prev&oldid=683956646
Pages will automatically heal themselves if they are edited. I'll probably plan the maintenance scripts to update all pages to be run next week. Leaving the task open for that.
Comment Actions
Change 436728 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] refresh-translatable-pages.php: add JobQueue option
Comment Actions
Change 436728 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] refresh-translatable-pages.php: add JobQueue option
Comment Actions
Script has been run for pretty much all wikis except metawiki and mediawikiwiki. I will attempt those two again next week with the updated script.
Comment Actions
This has now been done for all wikis. MetaWiki took about one hour with the updated script, which is really fast.
https://meta.wikimedia.org/w/index.php?title=Special:Contributions&limit=500&contribs=user&target=FuzzyBot&namespace=&tagfilter=&start=2018-06-13&end=2018-06-13 shows the changes. It looks there has been other bugs, mainly missing /en pages and the latest change to display fuzzy messages again, which had not been propagated to all pages yet, that are all nw fixed.