Page MenuHomePhabricator

Bug: Order of some paragraphs is flipped on mobile
Open, HighPublic5 Story Points

Description

Compare https://en.wikipedia.org/wiki/Arthur_Conan_Doyle and https://en.m.wikipedia.org/wiki/Arthur_Conan_Doyle. The two lead paragraphs are out of order on mobile, and the second paragraph appears above the infobox on small screens. There doesn't appear to be anything odd about the wikitext.

Report courtesy of jlebar on IRC.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2018, 5:10 AM
Niedzielski renamed this task from Order of some paragraphs is flipped on mobile to Bug: Order of some paragraphs is flipped on mobile.Aug 3 2018, 4:00 PM

The two lead paragraphs are out of order on mobile

@ovasileva, this seems important. Can we pull it in soon?

ovasileva triaged this task as High priority.Aug 3 2018, 4:34 PM

agreed, this is bad.

pmiazga added a subscriber: pmiazga.Aug 3 2018, 7:51 PM

That's a bug, most probably introduced in T199282, I'm on it

Cirdan added a subscriber: Cirdan.Aug 5 2018, 12:34 PM

Change 450533 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] When searching for lead paragraph, use context node instead of text()

https://gerrit.wikimedia.org/r/450533

Discussed this during standup today. We decided not to roll back the change currently and try to fix this. If we don't have a fix between now and Wednesday, Aug 8, it might be best to roll back the older change.

ovasileva set the point value for this task to 5.Aug 6 2018, 5:17 PM

Change 450533 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] When searching for lead paragraph, use context node instead of text()

https://gerrit.wikimedia.org/r/450533

Niedzielski reassigned this task from pmiazga to alexhollender.

@alexhollender, this is just a bug fix. Not sure if you want to check this out.

Unable to reproduce. Passing along to QA.

ABorbaWMF added a subscriber: ABorbaWMF.

Looks fixed to me on production.

Jdlrobson added a subscriber: Ryasmeen.
ovasileva closed this task as Resolved.Aug 21 2018, 8:02 AM

Looks good!

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptAug 21 2018, 8:02 AM
HairyDude reopened this task as Open.Mon, May 20, 1:00 AM
HairyDude added a subscriber: HairyDude.

I'm seeing this again at https://en.m.wikipedia.org/wiki/Surtsey .