Page MenuHomePhabricator
Create Task
Maniphest T201219

Enable phan-taint-check-plugin on all Wikimedia-deployed repositories after getting it to pass
Closed, ResolvedPublic
Actions

Description

The phan-taint-check-plugin has proven pretty reliable at spotting issues, and the rate of false positives has gone down significantly.

I'm going to enable this where it's currently passing.

Details

SubjectRepoBranchLines +/-
Configure phan-taint-check-pluginmediawiki/extensions/CategoryTreemaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/ContentTranslationmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/WikidataPageBannermaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/WikibaseQualityConstraintsmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Mathmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/PropertySuggestermaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Wikidata.orgmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/WikibaseQualitymaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/WikimediaBadgesmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/WikimediaEventsmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/TemplateDatamaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/UniversalLanguageSelectormaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Popupsmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/TextExtractsmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/UrlShortenermaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/PageImagesmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/QuickSurveysmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/ORESmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Kartographermaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Lintermaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/JADEmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/JsonConfigmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Graphmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/GuidedTourmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/GlobalCssJsmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/GlobalPreferencesmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/EventBusmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/ExtensionDistributormaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/ZeroPortalmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/EventLoggingmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/CommonsMetadatamaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/CodeMirrormaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/WikimediaMessagesmaster+0 -0
Configure phan-taint-check-pluginmediawiki/extensions/cldrmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/wikihieromaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/WikiLovemaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/VipsScalermaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/RelatedArticlesmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/UserMergemaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/TocTreemaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/SubpageSortkeymaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/ShortUrlmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/TemplateSandboxmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/TrustedXFFmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/SearchExtraNSmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Sentrymaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Quizmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/PoolCountermaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/PerformanceInspectormaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/ParsoidBatchAPImaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/XAnalyticsmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/SandboxLinkmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Josamaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/UploadsLinkmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/ReadingListsmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/ApiFeatureUsagemaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/CongressLookupmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Petitionmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/PagedTiffHandlermaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/NavigationTimingmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/MobileAppmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/NewUserMessagemaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/FileExportermaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/LdapAuthenticationmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/LandingCheckmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/LabeledSectionTransclusionmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/BounceHandlermaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Insidermaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/GlobalUserPagemaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/GlobalUsagemaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/GlobalBlockingmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/GeoCrumbsmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/GettingStartedmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Elasticamaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/FeaturedFeedsmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/intersectionmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/DoubleWikimaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/DynamicSidebarmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Capiuntomaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Disambiguatormaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Dashikimaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/DisableAccountmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/CreditsSourcemaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/AdvancedSearchmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Citoidmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/CharInsertmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Campaignsmaster+3 -0
Configure phan-taint-check-pluginmediawiki/extensions/Calendarmaster+3 -0
Enable phan-taint-check-plugin on some repos where it passesintegration/configmaster+87 -0
Show related patches Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedLegoktmT201219 Enable phan-taint-check-plugin on all Wikimedia-deployed repositories after getting it to pass
 ResolvedBawolffT201565 Phan error inside ThanksLogFormatter
 ResolvedsbassettT201794 phan-taint-check-plugin should ignore /extensions/ folder
 ResolvedReedyT221354 l10n-update on beta breaks due to: ExtensionDependencyError TranslationNotifications requires Translate to be installed.
 ResolvedLegoktmT202382 Make phan-taint-check-plugin voting for CirrusSearch extension
 ResolvedBawolffT202380 Add phan-taint-check-plugin to Scribunto extension
 DeclinedNoneT203217 convert scribunto's ustring maintenance scripts (e.g. make-normalization-table.php) to use MW's maintenance class
 ResolvedLegoktmT202389 Add phan-taint-check-plugin to Wikibase extension
 ResolvedDaimonaT189227 taint-checks for CentralAuth failing
 ResolvedBawolffT202372 Add phan-taint-check-plugin to CentralNotice extension
 ResolvedLegoktmT202377 Add phan-taint-check-plugin to CheckUser extension
 ResolvedBawolffT202379 Add phan-taint-check-plugin to Translate extension
 ResolvedBawolffT202371 Add phan-taint-check-plugin to TimedMediaHandler extension
 ResolvedBawolffT202365 Add phan-taint-check-plugin to SecurePoll extension
 ResolvedBawolffT202375 Add phan-taint-check-plugin to FlaggedRevs extension
 ResolvedBawolffT201811 Make Pager::getNavigationBar safe for phan-taint-check-plugin
 ResolvedLegoktmT202376 Add phan-taint-check-plugin to EducationProgram extension
 ResolvedBawolffT202373 Add phan-taint-check-plugin to Flow extension
 ResolvedLegoktmT202390 Add phan-taint-check-plugin to WikibaseLexeme extension
 ResolvedLegoktmT202388 Add phan-taint-check-plugin to VisualEditor extension
 DuplicateNoneT202384 Add phan-taint-check-plugin to DonationInterface extension
 ResolvedLegoktmT202385 Add phan-taint-check-plugin to FundraiserLandingPage extension
 ResolvedLegoktmT202386 Add phan-taint-check-plugin to FundraisingEmailUnsubscribe extension
 ResolvedLegoktmT202387 Add phan-taint-check-plugin to FundraisingTranslateWorkflow extension
 ResolvedBawolffT202383 Add phan-taint-check-plugin to Echo extension
 ResolvedBawolffT203843 Add phan-taint-check-plugin to SkinPerPage extension

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Aug 4 2018, 4:31 AM

Change 450380 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/UniversalLanguageSelector@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450380

gerritbot added a comment.Aug 4 2018, 4:32 AM

Change 450381 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/UserMerge@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450381

gerritbot added a comment.Aug 4 2018, 4:32 AM

Change 450382 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/VipsScaler@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450382

gerritbot added a comment.Aug 4 2018, 4:32 AM

Change 450383 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Wikidata.org@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450383

gerritbot added a comment.Aug 4 2018, 4:33 AM

Change 450384 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WikiLove@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450384

gerritbot added a comment.Aug 4 2018, 4:33 AM

Change 450385 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/wikihiero@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450385

gerritbot added a comment.Aug 4 2018, 4:33 AM

Change 450386 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WikimediaBadges@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450386

gerritbot added a comment.Aug 4 2018, 4:33 AM

Change 450387 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WikimediaEvents@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450387

gerritbot added a comment.Aug 4 2018, 4:33 AM

Change 450388 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WikimediaMessages@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450388

gerritbot added a comment.Aug 4 2018, 4:33 AM

Change 450389 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ZeroPortal@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450389

Legoktm mentioned this in rEQSa05c0e5ae371: Configure phan-taint-check-plugin.Aug 4 2018, 4:39 AM
gerritbot added a comment.Aug 4 2018, 4:54 AM

Change 450344 merged by jenkins-bot:
[mediawiki/extensions/MobileApp@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450344

gerritbot added a comment.Aug 4 2018, 4:54 AM

Change 450345 merged by jenkins-bot:
[mediawiki/extensions/FileExporter@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450345

gerritbot added a comment.Aug 4 2018, 4:56 AM

Change 450346 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450346

gerritbot added a comment.Aug 4 2018, 4:56 AM

Change 450347 merged by jenkins-bot:
[mediawiki/extensions/NewUserMessage@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450347

gerritbot added a comment.Aug 4 2018, 4:56 AM

Change 450348 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450348

gerritbot added a comment.Aug 4 2018, 4:56 AM

Change 450349 merged by jenkins-bot:
[mediawiki/extensions/PagedTiffHandler@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450349

gerritbot added a comment.Aug 4 2018, 4:56 AM

Change 450350 merged by jenkins-bot:
[mediawiki/extensions/PageImages@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450350

gerritbot added a comment.Aug 4 2018, 4:56 AM

Change 450351 merged by jenkins-bot:
[mediawiki/extensions/Petition@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450351

gerritbot added a comment.Aug 4 2018, 4:56 AM

Change 450352 merged by jenkins-bot:
[mediawiki/extensions/ApiFeatureUsage@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450352

gerritbot added a comment.Aug 4 2018, 4:56 AM

Change 450353 merged by jenkins-bot:
[mediawiki/extensions/CongressLookup@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450353

gerritbot added a comment.Aug 4 2018, 4:56 AM

Change 450354 merged by jenkins-bot:
[mediawiki/extensions/Josa@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450354

Legoktm mentioned this in rEULK877892120ee0: Configure phan-taint-check-plugin.Aug 4 2018, 5:05 AM
gerritbot added a comment.Aug 4 2018, 5:17 AM

Change 450356 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450356

gerritbot added a comment.Aug 4 2018, 5:17 AM

Change 450357 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450357

gerritbot added a comment.Aug 4 2018, 5:33 AM

Change 450358 merged by jenkins-bot:
[mediawiki/extensions/SandboxLink@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450358

gerritbot added a comment.Aug 4 2018, 5:33 AM

Change 450359 merged by jenkins-bot:
[mediawiki/extensions/UploadsLink@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450359

gerritbot added a comment.Aug 4 2018, 5:33 AM

Change 450360 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450360

gerritbot added a comment.Aug 4 2018, 6:18 AM

Change 450364 merged by jenkins-bot:
[mediawiki/extensions/XAnalytics@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450364

gerritbot added a comment.Aug 4 2018, 6:18 AM

Change 450365 merged by jenkins-bot:
[mediawiki/extensions/ParsoidBatchAPI@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450365

gerritbot added a comment.Aug 4 2018, 6:18 AM

Change 450366 merged by jenkins-bot:
[mediawiki/extensions/PerformanceInspector@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450366

gerritbot added a comment.Aug 4 2018, 6:24 AM

Change 450367 merged by jenkins-bot:
[mediawiki/extensions/PoolCounter@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450367

gerritbot added a comment.Aug 4 2018, 6:26 AM

Change 450368 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450368

gerritbot added a comment.Aug 4 2018, 6:28 AM

Change 450369 merged by jenkins-bot:
[mediawiki/extensions/Quiz@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450369

gerritbot added a comment.Aug 4 2018, 6:33 AM

Change 450370 merged by jenkins-bot:
[mediawiki/extensions/RelatedArticles@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450370

gerritbot added a comment.Aug 4 2018, 6:33 AM

Change 450371 merged by jenkins-bot:
[mediawiki/extensions/SearchExtraNS@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450371

gerritbot added a comment.Aug 4 2018, 6:33 AM

Change 450372 merged by jenkins-bot:
[mediawiki/extensions/Sentry@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450372

gerritbot added a comment.Aug 4 2018, 6:34 AM

Change 450373 merged by jenkins-bot:
[mediawiki/extensions/ShortUrl@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450373

gerritbot added a comment.Aug 4 2018, 6:35 AM

Change 450374 merged by jenkins-bot:
[mediawiki/extensions/SubpageSortkey@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450374

gerritbot added a comment.Aug 4 2018, 6:37 AM

Change 450375 merged by jenkins-bot:
[mediawiki/extensions/TemplateSandbox@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450375

gerritbot added a comment.Aug 4 2018, 6:38 AM

Change 450376 merged by jenkins-bot:
[mediawiki/extensions/TextExtracts@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450376

gerritbot added a comment.Aug 4 2018, 6:40 AM

Change 450377 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450377

gerritbot added a comment.Aug 4 2018, 6:41 AM

Change 450378 merged by jenkins-bot:
[mediawiki/extensions/TocTree@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450378

gerritbot added a comment.Aug 4 2018, 6:41 AM

Change 450379 merged by jenkins-bot:
[mediawiki/extensions/TrustedXFF@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450379

gerritbot added a comment.Aug 4 2018, 6:51 AM

Change 450380 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450380

gerritbot added a comment.Aug 4 2018, 6:51 AM

Change 450381 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450381

gerritbot added a comment.Aug 4 2018, 6:51 AM

Change 450382 merged by jenkins-bot:
[mediawiki/extensions/VipsScaler@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450382

gerritbot added a comment.Aug 4 2018, 7:00 AM

Change 450384 merged by jenkins-bot:
[mediawiki/extensions/WikiLove@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450384

gerritbot added a comment.Aug 4 2018, 7:00 AM

Change 450385 merged by jenkins-bot:
[mediawiki/extensions/wikihiero@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450385

gerritbot added a comment.Aug 4 2018, 7:25 AM

Change 450387 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450387

gerritbot added a comment.Aug 4 2018, 7:28 AM

Change 450388 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450388

gerritbot added a comment.Aug 4 2018, 7:37 AM

Change 450389 merged by jenkins-bot:
[mediawiki/extensions/ZeroPortal@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450389

gerritbot added a comment.Aug 6 2018, 10:37 AM

Change 450386 merged by jenkins-bot:
[mediawiki/extensions/WikimediaBadges@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450386

gerritbot added a comment.Aug 6 2018, 1:01 PM

Change 450362 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQuality@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450362

gerritbot added a comment.Aug 6 2018, 1:31 PM

Change 450383 merged by jenkins-bot:
[mediawiki/extensions/Wikidata.org@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450383

gerritbot added a comment.Aug 6 2018, 1:37 PM

Change 450343 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450343

gerritbot added a comment.Aug 6 2018, 2:04 PM

Change 450363 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450363

gerritbot added a comment.Aug 6 2018, 2:06 PM

Change 450361 merged by jenkins-bot:
[mediawiki/extensions/WikidataPageBanner@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450361

gerritbot added a comment.Aug 6 2018, 2:28 PM

Change 450355 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450355

gerritbot added a comment.Aug 6 2018, 2:31 PM

Change 450307 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450307

Legoktm closed this task as Resolved.Aug 7 2018, 4:18 AM

This round is done.

gerritbot added a comment.Aug 20 2018, 12:43 AM

Change 453890 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/CategoryTree@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/453890

gerritbot added a comment.Aug 20 2018, 1:04 AM

Change 453890 merged by jenkins-bot:
[mediawiki/extensions/CategoryTree@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/453890

ReleaseTaggerBot edited projects, added MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)); removed MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)).Aug 20 2018, 2:00 AM
Umherirrender added subtasks: T201565: Phan error inside ThanksLogFormatter, T201794: phan-taint-check-plugin should ignore /extensions/ folder, T202382: Make phan-taint-check-plugin voting for CirrusSearch extension, T202380: Add phan-taint-check-plugin to Scribunto extension, T202389: Add phan-taint-check-plugin to Wikibase extension, T189227: taint-checks for CentralAuth failing, T202372: Add phan-taint-check-plugin to CentralNotice extension, T202377: Add phan-taint-check-plugin to CheckUser extension, T202379: Add phan-taint-check-plugin to Translate extension, T202371: Add phan-taint-check-plugin to TimedMediaHandler extension, T202365: Add phan-taint-check-plugin to SecurePoll extension, T202375: Add phan-taint-check-plugin to FlaggedRevs extension, T202376: Add phan-taint-check-plugin to EducationProgram extension, T202373: Add phan-taint-check-plugin to Flow extension, T202390: Add phan-taint-check-plugin to WikibaseLexeme extension, T202388: Add phan-taint-check-plugin to VisualEditor extension, T202384: Add phan-taint-check-plugin to DonationInterface extension, T202385: Add phan-taint-check-plugin to FundraiserLandingPage extension, T202386: Add phan-taint-check-plugin to FundraisingEmailUnsubscribe extension, T202387: Add phan-taint-check-plugin to FundraisingTranslateWorkflow extension, T202383: Add phan-taint-check-plugin to Echo extension.Aug 21 2018, 12:40 PM
Umherirrender closed subtask T202387: Add phan-taint-check-plugin to FundraisingTranslateWorkflow extension as Resolved.Aug 22 2018, 8:22 AM
Legoktm reopened this task as Open.Aug 23 2018, 5:23 PM
Legoktm closed subtask T202388: Add phan-taint-check-plugin to VisualEditor extension as Resolved.Aug 25 2018, 4:52 AM
Legoktm closed subtask T202390: Add phan-taint-check-plugin to WikibaseLexeme extension as Resolved.Aug 25 2018, 5:22 AM
Legoktm closed subtask T202382: Make phan-taint-check-plugin voting for CirrusSearch extension as Resolved.Aug 30 2018, 7:14 AM
Legoktm closed subtask T202377: Add phan-taint-check-plugin to CheckUser extension as Resolved.
Bawolff awarded a token.Aug 30 2018, 12:13 PM
Legoktm closed subtask T202380: Add phan-taint-check-plugin to Scribunto extension as Resolved.Sep 1 2018, 5:11 AM
Legoktm closed subtask T202385: Add phan-taint-check-plugin to FundraiserLandingPage extension as Resolved.Sep 1 2018, 5:22 AM
Legoktm closed subtask T202379: Add phan-taint-check-plugin to Translate extension as Resolved.Sep 1 2018, 7:18 AM
Legoktm closed subtask T202376: Add phan-taint-check-plugin to EducationProgram extension as Resolved.Sep 1 2018, 10:20 PM
Legoktm closed subtask T201565: Phan error inside ThanksLogFormatter as Resolved.Sep 6 2018, 5:53 AM
Umherirrender added a subtask: T203843: Add phan-taint-check-plugin to SkinPerPage extension.Sep 7 2018, 8:17 PM
Legoktm closed subtask T203843: Add phan-taint-check-plugin to SkinPerPage extension as Resolved.Sep 8 2018, 3:40 AM
Legoktm closed subtask T202389: Add phan-taint-check-plugin to Wikibase extension as Resolved.Sep 8 2018, 3:43 AM
Legoktm closed subtask T202375: Add phan-taint-check-plugin to FlaggedRevs extension as Resolved.
Legoktm closed subtask T202371: Add phan-taint-check-plugin to TimedMediaHandler extension as Resolved.
Legoktm closed subtask T202386: Add phan-taint-check-plugin to FundraisingEmailUnsubscribe extension as Resolved.Sep 9 2018, 2:38 AM
Legoktm closed subtask T202373: Add phan-taint-check-plugin to Flow extension as Resolved.Sep 14 2018, 6:15 AM
Legoktm closed subtask T202383: Add phan-taint-check-plugin to Echo extension as Resolved.
Legoktm closed subtask T202372: Add phan-taint-check-plugin to CentralNotice extension as Resolved.Sep 14 2018, 6:25 AM
Legoktm closed subtask T202365: Add phan-taint-check-plugin to SecurePoll extension as Resolved.Sep 17 2018, 12:16 AM
Bawolff moved this task from Backlog to Other codebases on the phan-taint-check-plugin board.Feb 17 2019, 12:28 PM
Bawolff moved this task from Other codebases to Wikimedia deployed on the phan-taint-check-plugin board.
Jdforrester-WMF closed subtask T189227: taint-checks for CentralAuth failing as Resolved.Jul 15 2019, 6:15 PM
Legoktm mentioned this in rESRD4b8668780c4f: Configure phan-taint-check-plugin.Jul 27 2019, 11:18 PM
hashar closed subtask T201794: phan-taint-check-plugin should ignore /extensions/ folder as Resolved.Aug 27 2019, 12:37 PM
Jdforrester-WMF renamed this task from Enable phan-taint-check-plugin on all Wikimedia-deployed repositories where it is currently passing to Enable phan-taint-check-plugin on all Wikimedia-deployed repositories after getting it to pass.Nov 10 2019, 5:02 PM
Daimona closed this task as Resolved.Jul 3 2020, 10:29 AM
Daimona subscribed.

Given that all subtasks are resolved, I'm also calling this resolved. Moreover, taint-check is now included in mediawiki-phan-config, which is already sort of mandatory for deployed code (T250038).

Daimona moved this task from Wikimedia deployed to Enabling on new repos on the phan-taint-check-plugin board.Oct 15 2022, 4:53 PM
Umherirrender mentioned this in rEPSe4a2938a665d: Configure phan-taint-check-plugin.May 25 2023, 6:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL