Page MenuHomePhabricator

Enable phan-taint-check-plugin on all Wikimedia-deployed repositories where it is currently passing
Open, Needs TriagePublic

Description

The phan-taint-check-plugin has proven pretty reliable at spotting issues, and the rate of false positives has gone down significantly.

I'm going to enable this where it's currently passing.

Related Objects

StatusAssignedTask
OpenLegoktm
ResolvedBawolff
OpenNone
ResolvedReedy
ResolvedLegoktm
ResolvedBawolff
DeclinedNone
ResolvedLegoktm
OpenNone
ResolvedBawolff
ResolvedLegoktm
ResolvedBawolff
ResolvedBawolff
ResolvedBawolff
ResolvedBawolff
ResolvedBawolff
ResolvedLegoktm
ResolvedBawolff
ResolvedLegoktm
ResolvedLegoktm
OpenNone
ResolvedLegoktm
ResolvedLegoktm
ResolvedLegoktm
ResolvedBawolff
ResolvedBawolff

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 450370 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/RelatedArticles@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450370

Change 450371 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/SearchExtraNS@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450371

Change 450372 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Sentry@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450372

Change 450373 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ShortUrl@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450373

Change 450374 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/SubpageSortkey@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450374

Change 450375 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/TemplateSandbox@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450375

Change 450376 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/TextExtracts@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450376

Change 450377 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/TemplateData@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450377

Change 450378 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/TocTree@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450378

Change 450379 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/TrustedXFF@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450379

Change 450380 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/UniversalLanguageSelector@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450380

Change 450381 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/UserMerge@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450381

Change 450382 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/VipsScaler@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450382

Change 450383 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Wikidata.org@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450383

Change 450384 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WikiLove@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450384

Change 450385 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/wikihiero@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450385

Change 450386 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WikimediaBadges@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450386

Change 450387 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WikimediaEvents@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450387

Change 450388 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/WikimediaMessages@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450388

Change 450389 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/ZeroPortal@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450389

Change 450344 merged by jenkins-bot:
[mediawiki/extensions/MobileApp@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450344

Change 450345 merged by jenkins-bot:
[mediawiki/extensions/FileExporter@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450345

Change 450346 merged by jenkins-bot:
[mediawiki/extensions/NavigationTiming@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450346

Change 450347 merged by jenkins-bot:
[mediawiki/extensions/NewUserMessage@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450347

Change 450348 merged by jenkins-bot:
[mediawiki/extensions/ORES@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450348

Change 450349 merged by jenkins-bot:
[mediawiki/extensions/PagedTiffHandler@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450349

Change 450350 merged by jenkins-bot:
[mediawiki/extensions/PageImages@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450350

Change 450351 merged by jenkins-bot:
[mediawiki/extensions/Petition@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450351

Change 450352 merged by jenkins-bot:
[mediawiki/extensions/ApiFeatureUsage@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450352

Change 450353 merged by jenkins-bot:
[mediawiki/extensions/CongressLookup@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450353

Change 450354 merged by jenkins-bot:
[mediawiki/extensions/Josa@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450354

Change 450356 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450356

Change 450357 merged by jenkins-bot:
[mediawiki/extensions/ReadingLists@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450357

Change 450358 merged by jenkins-bot:
[mediawiki/extensions/SandboxLink@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450358

Change 450359 merged by jenkins-bot:
[mediawiki/extensions/UploadsLink@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450359

Change 450360 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450360

Change 450364 merged by jenkins-bot:
[mediawiki/extensions/XAnalytics@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450364

Change 450365 merged by jenkins-bot:
[mediawiki/extensions/ParsoidBatchAPI@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450365

Change 450366 merged by jenkins-bot:
[mediawiki/extensions/PerformanceInspector@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450366

Change 450367 merged by jenkins-bot:
[mediawiki/extensions/PoolCounter@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450367

Change 450368 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450368

Change 450369 merged by jenkins-bot:
[mediawiki/extensions/Quiz@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450369

Change 450370 merged by jenkins-bot:
[mediawiki/extensions/RelatedArticles@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450370

Change 450371 merged by jenkins-bot:
[mediawiki/extensions/SearchExtraNS@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450371

Change 450372 merged by jenkins-bot:
[mediawiki/extensions/Sentry@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450372

Change 450373 merged by jenkins-bot:
[mediawiki/extensions/ShortUrl@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450373

Change 450374 merged by jenkins-bot:
[mediawiki/extensions/SubpageSortkey@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450374

Change 450375 merged by jenkins-bot:
[mediawiki/extensions/TemplateSandbox@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450375

Change 450376 merged by jenkins-bot:
[mediawiki/extensions/TextExtracts@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450376

Change 450377 merged by jenkins-bot:
[mediawiki/extensions/TemplateData@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450377

Change 450378 merged by jenkins-bot:
[mediawiki/extensions/TocTree@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450378

Change 450379 merged by jenkins-bot:
[mediawiki/extensions/TrustedXFF@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450379

Change 450380 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450380

Change 450381 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450381

Change 450382 merged by jenkins-bot:
[mediawiki/extensions/VipsScaler@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450382

Change 450384 merged by jenkins-bot:
[mediawiki/extensions/WikiLove@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450384

Change 450385 merged by jenkins-bot:
[mediawiki/extensions/wikihiero@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450385

Change 450387 merged by jenkins-bot:
[mediawiki/extensions/WikimediaEvents@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450387

Change 450388 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMessages@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450388

Change 450389 merged by jenkins-bot:
[mediawiki/extensions/ZeroPortal@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450389

Change 450386 merged by jenkins-bot:
[mediawiki/extensions/WikimediaBadges@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450386

Change 450362 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQuality@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450362

Change 450383 merged by jenkins-bot:
[mediawiki/extensions/Wikidata.org@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450383

Change 450343 merged by jenkins-bot:
[mediawiki/extensions/Math@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450343

Change 450363 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450363

Change 450361 merged by jenkins-bot:
[mediawiki/extensions/WikidataPageBanner@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450361

Change 450355 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450355

Change 450307 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/450307

Legoktm closed this task as Resolved.Aug 7 2018, 4:18 AM

This round is done.

Change 453890 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/CategoryTree@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/453890

Change 453890 merged by jenkins-bot:
[mediawiki/extensions/CategoryTree@master] Configure phan-taint-check-plugin

https://gerrit.wikimedia.org/r/453890

Legoktm reopened this task as Open.Aug 23 2018, 5:23 PM