Page MenuHomePhabricator
Create Task
Maniphest T206462

Transition Gruntfile.js tasks to NPM scripts (Popups, MinervaNeue)
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

This task encompasses the work to start transitioning Gruntfile.js tasks to package.json in both MinervaNeue and Popups repos. This task covers all simple transitions such as ESLint and creating tasks for what remains. Delete any relevant dependencies as you go and see MobileFrontend for reference (T206069).

Before working on this, it is recommended to read through T206069, particularly around motivations and the patches that got merged. Apply the change logic to the Popups and Minerva repositories.

Checklist of things to fix for each repo

  • eslint is not using grunt
  • stylelint is not using grunt
  • jsonlint is not using grunt
  • banana-checker is not using grunt
  • grunt, grunt-contrib-watch and grunt-notify is removed from codebase

Details

SubjectRepoBranchLines +/-
build: Replace Grunt tasks with npm scripts for eslint, stylelint, banana-checker & svgo.mediawiki/extensions/Popupsmaster+125 -829
build: Replace Grunt tasks with npm scripts for eslint, stylelint, banana-checker & svgo.mediawiki/extensions/Popupsmaster+23 K -23 K
build: Replace Grunt with npm scripts for eslint, stylelint, and banana-checkermediawiki/skins/MinervaNeuemaster+2 K -3 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Niedzielski created this task.Oct 8 2018, 2:27 PM
Restricted Application changed the subtype of this task from "Deadline" to "Task". · View Herald TranscriptOct 8 2018, 2:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.Oct 8 2018, 5:23 PM
Jdlrobson updated the task description. (Show Details)Oct 8 2018, 8:40 PM
Jdlrobson moved this task from Needs Prioritization to Triaged but Future on the Web-Team-Backlog board.
Jdlrobson subscribed.

It might make sense to estimate this only after the precursory task has been completed.

Jdlrobson changed the task status from Open to Stalled.Dec 12 2018, 6:30 PM

Stalled on T206069

Jdlrobson mentioned this in T206069: Transition Gruntfile.js tasks to NPM scripts (MobileFrontend).Dec 12 2018, 6:30 PM
Ricordisamoa subscribed.Sep 2 2019, 9:36 AM
• Demian added a parent task: T246321: [EPIC] Transition Gruntfile.js tasks to NPM scripts in some projects.Feb 27 2020, 9:09 AM
• Demian mentioned this in T246321: [EPIC] Transition Gruntfile.js tasks to NPM scripts in some projects.Feb 27 2020, 9:50 AM
Aklapper changed the task status from Stalled to Open.Nov 8 2020, 2:09 PM
In T206462#4818002, @Jdlrobson wrote:

Stalled on T206069

That task has been resolved in the meantime, hence resetting task status here

Restricted Application added a subscriber: Masumrezarock100. · View Herald TranscriptNov 8 2020, 2:09 PM
Jdlrobson added a project: patch-welcome.Nov 18 2020, 5:59 PM
Jdlrobson added a project: good first task.
Jdlrobson updated the task description. (Show Details)
bwang subscribed.Apr 1 2021, 9:21 PM
bwang claimed this task.Apr 6 2021, 2:56 PM
bwang set the point value for this task to 2.Apr 6 2021, 5:44 PM
bwang changed the point value for this task from 2 to 3.Apr 7 2021, 7:42 PM
bwang reassigned this task from bwang to Edtadros.Apr 7 2021, 9:49 PM
bwang claimed this task.
bwang moved this task from Triaged but Future to QA Tasks / Needs Reproduction on the Web-Team-Backlog board.
bwang moved this task from QA Tasks / Needs Reproduction to Kanbanana-FY-2020-21 on the Web-Team-Backlog board.
bwang edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.
bwang moved this task from Needs Analysis to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
bwang added a subscriber: Edtadros.
gerritbot added a comment.Apr 8 2021, 2:25 PM

Change 677914 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/Popups@master] Replace grunt tasks with npm scripts for eslint, stylelint, banana-checker, svgo

https://gerrit.wikimedia.org/r/677914

gerritbot added a project: Patch-For-Review.Apr 8 2021, 2:25 PM

Change 677608 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] Add npm scripts for eslint, stylelint, and banana-checker

https://gerrit.wikimedia.org/r/677608

bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 8 2021, 7:27 PM
bwang removed bwang as the assignee of this task.Apr 13 2021, 5:28 PM
Jdrewniak claimed this task.Apr 13 2021, 5:29 PM
bwang claimed this task.Apr 13 2021, 5:33 PM
bwang moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
bwang added a subscriber: Jdrewniak.
gerritbot added a comment.Apr 13 2021, 9:09 PM

Change 677608 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/MinervaNeue@master] build: Replace Grunt with npm scripts for eslint, stylelint, and banana-checker

https://gerrit.wikimedia.org/r/677608

gerritbot added a comment.Apr 14 2021, 3:57 PM

Change 677608 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] build: Replace Grunt with npm scripts for eslint, stylelint, and banana-checker

https://gerrit.wikimedia.org/r/677608

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 14 2021, 4:00 PM
Jdlrobson removed bwang as the assignee of this task.Apr 15 2021, 1:34 AM
Jdlrobson moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
Jdlrobson moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
LGoto assigned this task to Jdlrobson.Apr 15 2021, 5:11 PM
Jdlrobson removed Jdlrobson as the assignee of this task.Apr 19 2021, 11:20 PM
Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
bwang claimed this task.Apr 20 2021, 5:08 PM
Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 20 2021, 11:12 PM
gerritbot added a comment.Apr 21 2021, 4:38 PM

Change 681716 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/extensions/Popups@master] build: Replace Grunt tasks with npm scripts for eslint, stylelint, banana-checker & svgo.

https://gerrit.wikimedia.org/r/681716

gerritbot added a comment.Apr 21 2021, 6:44 PM

Change 677914 abandoned by Bernard Wang:

[mediawiki/extensions/Popups@master] build: Replace Grunt tasks with npm scripts for eslint, stylelint, banana-checker & svgo.

Reason:

Replacing this patch with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/ /681716

https://gerrit.wikimedia.org/r/677914

bwang removed bwang as the assignee of this task.Apr 21 2021, 8:01 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Apr 21 2021, 11:48 PM

Change 681716 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] build: Replace Grunt tasks with npm scripts for eslint, stylelint, banana-checker & svgo.

https://gerrit.wikimedia.org/r/681716

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Apr 21 2021, 11:50 PM

I think everything here is done?

Jdlrobson closed this task as Resolved.Apr 22 2021, 8:05 PM
Jdlrobson claimed this task.
Jdlrobson mentioned this in T284695: Don't use Gruntfile in QuickSurveys extension.Jun 9 2021, 8:20 PM
Jdlrobson mentioned this in T286832: Remove use of Grunt in RelatedArticles extension.Jul 16 2021, 10:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits