Page MenuHomePhabricator
Create Task
Maniphest T208366

JS fatal in VE from ve.ui.DesktopContext.prototype.updateDimensions
Closed, ResolvedPublic
Actions

Description

Gah.

Trivial reproduction:

Related Objects
Search...

Event Timeline

Jdforrester-WMF triaged this task as Unbreak Now! priority.Oct 30 2018, 10:23 PM
Jdforrester-WMF created this task.
Restricted Application changed the subtype of this task from "Release" to "Task". · View Herald TranscriptOct 30 2018, 10:23 PM
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald Transcript
Jdforrester-WMF updated the task description. (Show Details)Oct 30 2018, 10:24 PM
Esanders added subscribers: dchan, Esanders.Oct 30 2018, 10:29 PM

ping @dchan

gerritbot mentioned this in T208228: DM Selections should not cache document model data.Oct 30 2018, 10:30 PM
Jdforrester-WMF added a comment.EditedOct 30 2018, 10:30 PM

Working on this now; note this is distinct from T208347.

Spotted when back-porting the fixes for Citoid and CX, now abandoned:

Stashbot subscribed.Oct 30 2018, 10:38 PM

Mentioned in SAL (#wikimedia-operations) [2018-10-30T22:38:16Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.2/extensions/VisualEditor/: Hot-deploy UBN train blocker VisualEditor bug T208366 (duration: 00m 56s)

Jdforrester-WMF claimed this task.Oct 30 2018, 10:41 PM
Jdforrester-WMF moved this task from Incoming to QA on the VisualEditor (Current work) board.
Jdforrester-WMF added projects: VisualEditor-MediaWiki, VisualEditor-ContentEditable.

De-prioritising as the train is unblocked now.

matmarex closed this task as Resolved.Oct 31 2018, 12:19 AM
matmarex merged a task: T208358: Adding link leads to jQuery.Deferred exception: startingSelection.getDocument is not a function TypeError: startingSelection.getDocument is not a function.
matmarex added a subscriber: Jdlrobson.
matmarex subscribed.

(I'm closing this task, contrary to our usual practice in VisualEditor, so that folks looking at T206656 can tell that it's not a blocker, since this is the usual practice for release blockers.)

Liuxinyu970226 unsubscribed.Nov 2 2018, 5:04 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL