@TBolliger What if you've added one or two pages and then you start typing a third, and click Submit should it accept that text or no?

In T208507#4713376, @dbarratt wrote:

@TBolliger What if you've added one or two pages and then you start typing a third, and click Submit should it accept that text or no?

Yes, it should accept that text. Whatever solution we decide should work for the first input or the Nth input.

Let's say it's the 11th, in that case it would either warn or auto-accept and display the "maximum of 10" error message that already exists.

My personal opinion is that this input should DWIM and accept the text as if it has been submitted. If it is invalid (e.g. the page does not exist or it is the 11th entry) we have other error messages to display.

I reckon this is OOUI territory but it seems like we'd need to decide what action/character means you are done with that item. Spaces won't work because pages have spaces in the name, right? Some apps that do this with tags use the comma as a signal. At any rate, blurring the field should submit these at a minimum.

In T208507#4713442, @aezell wrote:

I reckon this is OOUI territory but it seems like we'd need to decide what action/character means you are done with that item. Spaces won't work because pages have spaces in the name, right? Some apps that do this with tags use the comma as a signal. At any rate, blurring the field should submit these at a minimum.

Good question, Alex. I would say we should start small and accept their exact input as one submission. In other words, treat spaces and commas as parts of the page name. e.g. if they type George Washington to accept it as George Washington and Omaha, Nebraska as Omaha, Nebraska.

In T208507#4714264, @TBolliger wrote:

In T208507#4713442, @aezell wrote:

I reckon this is OOUI territory but it seems like we'd need to decide what action/character means you are done with that item. Spaces won't work because pages have spaces in the name, right? Some apps that do this with tags use the comma as a signal. At any rate, blurring the field should submit these at a minimum.

Good question, Alex. I would say we should start small and accept their exact input as one submission. In other words, treat spaces and commas as parts of the page name. e.g. if they type George Washington to accept it as George Washington and Omaha, Nebraska as Omaha, Nebraska.

IMO, the only good solution to this is to use the return key.

Return key for users who prefer the keyboard, or click on the drop-down suggestion for users who prefer a mouse/tapping.

The problem with the dropdown — which is a different bag entirely — is the lag that occurs when the pagename is short and/or the user is really fast.

This is OOUI territory indeed — T188886: TagMultiSelectWidget misleadingly leaves uncommitted input text visible when unfocused

I agree with @TBolliger's idea of DWIM - we should make it as if the user pressed enter when they tab out or lose focus of this widget (https://gerrit.wikimedia.org/r/421815).

Sounds good @Prtksxna !

In estimation today, we should determine what we should do with both this ticket and T188886 — same fix? different? should we fix both?

FYI, see this task with a discussion of what is the best UX; it's not completely straight forward what the best solution is for the widget: T188886: TagMultiSelectWidget misleadingly leaves uncommitted input text visible when unfocused

We can find a specific fix for this specific use case if needed, though the ideal would be fixing the widget in general. The widget, though, needs to be generalized, and I'm not sure we can completely generalize the expectations here across uses. See the discussion on that ticket.

Change 471368 had a related patch set uploaded (by Mooeypoo; owner: Mooeypoo):
[oojs/ui@master] TagMultiselectWidget: Make widget invalid if there's text in input

https://gerrit.wikimedia.org/r/471368

Change 471368 merged by jenkins-bot:
[oojs/ui@master] TagMultiselectWidget: Make widget invalid if there's text in input

https://gerrit.wikimedia.org/r/471368

Change 472080 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.29.4

https://gerrit.wikimedia.org/r/472080

Change 472080 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.29.4

https://gerrit.wikimedia.org/r/472080

Works like a dream! Great work @Mooeypoo @Tchanders @Volker_E !!