Maniphest T208785

Closing the search mode menu in basic search
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• PDrouin-WMF
	Nov 5 2018, 8:47 PM

Description

User should be able to close the search mode menu (Keywords/Depicts/Other statements) one of two ways:

clicking anywhere outside that menu
using the Escape key

Currently, clicking anywhere outside the search mode menu works for Keywords only and the escape key works for no mode.

Details

	Subject	Repo	Branch	Lines +/-
	Search prototype	mediawiki/extensions/WikibaseMediaInfo	master	+1 K -14

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
Open		None	T115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
Duplicate		None	T115864 Figure out if the description of the image can be used as the caption on-wiki
Open	Feature	None	T53032 When inserting an image, set its caption by default to be the Commons image description
Open	Feature	None	T39534 Wikimedia Commons should support searching by color
Duplicate		None	T39535 Wikimedia Commons should support filtering by color
Resolved		None	T19503 Provide metadata support on Wikimedia Commons
Resolved		None	T51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
Resolved		None	T68108 [Epic] Store media information for files on Wikimedia Commons as structured data
Resolved		• Ramsey-WMF	T199352 Deploy Structured Data on Commons with arbitrary Statements
Resolved		None	T215305 "Depicts and other statements on a bicycle": Qualifiers, and search by depicts statements, and other statements
Resolved		• Ramsey-WMF	T199120 Build search/depicts prototype
Resolved		matthiasmullie	T208785 Closing the search mode menu in basic search

Event Timeline

• PDrouin-WMF created this task.Nov 5 2018, 8:47 PM

Restricted Application added a project: Multimedia. · View Herald TranscriptNov 5 2018, 8:47 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Ramsey-WMF triaged this task as Medium priority.Nov 8 2018, 10:07 PM

• Ramsey-WMF moved this task from Untriaged to Triaged on the Multimedia board.

Change 441040 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Search prototype

https://gerrit.wikimedia.org/r/441040

gerritbot added a project: Patch-For-Review.Dec 17 2018, 1:51 PM

matthiasmullie mentioned this in rEWBI0114d1ec3cd8: Search prototype.Dec 17 2018, 1:53 PM

I'm not currently able to close the mode toggle using the Escape key on my machine.
And (unless I misunderstood) I'm not sure it should be possible to close the input mode toggle with Escape: the input field will still have focus after having hit Escape, so it wouldn't be possible to bring back the toggle until the user first focuses something else and then re-focuses the input.

I did change things so that clicking outside the input (= input loses focus), the search mode toggle is now hidden consistently, in all input modes.

matthiasmullie mentioned this in rEWBI5584a2a5b021: Search prototype.Jan 2 2019, 12:20 PM

matthiasmullie mentioned this in rEWBIc7a9c401d88d: Search prototype.Jan 2 2019, 12:34 PM

matthiasmullie mentioned this in rEWBI27a639eea6bd: Search prototype.Jan 2 2019, 4:00 PM

matthiasmullie mentioned this in rEWBI167bbc7b0218: Search prototype.Jan 7 2019, 10:23 AM

matthiasmullie mentioned this in rEWBIfb6135afb021: Search prototype.Jan 7 2019, 10:47 AM

matthiasmullie mentioned this in rEWBI55e6a1ff10a3: Search prototype.Jan 7 2019, 11:31 AM

matthiasmullie mentioned this in rEWBIe45a8604525d: Search prototype.Jan 7 2019, 11:59 AM

Jdforrester-WMF added a parent task: T199352: Deploy Structured Data on Commons with arbitrary Statements.Jan 10 2019, 5:55 PM

matthiasmullie mentioned this in rEWBI049e631c36c7: Search prototype.Jan 10 2019, 6:23 PM

matthiasmullie mentioned this in rEWBIbbda7a9bc768: Search prototype.Jan 14 2019, 5:01 PM

matthiasmullie mentioned this in rEWBI1bae3feaaef6: Search prototype.Jan 15 2019, 4:17 PM

matthiasmullie mentioned this in rEWBI2537496a27a4: Search prototype.Jan 16 2019, 3:05 PM

matthiasmullie mentioned this in rEWBI3e7990197255: Search prototype.Jan 16 2019, 5:25 PM

Jdforrester-WMF edited parent tasks, added: T199120: Build search/depicts prototype; removed: T199352: Deploy Structured Data on Commons with arbitrary Statements.Feb 5 2019, 7:33 PM

This was feedback on a WIP patch that has been updated to reflect this feedback. Closing.

matthiasmullie mentioned this in rEWBI82c2d1f2dc90: [WIP] Search prototype.Feb 28 2019, 2:22 PM

matthiasmullie mentioned this in rEWBI89f05f6c1619: [WIP] Search prototype.Mar 7 2019, 5:21 PM

matthiasmullie mentioned this in rEWBI6f357d2e5ff7: [WIP] Search prototype.Mar 8 2019, 3:42 PM

matthiasmullie mentioned this in rEWBI8dfab8e30038: [WIP] Search prototype.Mar 8 2019, 5:13 PM

matthiasmullie mentioned this in rEWBI1eaaa887e07e: [WIP] Search prototype.Mar 8 2019, 7:38 PM

matthiasmullie mentioned this in rEWBI083440765be8: [WIP] Search prototype.Mar 8 2019, 7:42 PM

matthiasmullie mentioned this in rEWBIbec0bca7a378: Search prototype.Mar 12 2019, 11:39 AM

matthiasmullie mentioned this in rEWBIbc9944b4e074: Search prototype.Mar 13 2019, 3:59 PM

matthiasmullie mentioned this in rEWBIf72d12606a03: Search prototype.Mar 14 2019, 10:04 AM

matthiasmullie mentioned this in rEWBId56946fa2ce1: Search prototype.Mar 14 2019, 12:51 PM

matthiasmullie mentioned this in rEWBIbfd45d50a71e: Search prototype.Mar 14 2019, 3:24 PM

matthiasmullie mentioned this in rEWBI38dc1ca1e3b2: Search prototype.Mar 18 2019, 11:05 AM

matthiasmullie mentioned this in rEWBI4fdf7d57c287: Search prototype.Mar 18 2019, 11:15 AM

matthiasmullie mentioned this in rEWBI6fd13c38df33: Search prototype.Mar 18 2019, 11:35 AM

matthiasmullie mentioned this in rEWBI810e044919ff: Search prototype.Mar 18 2019, 4:00 PM

Change 441040 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Search prototype

https://gerrit.wikimedia.org/r/441040

matthiasmullie mentioned this in rEWBI628ec6fb63ab: Search prototype.Mar 21 2019, 12:23 AM

matthiasmullie mentioned this in rEWBI71b81f98b4e6: Search prototype.

matthiasmullie mentioned this in rEWBI4f20379e90a6: Search prototype.

matthiasmullie mentioned this in rEWBI9fbbee31916c: Search prototype.

matthiasmullie mentioned this in rEWBI1e53fa909b02: Search prototype.

matthiasmullie mentioned this in rEWBI929b5fc8b155: Search prototype.

matthiasmullie mentioned this in rEWBIf00fc630f5bf: Search prototype.

matthiasmullie mentioned this in rEWBIdf4e9bcf2b0a: Search prototype.

Change 441040 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Search prototype

https://gerrit.wikimedia.org/r/441040