Page MenuHomePhabricator
Create Task
Maniphest T210617

BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: W-60bApAIC8AACwmGvkAAABH

message
[W-60bApAIC8AACwmGvkAAABH] /wiki/Q499158   BadMethodCallException from line 81 of /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/ParserOutput/GlobeCoordinateKartographerDataUpdater.php: Call to a member function getJsConfigVars() on a non-object (null)
trace
/srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/ParserOutput/GlobeCoordinateKartographerDataUpdater.php:81
#0 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/ParserOutput/EntityStatementDataUpdaterAdapter.php(32): Wikibase\Repo\ParserOutput\GlobeCoordinateKartographerDataUpdater->updateParserOutput(ParserOutput)
#1 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/ParserOutput/EntityParserOutputDataUpdaterCollection.php(45): Wikibase\Repo\ParserOutput\EntityStatementDataUpdaterAdapter->updateParserOutput(ParserOutput)
#2 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/ParserOutput/EntityParserOutputGenerator.php(139): Wikibase\Repo\ParserOutput\EntityParserOutputDataUpdaterCollection->updateParserOutput(Wikibase\DataModel\Entity\Item)
#3 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/Content/EntityContent.php(291): Wikibase\Repo\ParserOutput\EntityParserOutputGenerator->getParserOutput(Wikibase\DataModel\Entity\Item, boolean)
#4 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/Content/EntityContent.php(228): Wikibase\EntityContent->getParserOutputFromEntityView(integer, ParserOptions, boolean)
#5 /srv/mediawiki/php-1.33.0-wmf.6/includes/Revision/RenderedRevision.php(265): Wikibase\EntityContent->getParserOutput(Title, integer, ParserOptions, boolean)
#6 /srv/mediawiki/php-1.33.0-wmf.6/includes/Revision/RenderedRevision.php(233): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(Wikibase\ItemContent, boolean)
#7 /srv/mediawiki/php-1.33.0-wmf.6/includes/Revision/RevisionRenderer.php(184): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string)
#8 /srv/mediawiki/php-1.33.0-wmf.6/includes/Revision/RevisionRenderer.php(133): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#9 [internal function]: Closure$MediaWiki\Revision\RevisionRenderer::getRenderedRevision#2(MediaWiki\Revision\RenderedRevision, array)
#10 /srv/mediawiki/php-1.33.0-wmf.6/includes/Revision/RenderedRevision.php(197): call_user_func(Closure$MediaWiki\Revision\RevisionRenderer::getRenderedRevision#2;2592, MediaWiki\Revision\RenderedRevision, array)
#11 /srv/mediawiki/php-1.33.0-wmf.6/includes/poolcounter/PoolWorkArticleView.php(194): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#12 /srv/mediawiki/php-1.33.0-wmf.6/includes/poolcounter/PoolCounterWork.php(123): PoolWorkArticleView->doWork()
#13 /srv/mediawiki/php-1.33.0-wmf.6/includes/page/Article.php(774): PoolCounterWork->execute()
#14 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/Actions/ViewEntityAction.php(79): Article->view()
#15 /srv/mediawiki/php-1.33.0-wmf.6/extensions/Wikibase/repo/includes/Actions/ViewEntityAction.php(54): Wikibase\ViewEntityAction->showEntityPage()
#16 /srv/mediawiki/php-1.33.0-wmf.6/includes/MediaWiki.php(501): Wikibase\ViewEntityAction->show()
#17 /srv/mediawiki/php-1.33.0-wmf.6/includes/MediaWiki.php(294): MediaWiki->performAction(Article, Title)
#18 /srv/mediawiki/php-1.33.0-wmf.6/includes/MediaWiki.php(862): MediaWiki->performRequest()
#19 /srv/mediawiki/php-1.33.0-wmf.6/includes/MediaWiki.php(517): MediaWiki->main()
#20 /srv/mediawiki/php-1.33.0-wmf.6/index.php(42): MediaWiki->run()
#21 /srv/mediawiki/w/index.php(3): include(string)
#22 {main}

Impact

Internal error when loading Wikidata item pages which have coordinate values with a globe other than the Earth (e. g. coordinates on the Moon or on Mars). (Presumably. Investigation ongoing.) Happening since the deployment of 1.33.0-wmf.6, which includes T184933: Display map for geocoordinate statements.

Notes

Details

SubjectRepoBranchLines +/-
Never return null in CachingKartographerEmbeddingHandler::getParserOutputmediawiki/extensions/Wikibasemaster+19 -2
Never return null in CachingKartographerEmbeddingHandler::getParserOutputmediawiki/extensions/Wikibasewmf/1.33.0-wmf.6+19 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE triaged this task as Unbreak Now! priority.Nov 28 2018, 3:37 PM
Lucas_Werkmeister_WMDE created this task.
Restricted Application added subscribers: Liuxinyu970226, • Mholloway, TerraCodes, Aklapper. · View Herald TranscriptNov 28 2018, 3:37 PM
gerritbot subscribed.Nov 28 2018, 3:46 PM

Change 476292 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/Wikibase@master] Never return null in CachingKartographerEmbeddingHandler::getParserOutput

https://gerrit.wikimedia.org/r/476292

gerritbot added a project: Patch-For-Review.Nov 28 2018, 3:46 PM
hoo claimed this task.Nov 28 2018, 3:46 PM
Lydia_Pintscher added a project: Wikidata-Campsite.Nov 28 2018, 3:48 PM
Lucas_Werkmeister_WMDE lowered the priority of this task from Unbreak Now! to High.Nov 28 2018, 4:02 PM

Lowering priority from UBN to High, since Wikidata has been rolled back to wmf.4 for now.

Lucas_Werkmeister_WMDE mentioned this in T210634: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds.Nov 28 2018, 5:22 PM
gerritbot added a comment.Nov 28 2018, 5:23 PM

Change 476312 had a related patch set uploaded (by Thcipriani; owner: Hoo man):
[mediawiki/extensions/Wikibase@wmf/1.33.0-wmf.6] Never return null in CachingKartographerEmbeddingHandler::getParserOutput

https://gerrit.wikimedia.org/r/476312

Krinkle moved this task from Untriaged to Jan2020/1.35-wmf.14 on the Wikimedia-production-error board.Nov 28 2018, 6:08 PM
gerritbot added a comment.Nov 28 2018, 6:14 PM

Change 476312 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.33.0-wmf.6] Never return null in CachingKartographerEmbeddingHandler::getParserOutput

https://gerrit.wikimedia.org/r/476312

Stashbot subscribed.Nov 28 2018, 6:33 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-28T18:33:10Z] <thcipriani@deploy1001> Synchronized php-1.33.0-wmf.6/extensions/Wikibase/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php: [[gerrit:476312|Never return null in CachingKartographerEmbeddingHandler::getParserOutput]] T210617 (duration: 00m 53s)

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 28 2018, 7:00 PM
gerritbot added a comment.Nov 29 2018, 3:14 AM

Change 476292 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Never return null in CachingKartographerEmbeddingHandler::getParserOutput

https://gerrit.wikimedia.org/r/476292

hoo closed this task as Resolved.Nov 29 2018, 3:25 AM
hoo removed a project: Patch-For-Review.
ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.8; 2018-12-11); removed MW-1.33-notes (1.33.0-wmf.6; 2018-11-27).Nov 29 2018, 4:00 AM
Stashbot mentioned this in T184933: Display map for geocoordinate statements.Nov 29 2018, 1:45 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-29T13:45:02Z] <hashar@deploy1001> Synchronized php-1.33.0-wmf.6/extensions/Wikibase: feature flag for globe coordinator formatter using kartographer - T184933 T210617 (duration: 01m 18s)

Liuxinyu970226 unsubscribed.Dec 2 2018, 7:28 AM
Krinkle moved this task from Jan2020/1.35-wmf.14 to Resolved on the Wikimedia-production-error board.Mar 19 2019, 3:20 PM
• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:08 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL