Maniphest T206660

1.33.0-wmf.6 deployment blockers
Closed, ResolvedPublicRelease
Actions

Assigned To

Authored By

	greg
	Oct 10 2018, 5:22 PM

Details

Release Version: 1.33.0-wmf.6
Release Date: Nov 26 2018, 12:00 AM

2018 week 48 1.33-wmf.6 Changes wmf/1.33.0-wmf.6

This MediaWiki Train Deployment is scheduled for the week of Monday, November 26th:

Monday November 26th	Tuesday, November 27th	Wednesday, November 28th	Thursday, November 29th	Friday
Backports only.	Branch `wmf.6` and deploy to Group 0 Wikis.	Deploy `wmf.6` to Group 1 Wikis.	Deploy `wmf.6` to all Wikis.	No deployments on fridays

See https://wikitech.wikimedia.org/wiki/Deployments for full schedule.

How this works

Any serious bugs affecting wmf.6 should be added as subtasks beneath this one.
- Use this form to create one.
Any open subtask(s) block the train from moving forward. This means no further deployments until the blockers are resolved.
If something is serious enough to warrant a rollback then you should bring it to the attention of deployers on the #wikimedia-operations IRC channel.
If you have a risky change in this week's train add a comment to this task using the Risky patch template
For more info about deployment blockers, see Holding the train.

Other Deployments

Previous: 1.33.0-wmf.5

Next: 1.33.0-wmf.7

	Subject	Repo	Branch	Lines +/-
	Revert "all wikis to 1.33.0-wmf.6"	operations/mediawiki-config	master	+298 -298
	Group0 to 1.33.0-wmf.6	operations/mediawiki-config	master	+130 -130

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved	Release	hashar	T206660 1.33.0-wmf.6 deployment blockers
Resolved	PRODUCTION ERROR	• mobrovac	T210608 EventBus::createEvent Call to a member function format() on a non-object (boolean)
Resolved	PRODUCTION ERROR	Ladsgroup	T210610 PHP Fatal Error: Argument 2 passed to ORES\Hooks\ApiHooksHandler::addScoresForAPI() must be an instance of array, null given
Resolved	PRODUCTION ERROR	hoo	T210617 BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes
Resolved	PRODUCTION ERROR	Lucas_Werkmeister_WMDE	T210618 Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch
Resolved	PRODUCTION ERROR	Anomie	T210732 wiktionary: /rpc/RunSingleJob.php CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.php: Cannot create an actor for a usable name that is not an existing user
Resolved	PRODUCTION ERROR	pmiazga	T210737 Various User.php: PHP Notice: Object of class User could not be converted to int

Event Timeline

greg created this task.Oct 10 2018, 5:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 10 2018, 5:22 PM

greg triaged this task as Medium priority.Oct 10 2018, 7:27 PM

Liuxinyu970226 subscribed.Oct 27 2018, 7:36 AM

greg assigned this task to hashar.Nov 7 2018, 11:17 PM

Restricted Application added a project: Release-Engineering-Team (Kanban). · View Herald TranscriptNov 7 2018, 11:17 PM

thcipriani added a subscriber: • mmodell.Nov 21 2018, 6:39 PM

thcipriani subscribed.

hashar moved this task from Backlog to In-progress on the Release-Engineering-Team (Kanban) board.Nov 26 2018, 5:32 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-27T14:04:32Z] <hashar> Cutting 1.33.0-wmf.6 branches | T206660

Mentioned in SAL (#wikimedia-operations) [2018-11-27T14:33:44Z] <hashar> scap prep 1.33.0-wmf.6 | T206660

Mentioned in SAL (#wikimedia-operations) [2018-11-27T14:40:31Z] <hashar> Applied security patches for 1.33.0-wmf.6 | T206660

Change 476028 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/mediawiki-config@master] Group0 to 1.33.0-wmf.6

https://gerrit.wikimedia.org/r/476028

gerritbot added a project: Patch-For-Review.Nov 27 2018, 2:41 PM

Mentioned in SAL (#wikimedia-operations) [2018-11-27T15:02:32Z] <hashar@deploy1001> Started scap: testwiki to php-1.33.0-wmf.6 and rebuild l10n cache | T206660

Mentioned in SAL (#wikimedia-operations) [2018-11-27T15:35:14Z] <hashar@deploy1001> Finished scap: testwiki to php-1.33.0-wmf.6 and rebuild l10n cache | T206660 (duration: 32m 42s)

Change 476028 merged by jenkins-bot:
[operations/mediawiki-config@master] Group0 to 1.33.0-wmf.6

https://gerrit.wikimedia.org/r/476028

hashar added a subtask: T210608: EventBus::createEvent Call to a member function format() on a non-object (boolean).Nov 28 2018, 2:29 PM

hashar added a subtask: T210610: PHP Fatal Error: Argument 2 passed to ORES\Hooks\ApiHooksHandler::addScoresForAPI() must be an instance of array, null given.Nov 28 2018, 2:32 PM

At 15:49UTC I rolled back wikidatawiki to 1.33.0-wmf.4 at @Lydia_Pintscher's request via IRC. All other group1 wikis are still on 1.33.0-wmf.6.

https://tools.wmflabs.org/sal/log/AWdbArniA1BDhGjCTkDp

Lucas_Werkmeister_WMDE removed a subtask: T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch.Nov 28 2018, 4:11 PM

readding the wikidata blocking task as it is blocking the full rollout of wmf.6 to all wikis (wikidatawiki).

Lucas_Werkmeister_WMDE closed subtask T210618: Wikidata entity search sometimes case-sensitive, uses wb_terms instead of CirrusSearch as Resolved.Nov 28 2018, 5:14 PM

• mobrovac closed subtask T210608: EventBus::createEvent Call to a member function format() on a non-object (boolean) as Resolved.Nov 28 2018, 6:27 PM

Ladsgroup closed subtask T210610: PHP Fatal Error: Argument 2 passed to ORES\Hooks\ApiHooksHandler::addScoresForAPI() must be an instance of array, null given as Resolved.Nov 28 2018, 7:09 PM

Jdforrester-WMF subscribed.Nov 29 2018, 2:56 AM

hoo closed subtask T210617: BadMethodCallException on Wikidata item pages containing coordinates with non-Earth globes as Resolved.Nov 29 2018, 3:25 AM

wikidatawiki is back to 1.33.0-wmf.6

Change 476514 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/mediawiki-config@master] Revert "all wikis to 1.33.0-wmf.6"

https://gerrit.wikimedia.org/r/476514

Change 476514 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "all wikis to 1.33.0-wmf.6"

https://gerrit.wikimedia.org/r/476514

hashar added a subtask: T210732: wiktionary: /rpc/RunSingleJob.php CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.php: Cannot create an actor for a usable name that is not an existing user.Nov 29 2018, 2:46 PM

hashar added a subtask: T210734: incubatorwiki: PHP Fatal Error from line 143 of /srv/mediawiki/php-1.33.0-wmf.6/extensions/GeoCrumbs/GeoCrumbs.class.php: Argument 1 passed to GeoCrumbs::getParentRegion() must be an instance of ParserOutput, bool given.Nov 29 2018, 2:54 PM

hashar added a subtask: T210737: Various User.php: PHP Notice: Object of class User could not be converted to int.Nov 29 2018, 3:05 PM

hashar added a subtask: T210739: Target deletion during page move fails.Nov 29 2018, 3:25 PM

greg added a subtask: T210621: Internal api error: CannotCreateActorException.Nov 29 2018, 6:32 PM

Anomie closed subtask T210732: wiktionary: /rpc/RunSingleJob.php CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.php: Cannot create an actor for a usable name that is not an existing user as Resolved.Nov 29 2018, 6:54 PM

hashar closed subtask T210737: Various User.php: PHP Notice: Object of class User could not be converted to int as Resolved.Nov 29 2018, 7:40 PM

T210739 occurred previously, not a blocker anymore.

T210621 is no more a blocker, it is related to the Actor deployment and a config flag that got changed.

GeoCrumbs fatal was a one off spike and an issue in the code that predate 1.33.0-wmf.6 T210734 is no more a blocker.

Should be stable now. All blockers got quickly fixed, some other turned out to be pre existing or one off issues.

Thanks to anyone that participated.

greg awarded a token.Nov 29 2018, 10:23 PM

Liuxinyu970226 unsubscribed.Dec 2 2018, 7:20 AM

1.33.0-wmf.6 deployment blockersClosed, ResolvedPublicReleaseActions