Page MenuHomePhabricator
Create Task
Maniphest T211052

SlotRoleHandler's introduction breaks WBMI; edits now fail with "content is not allowed on page" error
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Follow-up 9210005: Move to the MediaWikiServices hook and scrap our classmediawiki/extensions/WikibaseMediaInfomaster+17 -40
Use SlotRoleHandler so that our content is editable againmediawiki/extensions/WikibaseMediaInfomaster+45 -0
Customize query in gerrit

Related Objects

Event Timeline

Jdforrester-WMF created this task.Dec 3 2018, 8:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 3 2018, 8:30 PM
Jdforrester-WMF mentioned this in T211053: Error for file namespace should escape the title in the link.Dec 3 2018, 8:31 PM
Cparle subscribed.Dec 4 2018, 12:28 PM

This works fine on my local version with the latest wikibase. Some (other) quirk of beta perhaps?

Cparle added a comment.Dec 4 2018, 12:59 PM

Also if I try and edit captions on an existing image e.g. https://commons.wikimedia.beta.wmflabs.org/wiki/File:Martti_Jukola_reporting_from_a_sports_event,_1930s..jpg refreshing the captions fails

The reason is the api query for wbgetentities for the relevant mediainfo item returns "missing", see https://commons.wikimedia.beta.wmflabs.org/w/api.php?action=wbgetentities&format=json&props=info|labels&ids=M53736

Again works fine on my local version

Jdforrester-WMF triaged this task as Unbreak Now! priority.Dec 4 2018, 4:39 PM

Replicated locally as well as on Beta. Back-trace:

{
    "error": {
        "code": "internal_api_error_MediaWiki\\Storage\\PageUpdateException",
        "info": "[a3dc984b44fa2b36b377efe2] Exception caught: Slot role `mediainfo` is not allowed.",
        "errorclass": "MediaWiki\\Storage\\PageUpdateException",
        "*": "MediaWiki\\Storage\\PageUpdateException at /vagrant/mediawiki/includes/Storage/PageUpdater.php(1260)
		#0 /vagrant/mediawiki/includes/Storage/PageUpdater.php(349): MediaWiki\\Storage\\PageUpdater->ensureRoleAllowed(string)
		#1 /vagrant/mediawiki/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php(314): MediaWiki\\Storage\\PageUpdater->setContent(string, Wikibase\\MediaInfo\\Content\\MediaInfoContent)
		#2 /vagrant/mediawiki/extensions/Wikibase/repo/includes/Store/Sql/WikiPageEntityStore.php(207): Wikibase\\Repo\\Store\\WikiPageEntityStore->saveEntityContent(Wikibase\\MediaInfo\\Content\\MediaInfoContent, string, User, integer, boolean)
		#3 /vagrant/mediawiki/extensions/Wikibase/lib/includes/Store/TypeDispatchingEntityStore.php(87): Wikibase\\Repo\\Store\\WikiPageEntityStore->saveEntity(Wikibase\\MediaInfo\\DataModel\\MediaInfo, string, User, integer, boolean)
		#4 /vagrant/mediawiki/extensions/Wikibase/repo/includes/EditEntity/StatsdSaveTimeRecordingEntityStore.php(49): Wikibase\\Lib\\Store\\TypeDispatchingEntityStore->saveEntity(Wikibase\\MediaInfo\\DataModel\\MediaInfo, string, User, integer, boolean)
		#5 /vagrant/mediawiki/extensions/Wikibase/repo/includes/EditEntity/MediawikiEditEntity.php(709): Wikibase\\Repo\\EditEntity\\StatsdSaveTimeRecordingEntityStore->saveEntity(Wikibase\\MediaInfo\\DataModel\\MediaInfo, string, User, integer, boolean)
		#6 /vagrant/mediawiki/extensions/Wikibase/repo/includes/EditEntity/StatsdSaveTimeRecordingEditEntity.php(73): Wikibase\\Repo\\EditEntity\\MediawikiEditEntity->attemptSave(Wikibase\\MediaInfo\\DataModel\\MediaInfo, string, integer, string, boolean)
		#7 /vagrant/mediawiki/extensions/Wikibase/repo/includes/Api/EntitySavingHelper.php(350): Wikibase\\Repo\\EditEntity\\StatsdSaveTimeRecordingEditEntity->attemptSave(Wikibase\\MediaInfo\\DataModel\\MediaInfo, string, integer, string)
		#8 /vagrant/mediawiki/extensions/Wikibase/repo/includes/Api/ModifyEntity.php(309): Wikibase\\Repo\\Api\\EntitySavingHelper->attemptSaveEntity(Wikibase\\MediaInfo\\DataModel\\MediaInfo, string)
		#9 /vagrant/mediawiki/includes/api/ApiMain.php(1595): Wikibase\\Repo\\Api\\ModifyEntity->execute()
		#10 /vagrant/mediawiki/includes/api/ApiMain.php(531): ApiMain->executeAction()
		#11 /vagrant/mediawiki/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
		#12 /vagrant/mediawiki/api.php(87): ApiMain->execute()
		#13 /var/www/w/api.php(5): require(string)
		#14 {main}"
    }
}
Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptDec 4 2018, 4:39 PM
Marostegui subscribed.Dec 4 2018, 4:41 PM
Jdforrester-WMF added a project: Platform Engineering (MCR).Dec 4 2018, 4:44 PM
Jdforrester-WMF added subscribers: daniel, Anomie.

Looks like this was broken by db987c700adfe8766316d56f2b4e05935e09d6a4 with the new SlotRoleHandler stuff?

Jdforrester-WMF added a comment.Dec 4 2018, 4:53 PM

Yup, on by default. Lovely.

Anomie added a comment.Dec 4 2018, 5:04 PM

"info": "[a3dc984b44fa2b36b377efe2] Exception caught: Slot role mediainfo is not allowed.",

That makes it sound like code somewhere needs to call MediaWikiServices::getSlotRoleRegistry()->defineRole( 'mediainfo', ... ) to define the mediainfo role. The "..." is a factory function for a SlotRoleHandler object, either a mediainfo-specific subclass or SlotRoleHandler itself if __construct() has enough flexibility do the right thing.

gerritbot subscribed.Dec 4 2018, 6:36 PM

Change 477606 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] Use SlotRoleHandler so that our content is editable again

https://gerrit.wikimedia.org/r/477606

gerritbot added a project: Patch-For-Review.Dec 4 2018, 6:36 PM
Jdforrester-WMF mentioned this in rEWBIb75858efda4b: Use SlotRoleHandler so that our content is editable again.Dec 4 2018, 6:40 PM
Jdforrester-WMF mentioned this in rEWBI9210005e1699: Use SlotRoleHandler so that our content is editable again.Dec 4 2018, 7:48 PM
Jdforrester-WMF moved this task from To Do to Doing on the Structured Data Engineering board.Dec 4 2018, 7:56 PM
Jdforrester-WMF renamed this task from Adding WBMI captions now fails in Wikibase with "content is not allowed on page" error on master to SlotRoleHandler's introduction breaks WBMI; edits now fail with "content is not allowed on page" error.Dec 4 2018, 7:59 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF removed a project: Wikidata.
Jdforrester-WMF updated the task description. (Show Details)
gerritbot added a comment.Dec 5 2018, 11:46 AM

Change 477606 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Use SlotRoleHandler so that our content is editable again

https://gerrit.wikimedia.org/r/477606

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.8; 2018-12-11).Dec 5 2018, 12:02 PM
CCicalese_WMF added a project: Platform Team Legacy (Watching / External).Dec 5 2018, 4:53 PM
daniel added a comment.Dec 5 2018, 5:25 PM

Sorry about breaking this. I should have myself made the necessary patch.

I left a few comments on the patch about how to make this a bit smoother.

gerritbot added a comment.Dec 5 2018, 5:31 PM

Change 477820 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikibaseMediaInfo@master] Follow-up 9210005: Move to the MediaWikiServices hook and scrap our class

https://gerrit.wikimedia.org/r/477820

Jdforrester-WMF moved this task from Doing to Verify on Production on the Structured Data Engineering board.Dec 5 2018, 5:32 PM
Jdforrester-WMF mentioned this in rEWBI56c26518317b: Follow-up 9210005: Move to the MediaWikiServices hook and scrap our class.Dec 5 2018, 5:33 PM
Jdforrester-WMF mentioned this in rEWBI77890866ff27: Follow-up 9210005: Move to the MediaWikiServices hook and scrap our class.Dec 5 2018, 9:59 PM
Jdforrester-WMF mentioned this in rEWBIeff0468644e9: Follow-up 9210005: Move to the MediaWikiServices hook and scrap our class.Dec 5 2018, 10:07 PM
gerritbot added a comment.Dec 6 2018, 10:44 AM

Change 477820 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Follow-up 9210005: Move to the MediaWikiServices hook and scrap our class

https://gerrit.wikimedia.org/r/477820

Jdforrester-WMF added a comment.Dec 6 2018, 3:59 PM

So… my patch for this fixed it locally, but not on Beta Commons – content-not-allowed-here (e.g. "wikibase-mediainfo" content is not allowed on page File:Test-1445021196.521987.png in slot "Main") is still the error I get on trying to add a caption. Any ideas? Maybe related to T211237 brokeness?

daniel added a comment.Dec 6 2018, 4:03 PM

The message is correct - wikibase-mediainfo is indeed not allowed in the Main slot. The question is, why is it trying to write mediainfo into the main slot?

Jdforrester-WMF added a comment.Dec 6 2018, 4:04 PM
In T211052#4803741, @daniel wrote:

The message is correct - wikibase-mediainfo is indeed not allowed in the Main slot. The question is, why is it trying to write mediainfo into the main slot?

Yeah, it looks like some wiring is wrong.

daniel mentioned this in T211237: wbgetentities has stopped returning content on Beta Cluster Commons.Dec 6 2018, 4:04 PM
CCicalese_WMF mentioned this in T211473: JADE\Tests\Hooks\MoveHooksTest::testOnMovePageIsValidMove is broken.Dec 10 2018, 5:54 PM
Jdforrester-WMF removed a project: Patch-For-Review.Dec 11 2018, 7:31 PM

Now that T211237 is resolved, this is fixed in Beta too:

https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File:Redsq.png&diff=105660&oldid=105549
https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File:VisualEditor_Insert_Menu-cy.png&diff=105661&oldid=93281

• Ramsey-WMF closed this task as Resolved.Dec 13 2018, 12:40 AM
• Ramsey-WMF subscribed.

This specific issue on Beta has been resolved with the rollback of Wikibase Federation. But we still have issues to look at. See T211801 and T211800

Liuxinyu970226 unsubscribed.Dec 16 2018, 1:36 PM
greg added a project: Multimedia.Mar 7 2019, 10:59 PM
CCicalese_WMF edited projects, added Core Platform Team Initiatives (MCR); removed Platform Engineering (MCR).Jul 30 2019, 7:41 PM
Aklapper removed a subscriber: Anomie.Oct 16 2020, 5:38 PM
Restricted Application added a project: Structured-Data-Backlog. · View Herald TranscriptOct 16 2020, 5:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL