Page MenuHomePhabricator
Create Task
Maniphest T213256

CX2: Outputs unnecessary self-closing nowiki and div tags inside ref tags
Closed, ResolvedPublic
Actions

Description

CX2 should not add unnecessary tags in ref tags :

  • The <nowiki/> tag should have been replaced by a whitespace character
  • The <div>...</div> tags are unnecessary and produce an incorrect rendering of the reference : the reference text is not displayed on the same line as the reference number (example with the 3rd reference)

Example on frwiki "Maaraue" : original translation with the following content

Example on frwiki "Claudia Pulchra" : original translation with the following content

  • <ref><div> Lightman, ''A à Z des femmes grecques et romaines anciennes'' , p.205 </div></ref>
  • <ref><div> Barrett, ''Agrippina: Sexe, pouvoir et politique dans le Premier Empire'' , p.78 </div></ref>
  • <ref><div> Lightman, ''A à Z des femmes grecques et romaines'' antiques, p.205; Barrett, ''Agrippina: Sexe, pouvoir et politique dans le Premier Empire'' , p.78 </div></ref>
  • ...

Related tickets:

Details

SubjectRepoBranchLines +/-
Avoid unnecessary <div> tags inside <ref> tagsmediawiki/services/cxservermaster+75 -2
Customize query in gerrit

Related Objects

Event Timeline

NicoV created this task.Jan 9 2019, 10:44 AM
Restricted Application added subscribers: jeblad, Aklapper. · View Herald TranscriptJan 9 2019, 10:44 AM
NicoV updated the task description. (Show Details)Jan 9 2019, 10:48 AM
NicoV updated the task description. (Show Details)Jan 9 2019, 10:50 AM
NicoV updated the task description. (Show Details)
NicoV updated the task description. (Show Details)Jan 9 2019, 12:54 PM
NicoV updated the task description. (Show Details)
Pginer-WMF added a project: Language-Team (Language-2019-January-March).Jan 21 2019, 2:03 PM
Pginer-WMF triaged this task as Medium priority.Jan 21 2019, 2:16 PM
Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-January-March) board.
Pginer-WMF updated the task description. (Show Details)Jan 21 2019, 2:24 PM
• santhosh claimed this task.Jan 23 2019, 10:58 AM
• santhosh moved this task from Priority backlog to In Progress on the Language-Team (Language-2019-January-March) board.Jan 23 2019, 11:27 AM
gerritbot subscribed.Jan 23 2019, 12:20 PM

Change 486070 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/services/cxserver@master] Avoid unnecessary <div> tags inside <ref> tags

https://gerrit.wikimedia.org/r/486070

gerritbot added a project: Patch-For-Review.Jan 23 2019, 12:20 PM
Pginer-WMF subscribed.Jan 23 2019, 5:15 PM

Based on the example from this conversation, the translation of "Oktay Rıfat Horozcu" from English to Spanish has another example of unexpected <div> added for reference [2] (on the 3rd paragraph of the "Career" section).

• santhosh moved this task from In Progress to In Review on the Language-Team (Language-2019-January-March) board.Jan 24 2019, 4:56 AM
Pginer-WMF moved this task from Needs Triage to CX2 on the ContentTranslation board.Jan 24 2019, 4:12 PM
Framawiki subscribed.Jan 24 2019, 6:44 PM

If other samples are wanted, you can see the ones corrected on frwiki https://quarry.wmflabs.org/query/32900

Pginer-WMF added a comment.Jan 25 2019, 8:31 AM
In T213256#4906692, @Framawiki wrote:

If other samples are wanted, you can see the ones corrected on frwiki https://quarry.wmflabs.org/query/32900

Thanks @Framawiki! This is really useful, and will allow us to see the impact of the improvements we are working on.
I made a fork of the query to count the number of issues on a monthly basis.

Pginer-WMF added a comment.Feb 5 2019, 8:36 AM
In T213256#4906692, @Framawiki wrote:

If other samples are wanted, you can see the ones corrected on frwiki https://quarry.wmflabs.org/query/32900

According to the query, the last entry is from January 26. So it is possible that after the recent updates, the issues that the bot as fixing are no longer happening.

gerritbot added a comment.Feb 6 2019, 6:50 AM

Change 486070 merged by jenkins-bot:
[mediawiki/services/cxserver@master] Avoid unnecessary <div> tags inside <ref> tags

https://gerrit.wikimedia.org/r/486070

Stashbot subscribed.Feb 11 2019, 3:00 AM

Mentioned in SAL (#wikimedia-operations) [2019-02-11T03:00:58Z] <kartik@deploy1001> Started deploy [cxserver/deploy@ee4a15a]: Update cxserver to 8928852 (T213256)

Stashbot added a comment.Feb 11 2019, 3:05 AM

Mentioned in SAL (#wikimedia-operations) [2019-02-11T03:05:06Z] <kartik@deploy1001> Finished deploy [cxserver/deploy@ee4a15a]: Update cxserver to 8928852 (T213256) (duration: 04m 08s)

Arrbee moved this task from In Review to Needs QA-before deployment on the Language-Team (Language-2019-January-March) board.Feb 11 2019, 8:06 AM
• Petar.petkovic removed a project: Patch-For-Review.Feb 11 2019, 8:12 AM
Framawiki mentioned this in T215831: Show query run date above outputs section.Feb 11 2019, 6:41 PM
Framawiki added a comment.Feb 11 2019, 6:46 PM
In T213256#4926548, @Pginer-WMF wrote:
In T213256#4906692, @Framawiki wrote:

If other samples are wanted, you can see the ones corrected on frwiki https://quarry.wmflabs.org/query/32900

According to the query, the last entry is from January 26. So it is possible that after the recent updates, the issues that the bot as fixing are no longer happening.

Note that quarry queries needs to be run manually by query owner, or by anyone after a fork. Results that are shown correspond to the results at the time it was executed, and is not updated automatically. Related upstream bug is T203791: Allow quarry queries to be executed by someone else without the need to fork. I've re-executed just now this query, that shows recent (last night) related entries.

Pginer-WMF added a comment.Feb 12 2019, 9:07 AM
In T213256#4944712, @Framawiki wrote:

Note that quarry queries needs to be run manually by query owner, or by anyone after a fork.

Thanks for the clarification. I created my own fork to be able to access to live data more easily. Since this particular ticket is about empty divs in references and it got deployed yesterday, I expect the instances of "div inutile dans une ref" to reduce over time (those should not happen with newly started translations but may appear in translations that were started earlier but not published immediately).

Etonkovidova closed this task as Resolved.Feb 14 2019, 1:48 AM
Etonkovidova subscribed.
  • I checked the problematic translations mentioned in the task en:Antonio Brunetti ->fr and de:Maaraue ->fr. In cx2-teseting div tags were not added anymore.
  • https://quarry.wmflabs.org/query/32917 -- shows a noticeable increase in corrections
  • https://gerrit.wikimedia.org/r/#/c/mediawiki/services/cxserver/+/486070/ -- I do not see deployment tag added to it. Will the fix be swatted?
  • <nowiki/> I did not see it added in the translations reported in the ticket, but I see it added when translating in cx2-testing (the addition was correctly done, in my opinion).

Note: the ticket is Resolved but I am not moving it to Done yet - it needs to be monitored in production.

Arrbee reopened this task as Open.Feb 14 2019, 2:38 PM
Arrbee moved this task from Needs QA-before deployment to Done on the Language-Team (Language-2019-January-March) board.
Arrbee subscribed.
In T213256#4953147, @Etonkovidova wrote:

Note: the ticket is Resolved but I am not moving it to Done yet - it needs to be monitored in production.

Instead, re-opened and moved to Done to maintain visibility to ensure monitoring in production.

Pginer-WMF closed this task as Resolved.EditedMar 4 2019, 10:05 AM

I think we can close this one. Recent queries shown that bot fixes for this particular error are not appearing recently. It is still possible that a few old translations get published with these errors, but it seems that the issue is not happening for new translations. I created a customized version of the query to count the "div inutile dans une ref" case, and it shows 0 results for March (more than 2 issues/day were registered for previous months).

I'm closing the ticket. @NicoV, let us know if this also seems to be fixed from your perspective.

NicoV added a comment.Mar 4 2019, 10:34 AM

It seems to be ok on the last edits I checked, thansk

Pginer-WMF added a comment.Mar 4 2019, 11:01 AM
In T213256#4997379, @NicoV wrote:

It seems to be ok on the last edits I checked, thansk

Great. Thanks for checking!

• santhosh merged a task: T210276: CX2: Avoid unnecessary extra divs in references.Apr 10 2019, 9:29 AM
• santhosh added subscribers: • santhosh, Base.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL