@Ejegg as fyi

The lack of translations is probably a bug.

@MBeat33 might have concerns if we remove this.

@DStrine Thanks David; and if it's a bug, can anyone tell me into which languages we have it translated?

Change 490135 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Make email explanation translatable

https://gerrit.wikimedia.org/r/490135

It wan't translatable before (just a quick hack to get something for IE and GB) but it will be once we get that patch merged ^^^

Change 490135 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Make email explanation translatable

https://gerrit.wikimedia.org/r/490135

@TSkaff, in answer to your first question, it's super simple to remove - just don't include variant=emailExplain in the URL, and it won't show up.

@Ejegg That causes the opt-in question to show again though, even if the choice is included in the URL. Compare:

• https://payments.wikimedia.org/index.php?title=Special:IngenicoGateway&appeal=JimmyQuote&ffname=cc-vmaj&recurring=false&payment_method=cc&uselang=en&country=GB&currency=GBP&amount=2&opt_in=1
• https://payments.wikimedia.org/index.php?title=Special:IngenicoGateway&appeal=JimmyQuote&ffname=cc-vmaj&recurring=false&payment_method=cc&uselang=en&country=GB&currency=GBP&amount=2&opt_in=1&variant=emailExplain

Oh weird @Pcoombe, that was totally not intended. The emailExplain variant was supposed to just insert an extra row after the email field: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/modules/js/ext.donationInterface.emailExplain.js

We'll have to look into why it seems to be suppressing the opt_in checkboxes.

@Ejegg If we have the opt_in parameter in the URL then I think we do want to suppress the question though, as we already asked it (in the banner, or on donatewiki)

Let's break this conversation about opt_in into a separate task.

Aha, I figured it out. The 'variant' parameter lets you override everything in the gateway's config dir, e.g. https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/globalcollect_gateway/config/

That includes the country_fields file which tells us which countries need the opt_in parameter: https://phabricator.wikimedia.org/diffusion/EDOI/browse/master/globalcollect_gateway/config/country_fields.yaml

Looks like we decided to override that file in the emailExplain variant, replacing it with one that doesn't require opt_in to be shown: https://phabricator.wikimedia.org/source/mediawiki/browse/fundraising%252FREL1_27/form_variants/emailExplain/globalcollect/

Change 493618 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@master] Only show emailExplain when opted out

https://gerrit.wikimedia.org/r/493618

Change 493618 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Only show emailExplain when opted out

https://gerrit.wikimedia.org/r/493618

Change 494390 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@deployment] Make email explanation translatable

https://gerrit.wikimedia.org/r/494390

Change 494396 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[mediawiki/extensions/DonationInterface@deployment] Only show emailExplain when opted out

https://gerrit.wikimedia.org/r/494396

Change 494390 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@deployment] Make email explanation translatable

https://gerrit.wikimedia.org/r/494390

Change 494396 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@deployment] Only show emailExplain when opted out

https://gerrit.wikimedia.org/r/494396

This is deployed - the emailExplain variant now only shows the text when the donor has opted OUT, and there are translations in these languages:
ar
bg
de
en
fr
he
id
mk
pt-br
pt
roa-tara
zh-hant

@TSkaff, @spatton, et al: Do you want to keep this as a 'variant' that needs to be triggered by that URL parameter, or would you rather this be the default behavior for any form where the donor has opted out of email lists upstream (on a banner or donatewiki)?

Thanks @Ejegg ! We'd be happy to make this default for anyone who opted out, and shorten our URLs by removing the variant parameter :)