CX2: Spellcheck and IME appearing for source sections
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	santhosh
	Mar 6 2019, 9:57 AM

Description

Details

Subject	Repo	Branch	Lines +/-
Remove 'noime' classes from CE section nodes	mediawiki/extensions/ContentTranslation	master	+0 -5
Disable ULS in VE readOnly mode	mediawiki/extensions/UniversalLanguageSelector	master	+2 -1
Update VE core submodule to master (a61616907)	mediawiki/extensions/VisualEditor	master	+1 -1
Rely on VE code to disable spellchecker for read-only surface	mediawiki/extensions/ContentTranslation	master	+2 -5
Disable spellcheck and ime activation in source sections	mediawiki/extensions/ContentTranslation	master	+8 -0
ContentEditableNode: Disable spellcheck when read-only	VisualEditor/VisualEditor	master	+66 -39

Customize query in gerrit

Related Objects

Mentioned Here: rGVED8bb1eb5982e0: Scroll 60px past toolbar on iOS too to avoid context menu clash

Event Timeline

santhosh created this task.Mar 6 2019, 9:57 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2019, 9:57 AM

santhosh updated the task description. (Show Details)Mar 6 2019, 9:57 AM

Change 494679 had a related patch set uploaded (by Santhosh; owner: Santhosh):
[mediawiki/extensions/ContentTranslation@master] Disable spellcheck and ime activation in source sections

https://gerrit.wikimedia.org/r/494679

gerritbot added a project: Patch-For-Review.Mar 6 2019, 9:57 AM

santhosh triaged this task as Medium priority.Mar 6 2019, 9:58 AM

santhosh moved this task from Backlog to In Review on the Language-Team (Language-2019-January-March) board.

• Petar.petkovic moved this task from Needs Triage to CX2 on the ContentTranslation board.Mar 6 2019, 3:34 PM

@Esanders, Do you think the fix need to be in upstream? I don't see a reason a readonly surface having these attributes enabled.

JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.Mar 12 2019, 3:16 PM

Sure, seems reasonable.

Esanders moved this task from Incoming to In progress on the VisualEditor (Current work) board.Mar 14 2019, 4:26 PM

Change 496499 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] ContentEditableNode: Disable spellcheck when read-only

https://gerrit.wikimedia.org/r/496499

Esanders moved this task from In progress to Code review on the VisualEditor (Current work) board.Mar 14 2019, 5:46 PM

Esanders claimed this task.Mar 14 2019, 6:41 PM

Change 496499 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] ContentEditableNode: Disable spellcheck when read-only

https://gerrit.wikimedia.org/r/496499

Change 496473 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (8bb1eb598)

https://gerrit.wikimedia.org/r/496473

Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Mar 14 2019, 11:15 PM

Change 494679 merged by Petar.petkovic:
[mediawiki/extensions/ContentTranslation@master] Disable spellcheck and ime activation in source sections

https://gerrit.wikimedia.org/r/494679

• Petar.petkovic moved this task from In Review to Needs QA-before deployment on the Language-Team (Language-2019-January-March) board.Mar 15 2019, 12:19 AM

Change 496703 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Rely on VE code to disable spellchecker for read-only surface

https://gerrit.wikimedia.org/r/496703

• Petar.petkovic moved this task from Needs QA-before deployment to In Review on the Language-Team (Language-2019-January-March) board.Mar 15 2019, 3:33 AM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.22; 2019-03-19).Mar 17 2019, 4:02 AM

Change 496703 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Rely on VE code to disable spellchecker for read-only surface

https://gerrit.wikimedia.org/r/496703

Change 496473 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (a61616907)

https://gerrit.wikimedia.org/r/496473

Jdforrester-WMF removed a project: Patch-For-Review.Mar 18 2019, 9:32 PM

• Petar.petkovic moved this task from In Review to Needs QA-before deployment on the Language-Team (Language-2019-January-March) board.Mar 20 2019, 9:02 AM

• Petar.petkovic merged a task: T218756: CX2: Content Translation source column uses the browser built in spell checking.

• Petar.petkovic removed a subscriber: gerritbot.

• Petar.petkovic added a subscriber: Amire80.

Moving out of VE's QA column as QA will be done by the CX team.

@Pginer-WMF is it appropriate for me to mark this task as "Resolved" considering A) and B)?

In T217740#5040293, @Esanders wrote:

....QA will be done by the CX team.

B)
This ticket – T217740 – remains in CX's Needs QA - post deployment column.

In T217740#5068216, @ppelberg wrote:

@Pginer-WMF is it appropriate for me to mark this task as "Resolved" considering A) and B)?

Well, it depends:

If you (or anyone else) verified that the issues is no longer happening, it is ok to mark it as resolved. Marking it as resolved before it is verified has the risk of QA being skipped and potential issues not being surfaced by the QA process. Marking it as resolved conveys the message that no more work is needed (in all workboards).
If you want to capture that no additional work is required from the Editing team, you can consider selecting "Edit project tags" and remove VisualEditor for it to disappear for that board.

I did a quick check, and while the spellchecking no longer shows in the source, the input method selector still shows (although just at the top of the document, not for each paragraph). The example below illustrates the issue for the translation of "Lemonade" from English to Hindi:

Screenshot 2019-03-29 at 10.19.16.png (1×1 px, 312 KB)

Given the above, I'm reopening the ticket. But it would be ok to create a separate ticket as a follow-up if it is preferred to capture just the current issue.

Pginer-WMF edited projects, added Language-Team (Language-2019-April-June); removed Language-Team (Language-2019-January-March).Mar 29 2019, 9:32 PM

Pginer-WMF moved this task from Backlog to Needs QA on the Language-Team (Language-2019-April-June) board.

I checked the exact example as reported by @Pginer-WMF on hiwiki (1.33.0-wmf.23). IME is displayed in read-only content in the following cases:

In hiwiki start a new translation from English to Hindi.

(1) Click in the source panel in the paragraph and scroll up. IME will be displayed.

(2) In the source panel double click on an image or a reference to open up editing inspector - the fields cannot be edited but IME will be displayed:

Screen Shot 2019-04-04 at 12.50.59 PM.png (719×950 px, 211 KB)

Screen Shot 2019-04-04 at 12.51.28 PM.png (724×987 px, 219 KB)

(3) (does not happen consistently)

select an article for translation that has a infobox or an image as a first element of the artcile.
In the source panel click to select an infobox or a picture - IME will be present.

Screen Shot 2019-04-04 at 11.56.43 AM.png (639×762 px, 158 KB)

Note: the link inspector opened for links present in the source panel does not present IME.

Etonkovidova moved this task from Needs QA to In Progress on the Language-Team (Language-2019-April-June) board.Apr 4 2019, 7:58 PM

Spellcheck showing

In T217740#5070229, @Pginer-WMF wrote:

If you want to capture that no additional work is required from the Editing team, you can consider selecting "Edit project tags" and remove VisualEditor for it to disappear for that board.

👆This was precisely the intention behind the question I asked originally – I appreciate how thoughtful you were in deciphering that, @Pginer-WMF

IME selector still showing

As for the the IME selector still showing, I too am seeing that (having the steps described and visualized this clearly was a big help, @Etonkovidova)...we'll take a look.

Change 503503 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/UniversalLanguageSelector@master] Disable ULS in VE readOnly mode

https://gerrit.wikimedia.org/r/503503

gerritbot added a project: Patch-For-Review.Apr 12 2019, 9:04 PM

Esanders moved this task from Incoming to Code review on the VisualEditor (Current work) board.Apr 12 2019, 9:04 PM

Change 503503 merged by jenkins-bot:
[mediawiki/extensions/UniversalLanguageSelector@master] Disable ULS in VE readOnly mode

https://gerrit.wikimedia.org/r/503503

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.1; 2019-04-16).Apr 12 2019, 11:01 PM

• Petar.petkovic removed a project: Patch-For-Review.Apr 14 2019, 11:31 PM

• Petar.petkovic moved this task from In Progress to Needs QA on the Language-Team (Language-2019-April-June) board.

Change 503918 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Remove 'noime' classes from CE section nodes

https://gerrit.wikimedia.org/r/503918

gerritbot added a project: Patch-For-Review.Apr 15 2019, 2:44 AM

Moving past editing QA again as QA will be done by CX team.

Change 503918 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Remove 'noime' classes from CE section nodes

https://gerrit.wikimedia.org/r/503918

• Petar.petkovic removed a project: Patch-For-Review.Apr 19 2019, 10:08 AM

• Petar.petkovic moved this task from Needs QA to Recheck after deployment on the Language-Team (Language-2019-April-June) board.

Pginer-WMF moved this task from Recheck after deployment to Done on the Language-Team (Language-2019-April-June) board.Apr 23 2019, 8:39 AM

Pginer-WMF closed this task as Resolved.Apr 25 2019, 8:03 AM

	F28582038: Screen Shot 2019-04-04 at 11.56.43 AM.png
	Apr 4 2019, 7:56 PM

	F28582242: Screen Shot 2019-04-04 at 12.50.59 PM.png
	Apr 4 2019, 7:56 PM

	F28582246: Screen Shot 2019-04-04 at 12.51.28 PM.png
	Apr 4 2019, 7:56 PM

	F28511249: Screenshot 2019-03-29 at 10.19.16.png
	Mar 29 2019, 5:27 PM

CX2: Spellcheck and IME appearing for source sectionsClosed, ResolvedPublicActions