Page MenuHomePhabricator
Create Task
Maniphest T218426

Upgrade various Cloud VPS Python 2 scripts to Python 3
Open, MediumPublic
Actions

Description

So based on a git grep -E "^#\!/usr/bin/(env )?python([^3]|$)" in puppet.git I filtered through for stuff that looked Cloud VPS-related. It might be incomplete.
Ideally this stuff would be done this year.

modules/openstack/files/designate/designatemakedomain.py:#!/usr/bin/python
modules/openstack/files/monitor/fullstack/check_nova_fullstack_leaks.py:#!/usr/bin/python
modules/openstack/files/ussuri/admin_scripts/wmcs-cold-migrate.py:#!/usr/bin/python
modules/openstack/files/ussuri/admin_scripts/wmcs-cold-nova-migrate.py:#!/usr/bin/python
modules/openstack/files/ussuri/admin_scripts/wmcs-live-migrate.py:#!/usr/bin/python
modules/openstack/files/ussuri/admin_scripts/wmcs-logstat.py:#!/usr/bin/env python
modules/openstack/files/ussuri/admin_scripts/wmcs-makedomain.py:#!/usr/bin/python
modules/openstack/files/ussuri/admin_scripts/wmcs-region-migrate-security-groups.py:#!/usr/bin/python
modules/openstack/files/ussuri/admin_scripts/wmcs-region-migrate.py:#!/usr/bin/python
modules/openstack/files/ussuri/admin_scripts/wmcs-wikitech-grep.py:#!/usr/bin/env python
modules/openstack/files/victoria/admin_scripts/wmcs-cold-migrate.py:#!/usr/bin/python
modules/openstack/files/victoria/admin_scripts/wmcs-cold-nova-migrate.py:#!/usr/bin/python
modules/openstack/files/victoria/admin_scripts/wmcs-live-migrate.py:#!/usr/bin/python
modules/openstack/files/victoria/admin_scripts/wmcs-logstat.py:#!/usr/bin/env python
modules/openstack/files/victoria/admin_scripts/wmcs-makedomain.py:#!/usr/bin/python
modules/openstack/files/victoria/admin_scripts/wmcs-region-migrate-security-groups.py:#!/usr/bin/python
modules/openstack/files/victoria/admin_scripts/wmcs-region-migrate.py:#!/usr/bin/python
modules/openstack/files/victoria/admin_scripts/wmcs-wikitech-grep.py:#!/usr/bin/env python
modules/profile/files/toolforge/proxylistener.py:#!/usr/bin/env python

Details

ProjectBranchLines +/-Subject
operations/puppetproduction+0 -15 Kopenstack: remove ussuri files
operations/puppetproduction+195 -181Convert maintain-meta_p.py to python3
operations/puppetproduction+233 -186Convert wmcs-novastats scripts to python3
operations/puppetproduction+2 -2move puppet_alert script to python3
operations/puppetproduction+5 -5remove python2-only function from puppet_alert to move to py3
operations/puppetproduction+70 -0cloud-vps: Add python3 client packages in cloud
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT197804 Puppet: forbid new Python2 code
 OpenNoneT218426 Upgrade various Cloud VPS Python 2 scripts to Python 3
 ResolvedBUG REPORTBstormT218423 Add python 3 packages to openstack::clientpackages::common
 ResolvedMoritzMuehlenhoffT232677 Remove support for Debian Jessie in Cloud Services
 ResolvedNoneT218729 Migrate deployment-prep away from Debian Jessie to Debian Stretch/Buster
 ResolvedEevansT218609 Figure out future for newly created deployment-prep jessie instances
 ResolvedKrenairT220895 Udev (?) problems using modified swift puppet classes on deployment-ms-be0[56]
 ResolvedKrenairT221620 Editing Hiera namespace broken on wikitech for project admins with uppercase characters mid way through their name
 Resolved• elukeyT222461 Migrate deployment-zookeeper02 from jessie to stretch
 ResolvedNoneT238707 Migrate from deployment-logstash2 (jessie) to deployment-logstash03 (stretch)
 DeclinedNoneT241481 deployment-logstash03: UDP listener died EADDRINUSE, logstash port conflict with rsyslogd
 DeclinedNoneT276521 deployment-logstash03 puppet errors
 ResolvedNoneT244642 Do something about deployment-imagescaler01
 ResolvedJdforrester-WMFT246395 Decommission deployment-parsoid09
 ResolvedKrenairT250574 Replace deployment-restbase0[12]
 ResolvedthciprianiT250585 Determine purpose of deployment-memc0[67]
 ResolvedtaaviT276419 Replace deployment-fluorine02 with a Buster host
 ResolvedtaaviT276421 Package udplog for Buster
 ResolvedhasharT276422 Unarchive analytics/udplog repository
 ResolvedtaaviT276462 Replace deployment-etcd-01 with a Buster host
 ResolvedtaaviT276707 Replace deployment-memc[04-05] with Buster hosts
 ResolvedtaaviT277081 Replace deployment-ircd with a Buster host
 ResolvedAndrewT218119 Disable jessie VM creation in VPS
 ResolvedMusikAnimalT232786 Move eventmetrics Debian Jessie instances to Buster
 ResolvedMusikAnimalT232787 XTools: Move Debian Jessie instances to Buster
 ResolvedAndrewT205232 Request increased quota for xtools Cloud VPS project
 DuplicateNoneT233740 google-api-proxy: Move Debian Jessie instances to Buster
 Resolved• PhamhiT224585 Migrate labmon* to Buster
 ResolvedAndrewT239584 CloudVPS: keystone may need update in hardware servers running Buster
 ResolvedBstormT224582 Migrate labstore1004/labstore1005 to Stretch/Buster
 ResolvedBstormT253353 Add cluster-awareness to nfs-exportd
 ResolvedBstormT224583 Migrate labstore1006/1007 to Stretch/Buster

Event Timeline

Krenair created this task.Mar 15 2019, 7:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2019, 7:31 PM
Krenair added a subtask: T218423: Add python 3 packages to openstack::clientpackages::common.Mar 15 2019, 7:32 PM

The following:

modules/base/files/labs/notify_maintainers.py
modules/base/files/labs/puppet_alert.py
modules/ldap/files/scripts/ssh-key-ldap-lookup
modules/shinken/files/shinkengen

are probably blocked on T218423, probably.

bd808 renamed this task from Upgrade various Python 2 scripts to Python 3 to Upgrade various Cloud VPS/Toolforge Python 2 scripts to Python 3 .Mar 15 2019, 7:36 PM
Krenair added a subscriber: bd808.EditedMar 15 2019, 7:36 PM

@bd808 I actually separated the toolforge scripts into a different list which I haven't opened a task for yet

Krenair mentioned this in T218427: Upgrade various Toolforge infrastructure scripts from Python 2 to Python 3.Mar 15 2019, 7:37 PM
Krenair added a comment.Mar 15 2019, 7:39 PM

T218427: Upgrade various Toolforge infrastructure scripts from Python 2 to Python 3 for the tools project

Krenair renamed this task from Upgrade various Cloud VPS/Toolforge Python 2 scripts to Python 3 to Upgrade various Cloud VPS Python 2 scripts to Python 3 .Mar 15 2019, 7:40 PM
bd808 added a parent task: T197804: Puppet: forbid new Python2 code.Mar 15 2019, 7:41 PM
Krenair changed the status of subtask T218423: Add python 3 packages to openstack::clientpackages::common from Open to Stalled.Mar 21 2019, 12:55 PM
GTirloni triaged this task as Medium priority.Mar 21 2019, 4:57 PM
GTirloni added a project: cloud-services-team (Kanban).
Xqt added a subscriber: Xqt.Jul 24 2019, 8:36 AM
Krenair changed the status of subtask T218423: Add python 3 packages to openstack::clientpackages::common from Stalled to Open.Sep 22 2019, 11:58 AM
Bstorm changed the status of subtask T218423: Add python 3 packages to openstack::clientpackages::common from Open to Stalled.Dec 18 2019, 4:12 PM
Legoktm added a subscriber: Legoktm.Jan 22 2020, 6:43 AM

I think some of this stuff like dynamicproxy/invisible-unicorn.py would be easier to port/test if they were in separate repos - any opinions on that?

Legoktm mentioned this in T243378: Create python2 -> python3 porting Phabricator tag.Jan 22 2020, 10:33 AM
Aklapper added a project: Python3-Porting.Jan 22 2020, 4:26 PM
bd808 added a comment.Jan 22 2020, 11:31 PM
In T218426#5822004, @Legoktm wrote:

I think some of this stuff like dynamicproxy/invisible-unicorn.py would be easier to port/test if they were in separate repos - any opinions on that?

Our infrastructure for building and deploying deb packages is horrible. I would really not be excited about making dynamicproxy harder to deploy.

Legoktm added a comment.Jan 23 2020, 1:41 AM
In T218426#5825065, @bd808 wrote:
In T218426#5822004, @Legoktm wrote:

I think some of this stuff like dynamicproxy/invisible-unicorn.py would be easier to port/test if they were in separate repos - any opinions on that?

Our infrastructure for building and deploying deb packages is horrible. I would really not be excited about making dynamicproxy harder to deploy.

Oh, agreed. I was thinking of deploying out of a git checkout or something. But I'll try adding some tests to the existing puppet repo and see how it goes.

gerritbot added a comment.Aug 27 2020, 4:08 PM

Change 622844 had a related patch set uploaded (by Bstorm; owner: Bstorm):
[operations/puppet@production] remove python2-only function from puppet_alert to move to py3

https://gerrit.wikimedia.org/r/622844

gerritbot added a project: Patch-For-Review.Aug 27 2020, 4:08 PM
gerritbot added a comment.Aug 27 2020, 4:13 PM

Change 622846 had a related patch set uploaded (by Bstorm; owner: Bstorm):
[operations/puppet@production] move puppet_alert script to python3

https://gerrit.wikimedia.org/r/622846

Bstorm changed the status of subtask T218423: Add python 3 packages to openstack::clientpackages::common from Stalled to Open.Aug 27 2020, 4:25 PM
gerritbot added a comment.Aug 27 2020, 7:50 PM

Change 622874 had a related patch set uploaded (by Bstorm; owner: Bstorm):
[operations/puppet@production] cloud-vps: Add python3 client packages in cloud

https://gerrit.wikimedia.org/r/622874

gerritbot added a comment.Aug 28 2020, 6:36 PM

Change 622874 merged by Bstorm:
[operations/puppet@production] cloud-vps: Add python3 client packages in cloud

https://gerrit.wikimedia.org/r/622874

Bstorm closed subtask T218423: Add python 3 packages to openstack::clientpackages::common as Resolved.Aug 28 2020, 10:53 PM
gerritbot added a comment.Aug 31 2020, 11:00 PM

Change 622844 merged by Bstorm:
[operations/puppet@production] remove python2-only function from puppet_alert to move to py3

https://gerrit.wikimedia.org/r/622844

gerritbot added a comment.Sep 4 2020, 6:06 PM

Change 624805 had a related patch set uploaded (by Nskaggs; owner: Nskaggs):
[operations/puppet@production] Convert wmcs-novastats scripts to python3

https://gerrit.wikimedia.org/r/624805

gerritbot added a comment.Sep 4 2020, 7:27 PM

Change 622846 merged by Bstorm:
[operations/puppet@production] move puppet_alert script to python3

https://gerrit.wikimedia.org/r/622846

gerritbot added a comment.Sep 8 2020, 6:19 PM

Change 624805 merged by Andrew Bogott:
[operations/puppet@production] Convert wmcs-novastats scripts to python3

https://gerrit.wikimedia.org/r/624805

gerritbot added a comment.Sep 9 2020, 10:20 PM

Change 626235 had a related patch set uploaded (by Nskaggs; owner: Nskaggs):
[operations/puppet@production] Convert maintain-meta_p.py to python3

https://gerrit.wikimedia.org/r/626235

gerritbot added a comment.Nov 24 2020, 10:44 PM

Change 626235 abandoned by Nskaggs:
[operations/puppet@production] Convert maintain-meta_p.py to python3

Reason:
https://gerrit.wikimedia.org/r/c/operations/puppet/ /643363

https://gerrit.wikimedia.org/r/626235

taavi mentioned this in T281276: Upgrade cloud-vps openstack hosts to Debian 'Bullseye'.Aug 4 2021, 2:57 PM
taavi renamed this task from Upgrade various Cloud VPS Python 2 scripts to Python 3 to Upgrade various Cloud VPS Python 2 scripts to Python 3.Oct 28 2021, 6:51 AM
taavi updated the task description. (Show Details)Nov 20 2021, 4:55 PM
Volans mentioned this in T211750: Introduce Python code formatters usage.Apr 14 2022, 10:40 PM
gerritbot added a comment.Apr 26 2022, 8:34 AM

Change 786274 had a related patch set uploaded (by David Caro; author: David Caro):

[operations/puppet@production] openstack: remove ussuri files

https://gerrit.wikimedia.org/r/786274

gerritbot added a comment.May 5 2022, 3:06 PM

Change 786274 merged by David Caro:

[operations/puppet@production] openstack: remove ussuri files

https://gerrit.wikimedia.org/r/786274

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL