Log spam: "User account is not global"
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

Request ID: AWmgsnYsNBo9dX1koRDW

message

User account is not global

trace

#0 /srv/mediawiki/php-1.33.0-wmf.22/extensions/ContentTranslation/api/ApiQueryTranslatorStats.php(27): ContentTranslation\Translator->getGlobalUserId()
#1 /srv/mediawiki/php-1.33.0-wmf.22/includes/api/ApiQuery.php(249): ApiQueryTranslatorStats->execute()
#2 /srv/mediawiki/php-1.33.0-wmf.22/includes/api/ApiMain.php(1595): ApiQuery->execute()
#3 /srv/mediawiki/php-1.33.0-wmf.22/includes/api/ApiMain.php(531): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.33.0-wmf.22/includes/api/ApiMain.php(502): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.33.0-wmf.22/api.php(87): ApiMain->execute()
#6 /srv/mediawiki/w/api.php(3): include(string)
#7 {main}

Impact

Logspam

Notes

Missing checks in action=query&list=(contenttranslationsuggestions|cxtranslatorstats)

Details

Subject	Repo	Branch	Lines +/-
Catch "User account is not global" error	mediawiki/extensions/ContentTranslation	wmf/1.33.0-wmf.22	+6 -2
Return API error on anonymous suggestions queries	mediawiki/extensions/ContentTranslation	wmf/1.33.0-wmf.22	+6 -0
Catch "User account is not global" error	mediawiki/extensions/ContentTranslation	master	+6 -2
Return API error on anonymous suggestions queries	mediawiki/extensions/ContentTranslation	master	+6 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	zeljkofilipin	T206676 1.33.0-wmf.22 deployment blockers
		Resolved	PRODUCTION ERROR	• Petar.petkovic	T218902 Log spam: "User account is not global"

Event Timeline

zeljkofilipin triaged this task as Unbreak Now! priority.Mar 21 2019, 2:46 PM

zeljkofilipin created this task.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes, Aklapper. · View Herald TranscriptMar 21 2019, 2:46 PM

zeljkofilipin added projects: ContentTranslation, User-zeljkofilipin.Mar 21 2019, 2:49 PM

zeljkofilipin added a parent task: T206676: 1.33.0-wmf.22 deployment blockers.

zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.

I'm not sure if this is a new problem, but I could not find it in Phabricator (https://phabricator.wikimedia.org/search/query/90yLC89nlgsb/#R). 🤔

ApiQueryTranslatorStats.php(27) was last changed in 2017 by @Legoktm (https://phabricator.wikimedia.org/diffusion/ECTX/browse/master/api/ApiQueryTranslatorStats.php$27), but it was just a whitespace cleanup (https://phabricator.wikimedia.org/rECTX8f41719471d52cd172de65fbc393e4e85b9d9ac6)

It seems this affects list=cxtranslatorstats for logged out users and causes logspam, but likely no other impact. Likely caused by bot activity as there is no referrer and the API params make no sense.

Nikerabbit added projects: Language-Team (Language-2019-January-March), Unplanned-Sprint-Work.Mar 21 2019, 3:36 PM

Nikerabbit renamed this task from User account is not global to Log spam: "User account is not global" .Mar 21 2019, 3:58 PM

Nikerabbit updated the task description. (Show Details)

Change 498151 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Catch "User account is not global" error

https://gerrit.wikimedia.org/r/498151

gerritbot added a project: Patch-For-Review.Mar 21 2019, 4:58 PM

• Petar.petkovic claimed this task.Mar 21 2019, 4:59 PM

• Petar.petkovic moved this task from Backlog to In Review on the Language-Team (Language-2019-January-March) board.

Change 498156 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Return API error on anonymous suggestions queries

https://gerrit.wikimedia.org/r/498156

Change 498156 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Return API error on anonymous suggestions queries

https://gerrit.wikimedia.org/r/498156

Change 498151 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Catch "User account is not global" error

https://gerrit.wikimedia.org/r/498151

Worth back-porting? Logspam level looks manageable.

Given this was marked as train blocker, I would recommend backporting to avoid false alarms, but I'm leaving the decision to train drivers.

• Petar.petkovic removed a project: Patch-For-Review.Mar 21 2019, 6:59 PM

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).Mar 21 2019, 7:01 PM

Krinkle moved this task from Untriaged to Jan2020/1.35-wmf.14 on the Wikimedia-production-error board.Mar 21 2019, 8:06 PM

In T218902#5045610, @Nikerabbit wrote:

Given this was marked as train blocker, I would recommend backporting to avoid false alarms, but I'm leaving the decision to train drivers.

let's go ahead and backport unless there's other reasons not to (iow: let's default to keeping logspam to a minimum/fix it as it comes).

Change 498259 had a related patch set uploaded (by Jforrester; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@wmf/1.33.0-wmf.22] Return API error on anonymous suggestions queries

https://gerrit.wikimedia.org/r/498259

Change 498260 had a related patch set uploaded (by Jforrester; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@wmf/1.33.0-wmf.22] Catch "User account is not global" error

https://gerrit.wikimedia.org/r/498260

Change 498259 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@wmf/1.33.0-wmf.22] Return API error on anonymous suggestions queries

https://gerrit.wikimedia.org/r/498259

Mentioned in SAL (#wikimedia-operations) [2019-03-21T23:32:24Z] <jforrester@deploy1001> Synchronized php-1.33.0-wmf.22/extensions/ContentTranslation/api/ApiQueryContentTranslationSuggestions.php: SWAT T218902 CX: Return API error on anonymous suggestions queries (duration: 00m 51s)