Page MenuHomePhabricator
Create Task
Maniphest T219144

wbterms: Register new terms store schema changes with MW update mechanism
Closed, ResolvedPublic
Actions

Description

  • register new store schema DDL repo/sql/AddNormalizedTermsTablesDDL.sql

This task should only make the tables create.
This should not use the tables for anything

Details

SubjectRepoBranchLines +/-
Stop creating new term store tables explicitly in new term store testsmediawiki/extensions/Wikibasemaster+0 -119
Register new term store tablesmediawiki/extensions/Wikibasemaster+4 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• alaa_wmde created this task.Mar 25 2019, 12:33 PM
• alaa_wmde added a parent task: T219120: [Checkpoint 1] Create Schema, Migration plan and Doctrine DBAL connection .
• alaa_wmde removed a parent task: T219143: Write DDL sql files for creating the schema.
• alaa_wmde moved this task from Backlog to Checkpoint Backlog [Create the Schema] on the Wikidata wb_terms Trailblazing board.
• alaa_wmde moved this task from Checkpoint Backlog [Create the Schema] to Ready to go [prioritized] on the Wikidata wb_terms Trailblazing board.Mar 25 2019, 12:38 PM
JeroenDeDauw subscribed.Mar 25 2019, 3:43 PM

Blocked on https://phabricator.wikimedia.org/T219142

Lydia_Pintscher added a project: Wikidata.Mar 25 2019, 3:58 PM
Addshore moved this task from incoming to in progress on the Wikidata board.Mar 25 2019, 3:59 PM
JeroenDeDauw renamed this task from Update update.php with the new SQL files to Register schema schanges with MW update mechanism.Apr 4 2019, 8:36 PM
JeroenDeDauw updated the task description. (Show Details)
JeroenDeDauw moved this task from Ready to go [prioritized] to In Progress on the Wikidata wb_terms Trailblazing board.Apr 7 2019, 8:06 AM

First step https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/501992

JeroenDeDauw added a comment.Apr 7 2019, 9:21 AM

Also part of this: https://github.com/wmde/wikibase-term-store/pull/7

JeroenDeDauw moved this task from In Progress to In Review on the Wikidata wb_terms Trailblazing board.Apr 9 2019, 10:08 AM
• alaa_wmde moved this task from In Review to Stalled on the Wikidata wb_terms Trailblazing board.Apr 23 2019, 8:16 AM
• alaa_wmde added a comment.Apr 23 2019, 8:19 AM

this won't be merged yet accord. to migration plan.. there'll be a follow up release and annoucement about this change for all other wikibase instances so that they can prepare themselves for a long migration in case they have a massive database, otherwise small ones won't probably even notice.

This can be done now though and hidden behind a feature flag.. I wouldn't prefer that but up to you

Ladsgroup subscribed.Apr 23 2019, 11:28 AM
In T219144#5129631, @alaa_wmde wrote:

this won't be merged yet accord. to migration plan.. there'll be a follow up release and annoucement about this change for all other wikibase instances so that they can prepare themselves for a long migration in case they have a massive database, otherwise small ones won't probably even notice.

This can be done now though and hidden behind a feature flag.. I wouldn't prefer that but up to you

I personally prefer we do this later as any change to the schema would require another patch, let's run some tests on it and then wire it to the extension.

• alaa_wmde added a comment.Apr 23 2019, 8:04 PM
This comment was removed by • alaa_wmde.
• alaa_wmde edited parent tasks, added: T219302: wb_terms trailblazing wrapup - Prepare report, announcements and next step; removed: T219120: [Checkpoint 1] Create Schema, Migration plan and Doctrine DBAL connection .Apr 23 2019, 8:40 PM
• alaa_wmde moved this task from Stalled to Backlog on the Wikidata wb_terms Trailblazing board.
• alaa_wmde moved this task from in progress to hold on the Wikidata board.Jul 22 2019, 8:53 AM
• alaa_wmde edited projects, added Wikidata-Campsite; removed Wikidata wb_terms Trailblazing.

This is for later, once we completely migrate to new store in wikidata production and is stable for a while.

• alaa_wmde moved this task from Incoming to Blocked / Waiting / External on the Wikidata-Campsite board.Jul 22 2019, 8:53 AM
• alaa_wmde renamed this task from Register schema schanges with MW update mechanism to Register new terms store schema schanges with MW update mechanism.Jul 22 2019, 8:55 AM
• alaa_wmde updated the task description. (Show Details)
Addshore added a parent task: T208425: [EPIC] Kill the wb_terms table.Oct 31 2019, 7:37 AM
Addshore mentioned this in T208425: [EPIC] Kill the wb_terms table.Oct 31 2019, 7:44 AM
Addshore moved this task from Blocked / Waiting / External to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jan 7 2020, 1:34 PM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Addshore triaged this task as Low priority.Jan 14 2020, 4:10 PM
Addshore raised the priority of this task from Low to Medium.Jan 16 2020, 2:40 PM
Addshore updated the task description. (Show Details)
Addshore removed parent tasks: T208425: [EPIC] Kill the wb_terms table, T219302: wb_terms trailblazing wrapup - Prepare report, announcements and next step.Jan 16 2020, 3:44 PM
Addshore added a parent task: T242723: Use new terms store by default on Wikibase installs.
Addshore mentioned this in T242723: Use new terms store by default on Wikibase installs.Jan 16 2020, 3:50 PM
Addshore renamed this task from Register new terms store schema schanges with MW update mechanism to Register new terms store schema changes with MW update mechanism.Jan 16 2020, 4:26 PM
Addshore renamed this task from Register new terms store schema changes with MW update mechanism to wbterms: Register new terms store schema changes with MW update mechanism.Jan 16 2020, 4:33 PM
Ladsgroup claimed this task.Jan 17 2020, 10:08 AM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 17 2020, 10:08 AM
gerritbot added a comment.Jan 17 2020, 10:14 AM

Change 565524 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Register new term store tables

https://gerrit.wikimedia.org/r/565524

gerritbot added a project: Patch-For-Review.Jan 17 2020, 10:14 AM
Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 17 2020, 10:14 AM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Jan 17 2020, 10:15 AM
gerritbot added a comment.Jan 17 2020, 10:50 AM

Change 565529 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Stop creating new term store tables explicitly in new term store tests

https://gerrit.wikimedia.org/r/565529

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 17 2020, 11:15 AM
gerritbot added a comment.Jan 17 2020, 11:36 AM

Change 565524 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Register new term store tables

https://gerrit.wikimedia.org/r/565524

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 17 2020, 12:00 PM
gerritbot added a comment.Jan 17 2020, 12:25 PM

Change 565529 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Stop creating new term store tables explicitly in new term store tests

https://gerrit.wikimedia.org/r/565529

WMDE-leszek added subscribers: Addshore, WMDE-leszek.Jan 21 2020, 10:42 AM

Is there anything left to do here @Ladsgroup @Addshore ?
Looks kind of done, although some recent change seems to have caused T243218.

Addshore closed this task as Resolved.Jan 22 2020, 10:39 PM
Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.Jan 22 2020, 11:18 PM
DannyS712 updated the task description. (Show Details)Sep 20 2020, 7:42 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL