Page MenuHomePhabricator

Remove calls to deprecated methods in Title and User with calls to the new PermissionManager service.
Open, Needs TriagePublic3 Story Points

Description

The methods deprecated in T208768: Create a PermissionManager service and T218558: Move User::getRights and related methods into PermissionManager should no longer be called in MediaWiki core. Calling code should use the methods in the new PermissionManager service instead.

In service classes that are already managed by MediaWikiServices or use a static singleton, a PermissionManager instance should be injected into the constructor. Other classes can use the global MediaWikiServices instance as a service locator to access a PermissionManager instance.

Event Timeline

Change 511064 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] EditPage: Migrate Title::userCan() calls to PermissionManager

https://gerrit.wikimedia.org/r/511064

Change 511068 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] API: Migrate Title::userCan() calls to PermissionManager

https://gerrit.wikimedia.org/r/511068

Change 511064 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Migrate Title::userCan() calls to PermissionManager

https://gerrit.wikimedia.org/r/511064

WDoranWMF set the point value for this task to 3.May 28 2019, 7:20 PM
WDoranWMF added a subscriber: WDoranWMF.

@daniel will review to check if this sub tasks are accurate

  • Quantity of calls is an unknown
    • We may also wish to investigate how to inject this

Change 511068 merged by jenkins-bot:
[mediawiki/core@master] API: Migrate Title::userCan() calls to PermissionManager

https://gerrit.wikimedia.org/r/511068

Change 513974 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] Migrate remaining usages of Title::userCan() to PermissionManager

https://gerrit.wikimedia.org/r/513974

Change 513974 merged by jenkins-bot:
[mediawiki/core@master] Migrate remaining usages of Title::userCan() to PermissionManager

https://gerrit.wikimedia.org/r/513974

Change 530623 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] WIP: Replace User::isAllowed with PermissionManager.

https://gerrit.wikimedia.org/r/530623

Change 531329 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Remove usages of deprecated User::getRights.

https://gerrit.wikimedia.org/r/531329

Change 530623 merged by jenkins-bot:
[mediawiki/core@master] Replace User::isAllowed with PermissionManager.

https://gerrit.wikimedia.org/r/530623

Change 531329 merged by jenkins-bot:
[mediawiki/core@master] Remove usages of deprecated User::getRights.

https://gerrit.wikimedia.org/r/531329

Change 531503 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Replace usages of deprecated User::getRights. Step 2.

https://gerrit.wikimedia.org/r/531503

Change 531529 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/Wikibase@master] [Tests] Don't mock deprecated User::isAllowed for testing.

https://gerrit.wikimedia.org/r/531529

Change 531529 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] [Tests] Don't mock deprecated User::isAllowed for testing.

https://gerrit.wikimedia.org/r/531529

Change 531575 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] WIP: Deprecate and replace usages of User:isAllowed{All,Any}

https://gerrit.wikimedia.org/r/531575

Change 531590 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Remove deprecated User::getGroupPermissions calls.

https://gerrit.wikimedia.org/r/531590

Change 531590 merged by jenkins-bot:
[mediawiki/core@master] Remove deprecated User groups/permission static calls.

https://gerrit.wikimedia.org/r/531590

Change 531575 merged by Ppchelko:
[mediawiki/core@master] Deprecate and replace usages of User:isAllowed{All,Any}

https://gerrit.wikimedia.org/r/531575

Change 531761 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Make DefaultPreferencesFactory depend on PermissionManager.

https://gerrit.wikimedia.org/r/531761

Change 531772 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/GlobalPreferences@master] Provide PermissionManager to PreferencesFactory constructor.

https://gerrit.wikimedia.org/r/531772

Change 531995 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/Wikibase@master] Remove deprecated User methods.

https://gerrit.wikimedia.org/r/531995

Change 532486 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Move User::getAll{Rights,Groups} to PermissionManager.

https://gerrit.wikimedia.org/r/532486

daniel reassigned this task from daniel to Pchelolo.Thu, Aug 29, 4:24 PM

Change 532486 merged by jenkins-bot:
[mediawiki/core@master] Move User::getAllRights to PermissionManager.

https://gerrit.wikimedia.org/r/532486

Change 534258 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/Flow@master] Remove obvious usages of deprecated methods in User,Title,Revision.

https://gerrit.wikimedia.org/r/534258

Change 534258 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Remove obvious usages of deprecated methods in User,Title,Revision.

https://gerrit.wikimedia.org/r/534258

Change 531995 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove usage of deprecated User methods.

https://gerrit.wikimedia.org/r/531995

Change 531503 merged by jenkins-bot:
[mediawiki/core@master] Replace usages of deprecated User::isAllowed. Step 2.

https://gerrit.wikimedia.org/r/531503

Change 536235 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/WikibaseLexeme@master] Remove usages of deprecated User methods.

https://gerrit.wikimedia.org/r/536235

Change 531761 merged by jenkins-bot:
[mediawiki/core@master] Make DefaultPreferencesFactory depend on PermissionManager.

https://gerrit.wikimedia.org/r/531761

Change 536353 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] DefaultPreferencesManager: Remove fallback for null PermissionManager

https://gerrit.wikimedia.org/r/536353

Change 536235 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Remove usages of deprecated User methods.

https://gerrit.wikimedia.org/r/536235

Change 536685 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Make WatchedItemQueryService depend on PermissionManager

https://gerrit.wikimedia.org/r/536685

Change 536685 merged by jenkins-bot:
[mediawiki/core@master] Make WatchedItemQueryService depend on PermissionManager

https://gerrit.wikimedia.org/r/536685

Change 531772 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Provide PermissionManager to PreferencesFactory constructor.

https://gerrit.wikimedia.org/r/531772

Change 536353 merged by jenkins-bot:
[mediawiki/core@master] DefaultPreferencesFactory: Remove fallback for null PermissionManager

https://gerrit.wikimedia.org/r/536353

Change 537758 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/GlobalPreferences@master] Replace deprecated User::isAllowed.

https://gerrit.wikimedia.org/r/537758

Change 537766 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/extensions/AbuseFilter@master] Remove usages of deprecated User methods

https://gerrit.wikimedia.org/r/537766

Change 537758 merged by jenkins-bot:
[mediawiki/extensions/GlobalPreferences@master] Replace deprecated User::isAllowed.

https://gerrit.wikimedia.org/r/537758