Page MenuHomePhabricator

Remove calls to deprecated methods in Title and User with calls to the new PermissionManager service.
Open, Needs TriagePublic3 Story Points

Description

The methods deprecated in T208768: Create a PermissionManager service and T218558: Move User::getRights and related methods into PermissionManager should no longer be called in MediaWiki core. Calling code should use the methods in the new PermissionManager service instead.

In service classes that are already managed by MediaWikiServices or use a static singleton, a PermissionManager instance should be injected into the constructor. Other classes can use the global MediaWikiServices instance as a service locator to access a PermissionManager instance.

Event Timeline

Change 511064 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] EditPage: Migrate Title::userCan() calls to PermissionManager

https://gerrit.wikimedia.org/r/511064

Change 511068 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] API: Migrate Title::userCan() calls to PermissionManager

https://gerrit.wikimedia.org/r/511068

Change 511064 merged by jenkins-bot:
[mediawiki/core@master] EditPage: Migrate Title::userCan() calls to PermissionManager

https://gerrit.wikimedia.org/r/511064

WDoranWMF set the point value for this task to 3.May 28 2019, 7:20 PM
WDoranWMF added a subscriber: WDoranWMF.

@daniel will review to check if this sub tasks are accurate

  • Quantity of calls is an unknown
    • We may also wish to investigate how to inject this

Change 511068 merged by jenkins-bot:
[mediawiki/core@master] API: Migrate Title::userCan() calls to PermissionManager

https://gerrit.wikimedia.org/r/511068

Change 513974 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] Migrate remaining usages of Title::userCan() to PermissionManager

https://gerrit.wikimedia.org/r/513974

Change 513974 merged by jenkins-bot:
[mediawiki/core@master] Migrate remaining usages of Title::userCan() to PermissionManager

https://gerrit.wikimedia.org/r/513974