Page MenuHomePhabricator
Create Task
Maniphest T208764

Remove cyclic dependency between Title and User classes
Open, MediumPublic
Actions

Description

Two of the most used classes of MediaWiki core are the Title class and the User class. Currently, they depend on each other. Removing this circular dependency is an important step in modularizing MediaWiki core.

Top priority should be given top publicly visible direct dependencies, but eventually, all dependencies binding the two classes together in a circular way should be removed, including indirect dependencies, and dependencies in private code.

This is one of the outcomes of T206080: Wikimedia Technical Conference 2018 Session - Architecting core: layers/components/libraries.

1280px-Techconf_-_Architecting_Core_2_-_Layers_Components_Libraries5.jpg (960×1 px, 95 KB)

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT208764 Remove cyclic dependency between Title and User classes
 ResolvedVedmakaT208766 Deprecate User::isWatched, isTempWatched, addWatch, and removeWatch
 ResolvedCCicalese_WMFT223165 Implement access restrictions in WatchedItemStore
 ResolvedBPirkleT208775 Hard-deprecate Title::moveTo
 ResolvedDannyS712T221949 Remove uses of Title::moveTo
 DuplicateArt-BaltaiT243953 Remove Title::moveTo
 ResolvedDannyS712T208777 Factor notification-related methods out of User and Title, introduce WatchlistNotificationManager
 Resolved• ClarakosiT239640 Introduce TalkPageNotificationManager service
 ResolvedDannyS712T253435 UserClearNewTalkNotification hook: document UserIdentity instead of User
 OpenNoneT208778 Make User::getUserPage and User::getTalkPage return a LinkTarget
 ResolvedPeter.ovchynT218395 Create RestrictionStore service
 DuplicateNoneT218394 Create BlockStore service
 ResolvedTchandersT219441 Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP
 Declined• PcheloloT220191 Remove calls to deprecated methods in Title and User with calls to the new PermissionManager service.
 ResolveddanielT223294 Deprecate the $mRights field in the User class, replacing it with a cache in PermissionManager.
 DeclinedNoneT223295 Make PermissionManager aware of the current user's session.
 ResolvedVedmakaT218558 Move User::getRights and related methods into PermissionManager
 ResolvedVedmakaT208768 Create a PermissionManager service
 ResolvedCCicalese_WMFT281187 Hard deprecate watchlist methods in User
 ResolvedCCicalese_WMFT292464 Remove hard deprecated Watchlist methods in User, Title, and WatchAction

Event Timeline

daniel created this task.Nov 5 2018, 7:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2018, 7:19 PM
daniel updated the task description. (Show Details)Nov 5 2018, 7:22 PM
daniel added a subtask: T195069: Factor PageStore and PageRecord out of WikiPage.Nov 5 2018, 7:50 PM
daniel removed a subtask: T195069: Factor PageStore and PageRecord out of WikiPage.Nov 5 2018, 7:54 PM
daniel removed a subtask: T208776: RFC: Introduce PageIdentity to be used instead of WikiPage.Nov 5 2018, 8:05 PM
daniel added a project: MediaWiki-Decoupling.Nov 6 2018, 1:57 PM
daniel removed a parent task: T206080: Wikimedia Technical Conference 2018 Session - Architecting core: layers/components/libraries.
CCicalese_WMF moved this task from Inbox to Later on the Platform Team Legacy board.Nov 6 2018, 5:59 PM
CCicalese_WMF edited projects, added Platform Team Legacy (Later); removed Platform Team Legacy.
daniel mentioned this in T206498: MediaWiki needlessly queries page data twice on page views.Nov 15 2018, 4:11 PM
• jlinehan subscribed.Nov 15 2018, 4:15 PM
Vedmaka subscribed.Jan 14 2019, 9:17 PM
daniel renamed this task from Remove circular dependency between Title and User classes to Remove cyclic dependency between Title and User classes.Feb 13 2019, 4:28 PM
tosfos subscribed.Mar 4 2019, 3:28 PM
daniel added a subtask: T218394: Create BlockStore service.Mar 15 2019, 12:28 PM
CCicalese_WMF edited projects, added Platform Engineering (Decoupling (CDP2)); removed MediaWiki-Decoupling, Platform Engineering (Needs Cleaning - Code Health (TEC13)).Mar 26 2019, 4:43 PM
daniel triaged this task as Medium priority.Apr 3 2019, 2:19 PM
daniel added a subtask: T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP.
daniel mentioned this in T208776: RFC: Introduce PageIdentity to be used instead of WikiPage.Apr 3 2019, 7:17 PM
daniel closed subtask T208768: Create a PermissionManager service as Resolved.May 14 2019, 3:54 PM
dbarratt closed subtask T219441: Introduce a BlockManager service for getting and combining the blocks that apply to a user/IP as Resolved.May 22 2019, 6:06 PM
daniel closed subtask T208775: Hard-deprecate Title::moveTo as Resolved.May 29 2019, 9:15 AM
daniel closed subtask T218558: Move User::getRights and related methods into PermissionManager as Resolved.May 29 2019, 7:23 PM
kostajh reopened subtask T218558: Move User::getRights and related methods into PermissionManager as Open.May 30 2019, 2:13 PM
daniel closed subtask T218558: Move User::getRights and related methods into PermissionManager as Resolved.Jul 1 2019, 10:09 AM
• WDoranWMF moved this task from Later to Mop Column on the Platform Team Legacy board.Jul 5 2019, 2:54 PM
• WDoranWMF removed a project: Platform Team Legacy (Later).
• WDoranWMF moved this task from Decoupling (CDP2) to mop on the Platform Engineering board.Jul 26 2019, 6:56 PM
• WDoranWMF edited projects, added Core Platform Team Initiatives (Decoupling (CDP2)); removed Platform Engineering (Decoupling (CDP2)).
DannyS712 subscribed.May 19 2020, 5:24 AM
DannyS712 closed subtask T208777: Factor notification-related methods out of User and Title, introduce WatchlistNotificationManager as Resolved.Jun 5 2020, 2:34 AM
CCicalese_WMF added a subtask: T281187: Hard deprecate watchlist methods in User.Apr 29 2021, 2:51 PM
CCicalese_WMF closed subtask T208766: Deprecate User::isWatched, isTempWatched, addWatch, and removeWatch as Resolved.
DannyS712 updated the task description. (Show Details)Apr 29 2021, 5:49 PM
CCicalese_WMF closed subtask T281187: Hard deprecate watchlist methods in User as Resolved.May 5 2021, 5:37 PM
• Pchelolo closed subtask T220191: Remove calls to deprecated methods in Title and User with calls to the new PermissionManager service. as Declined.Jun 17 2021, 10:50 PM
Aklapper removed daniel as the assignee of this task.Jul 2 2021, 5:19 AM

Removing task assignee due to inactivity, as this open task has been assigned for more than two years (see emails sent to assignee on May26 and Jun17, and T270544). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be very welcome!

(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

daniel added projects: Epic, Platform Team Workboards (MW Expedition).Jul 2 2021, 12:52 PM
• Pchelolo closed subtask T218395: Create RestrictionStore service as Resolved.Sep 9 2021, 8:07 PM
CCicalese_WMF added a subtask: T292464: Remove hard deprecated Watchlist methods in User, Title, and WatchAction.Oct 4 2021, 5:22 PM
• Pchelolo closed subtask T292464: Remove hard deprecated Watchlist methods in User, Title, and WatchAction as Resolved.Oct 19 2021, 3:11 AM
Aklapper added a project: MediaWiki-General.Oct 17 2023, 10:19 AM
Aklapper removed a subscriber: • jlinehan.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits