Page MenuHomePhabricator

Remove uses of Title::moveTo
Open, Needs TriagePublic

Description

Title::moveTo will be hard-deprecated soon; all callers (in core and wmf-maintained extensions; codesearch) should be removed, most likely by changing them to use MovePage instead.

Beware of the following caveat, though:

So moveTo() does a couple of extra things that MovePage doesn't. It calls spreadAnyEditBlock() if there's an error, and honors the suppressredirect permission. Why are these not done in MovePage proper? As it stands, it considerably complicates porting the existing users, which are fairly numerous.

Event Timeline

Restricted Application removed a project: Patch-For-Review. · View Herald TranscriptApr 26 2019, 10:36 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 504545 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/extensions/Wikibase@master] Use MovePage instead of deprecated Title::moveTo

https://gerrit.wikimedia.org/r/504545

That caveat should be removed by https://gerrit.wikimedia.org/r/504336 when that lands.

Change 504545 merged by Daniel Kinzler:
[mediawiki/extensions/Wikibase@master] Use MovePage instead of deprecated Title::moveTo

https://gerrit.wikimedia.org/r/504545

Change 507861 had a related patch set uploaded (by Jforrester; owner: simetrical):
[mediawiki/extensions/Wikibase@master] Re-apply: Use MovePage instead of deprecated Title::moveTo

https://gerrit.wikimedia.org/r/507861

Change 507861 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Re-apply: Use MovePage instead of deprecated Title::moveTo

https://gerrit.wikimedia.org/r/507861