Title::moveTo has been deprecated since 1.25, and has been hard-deprecated in 1.34. Its uses should now be removed.
All callers (in core and wmf-maintained extensions; codesearch) should be gone by now. If there are any left, they must be changed to to use MovePage instead.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T208764 Remove cyclic dependency between Title and User classes | |||
| Resolved | BPirkle | T208775 Hard-deprecate Title::moveTo | |||
| Resolved | DannyS712 | T221949 Remove uses of Title::moveTo | |||
| Duplicate | Art-Baltai | T243953 Remove Title::moveTo |
Change 504545 had a related patch set uploaded (by simetrical; owner: simetrical):
[mediawiki/extensions/Wikibase@master] Use MovePage instead of deprecated Title::moveTo
That caveat should be removed by https://gerrit.wikimedia.org/r/504336 when that lands.
Change 504545 merged by Daniel Kinzler:
[mediawiki/extensions/Wikibase@master] Use MovePage instead of deprecated Title::moveTo
Change 507861 had a related patch set uploaded (by Jforrester; owner: simetrical):
[mediawiki/extensions/Wikibase@master] Re-apply: Use MovePage instead of deprecated Title::moveTo
Change 507861 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Re-apply: Use MovePage instead of deprecated Title::moveTo
It is unclear to me if this task is about MW core (one patch mentioned), or random unknown MW extensions (one patch mentioned), or a mess of both, as zero code repository project tags have been added to this task.
I count three remaining uses to be removed:
The code search includes calls to UploadedFile::moveTo and GlobalUsage::moveTo, as well as some tests for the function that can be removed with the function itself
Change 560349 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/LiquidThreads@master] Replace deprecated Title::moveTo with MovePage method
Change 560349 abandoned by DannyS712:
Replace deprecated Title::moveTo with MovePage method
Reason:
Already removed in I6404c92407ce8ab910bcf0e70aebfd15c5cb429d
Change 560350 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/WikimediaMaintenance@master] Replace deprecated Title::moveTo with MovePage method
Change 560351 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/UserMerge@master] Replace deprecated Title::moveTo with MovePage method
Change 560350 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] Replace deprecated Title::moveTo with MovePage method
The sole remaining issue here is to add a test for UserMerge that tests the page move, so we can merge the respective patch with confidence:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/+/560351
I've still been working on this, not sure why I was removed as the assignee...
Added a test to the patch
Change 566838 had a related patch set uploaded (by Art-Baltai; owner: Art-Baltai):
[mediawiki/extensions/UserMerge@master] component: Refactofing of Title::moveTo to MovePageFactory->MovePage
Oh, sorry, @DannyS712 :)
We get the same code, so it looks correct.
Also, I added an example for global invoke
https://3v4l.org/MpY9D
https://3v4l.org/hjYJo
link is temporary
Change 566838 abandoned by Art-Baltai:
component: Refactofing of Title::moveTo to MovePageFactory->MovePage
Reason:
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/ /560351
I close my patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UserMerge/+/566838
note about global var
<?php class Orig {}; class Override {}; $instance = new Orig; function test() { global $instance; $newInstance = new Override; $instance=$newInstance; check(); } function check() { global $instance; var_dump($instance); } test();
Result:
$instance = new Override;
so Title::moveTo will use $wgUser, not $oldUser
Yes, since Title::moveTo defaults to $wgUser, I left the behavior the same by passing $wgUser for the move call.
Change 560351 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@master] Replace deprecated Title::moveTo with MovePage method
Restore scope to just the usage replacements - actual removal will be as part of T241341: Remove Title::isValidMoveOperation(), ::moveTo(), and ::isValidMoveTarget() (deprecated in favor of MovePage's methods)