I just tried this again, and I was only able to produce it the one time. All the other times, the "enter-question-text" event showed up. If the engineers confirm that the code is hooked up to record them, that's good enough for me.

And interested in thoughts on whether that initial event should be "open" or "review".

In betalabs enter-question-text are duly recorded from Homepage:

MariaDB [log]> select distinct(event_editor_interface)  from HelpPanel_18973214 where event_action='enter-question-text';
+------------------------+
| event_editor_interface |
+------------------------+
| homepage_mentorship    |
| homepage_help          |
+------------------------+
2 rows in set (0.00 sec)

The sequence of events for submitting the quesiton via Help panel :

HomepageModule 
{…}
​
event: Object { action: "hover-in", action_data: "archivedQuestions=0;unarchivedQuestions=0", user_id: 29926, … }
​
revision: 19000731
​
schema: "HomepageModule"
​
webHost: "test.wikipedia.org"
​
wiki: "testwiki"
​
<prototype>: Object { … }
load.php:84:768
HelpPanel 
{…}
​
event: Object { action: "review", user_id: 29926, user_editcount: 493, … }
​
revision: 18973214
​
schema: "HelpPanel"
​
webHost: "test.wikipedia.org"
​
wiki: "testwiki"
​
<prototype>: Object { … }
load.php:84:768
HomepageModule 
{…}
​
event: Object { action: "hover-out", action_data: "archivedQuestions=0;unarchivedQuestions=0", user_id: 29926, … }
​
revision: 19000731
​
schema: "HomepageModule"
​
webHost: "test.wikipedia.org"
​
wiki: "testwiki"
​
<prototype>: Object { … }
load.php:84:768
HelpPanel 
{…}
​
event: Object { action: "submit-attempt", action_data: "question_length=4;include_title=true;had_email=true;had_email_confirmed=true;email_form_has_content=true;email_form_changed=false", user_id: 29926, … }
​
revision: 18973214
​
schema: "HelpPanel"
​
webHost: "test.wikipedia.org"
​
wiki: "testwiki"
​
<prototype>: Object { … }
load.php:84:768
HelpPanel 
{…}
​
event: Object { action: "submit-success", action_data: "question_length=4;include_title=true;had_email=true;had_email_confirmed=true;email_form_has_content=true;email_form_changed=false;revision_id=391901;email_action_status=already_confirmed", user_id: 29926, … }
​
revision: 18973214
​
schema: "HelpPanel"
​
webHost: "test.wikipedia.org"
​
wiki: "testwiki"
​
<prototype>: Object { … }
load.php:84:768

​

Based on the measurement specification, if I open one of the Help or Mentor modules from the homepage, enter some text and submit it, then close the module, I'd expect the following events to be recorded in the HelpPanel schema:

1. action="open"
2. action="enter-question-text"
3. action="submit-attempt"
4. action="submit-success"
5. action="close"

Currently, I'm unable to trigger the open and enter-question-text events in neither Firefox nor Chrome.

So, "review" in this context should be treated as "open". The reason it's called "review" is because it is basically identical to to the "review" part of the help panel (it's using the same code). If it's important to change, we could look into it. However, given that the help_panel_session_id is the same as the homepage_view_token which is the same as what's generated in the HomepageVisit, do we have enough information already to be able to identify that a help panel "review" action is part of a homepage module workflow and not a random "review" action disconnected from anything else?

Currently, I'm unable to trigger the [...] enter-question-text events in neither Firefox nor Chrome.

Hmm. I can reproduce this in Chrome 74 but not in Firefox 68.

Hmm. I can reproduce this in Chrome 74 but not in Firefox 68.

Nevermind. I can't reproduce it in Chrome.

enter-question-text is fired only when the textbox goes from empty to non-empty. If it already contains some text because an earlier question was drafted but not submitted, new changes to the text won't fire any event. This was defined as a rule for Help Panel so we know the textbox is interacted with but we don't fire too many events.

We could change it to something like: fire only the first time the text changes between open (or review) and close.

Note: enter-question-text also fires when the dialog is re-opened after a question was successfully posted. I think this is a bug.

enter-question-text is fired only when the textbox goes from empty to non-empty. If it already contains some text because an earlier question was drafted but not submitted, new changes to the text won't fire any event. This was defined as a rule for Help Panel so we know the textbox is interacted with but we don't fire too many events.

What I was seeing last night was, clearing the text, adding new text – it didn't matter, enter-question-text never fired. I can't reproduce it now though.

Note: enter-question-text also fires when the dialog is re-opened after a question was successfully posted. I think this is a bug.

Right. I'll submit a fix for this.

Change 507591 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Ensure text exists before logging enter-question-text action

https://gerrit.wikimedia.org/r/507591

Change 507591 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Ensure text exists before logging enter-question-text action

https://gerrit.wikimedia.org/r/507591

Change 507598 had a related patch set uploaded (by Sbisson; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.3] Ensure text exists before logging enter-question-text action

https://gerrit.wikimedia.org/r/507598

In T222239#5149298, @kostajh wrote:

So, "review" in this context should be treated as "open". The reason it's called "review" is because it is basically identical to to the "review" part of the help panel (it's using the same code). If it's important to change, we could look into it.

Thanks for clarifying that! I don't think it's something we need to change. Instead, I've made a note for my Homepage analysis so I don't forget this and get confused again.

However, given that the help_panel_session_id is the same as the homepage_view_token which is the same as what's generated in the HomepageVisit, do we have enough information already to be able to identify that a help panel "review" action is part of a homepage module workflow and not a random "review" action disconnected from anything else?

We have the matching IDs and the two editor_interface settings for events generated from the Homepage, I'm confident that we have what we need to be able to separate HelpPanel events coming through the Homepage from those coming from elsewhere.

Change 507598 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.34.0-wmf.3] Ensure text exists before logging enter-question-text action

https://gerrit.wikimedia.org/r/507598

In T222239#5149924, @kostajh wrote:

Note: enter-question-text also fires when the dialog is re-opened after a question was successfully posted. I think this is a bug.

Right. I'll submit a fix for this.

This was deployed to production just now.